Page MenuHomePhabricator
Differential D13467

Enable AES encryption with custom IV on web/keyserver
AbandonedPublic
Actions

Authored by marcin on Sep 25 2024, 11:05 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 9, 8:51 AM
Unknown Object (File)
Sun, Mar 9, 8:51 AM
Unknown Object (File)
Sun, Mar 9, 8:51 AM
Unknown Object (File)
Tue, Feb 25, 6:06 PM
Unknown Object (File)
Mon, Feb 24, 10:00 AM
Unknown Object (File)
Wed, Feb 19, 2:31 AM
Unknown Object (File)
Feb 9 2025, 1:55 PM
Unknown Object (File)
Jan 21 2025, 4:25 AM
View All 41 Files
Subscribers
ashoat

Details

Reviewers
kamil
tomek
bartek
Summary

Same as for parent differential but for web/keyserver

Test Plan

TODO

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

marcin created this revision.Sep 25 2024, 11:05 AM
Herald added a subscriber: ashoat. · View Herald TranscriptSep 25 2024, 11:05 AM
marcin added a parent revision: D13466: Enable AES encryption with custom IV on native.Sep 25 2024, 11:09 AM
marcin added a child revision: D13468: Add AES cryptography to EncryptedNotifUtilsAPI.Sep 25 2024, 11:12 AM
Harbormaster completed remote builds in B31850: Diff 44560.Sep 25 2024, 11:22 AM
marcin requested review of this revision.Sep 25 2024, 11:22 AM
marcin removed a child revision: D13468: Add AES cryptography to EncryptedNotifUtilsAPI.Sep 26 2024, 1:30 AM
ashoat added inline comments.Sep 26 2024, 7:28 AM
lib/media/aes-crypto-utils-common.js
17

IV is unclear. Can you type the full name out, or a more clear shortened version (InitVector?), in all cases?

  • IV_LENGTH
  • generateIVCommon
  • generateIV
  • etc.
marcin abandoned this revision.Sep 26 2024, 1:06 PM

Sorry for the confusion. This differential was supposed to bo abandoned.

Revision Contents
Changeset List

PathSize
keyserver/
src/
utils/
10 lines
lib/
media/
16 lines

Diff 44560

View Options

keyserver/src/utils/aes-crypto-utils.js

// @flow // @flow
import { requireNativeModule } from 'expo-modules-core'; import { requireNativeModule } from 'expo-modules-core';
import invariant from 'invariant'; import invariant from 'invariant';
const KEY_SIZE = 32; // bytes const KEY_SIZE = 32; // bytes
const IV_LENGTH = 12; // bytes, IV - unique Initialization Vector (nonce) const IV_LENGTH = 12; // bytes, IV - unique Initialization Vector (nonce)
const TAG_LENGTH = 16; // bytes - GCM auth tag const TAG_LENGTH = 16; // bytes - GCM auth tag
const AESCryptoModule: { const AESCryptoModule: {
+generateKey: (destination: Uint8Array) => void, +generateKey: (destination: Uint8Array) => void,
+generateIV: (destination: Uint8Array) => void,
+encrypt: ( +encrypt: (
key: Uint8Array, key: Uint8Array,
data: Uint8Array, data: Uint8Array,
destination: Uint8Array, destination: Uint8Array,
initializationVector: Uint8Array,
) => void, ) => void,
+decrypt: ( +decrypt: (
key: Uint8Array, key: Uint8Array,
data: Uint8Array, data: Uint8Array,
destination: Uint8Array, destination: Uint8Array,
) => void, ) => void,
} = requireNativeModule('AESCrypto'); } = requireNativeModule('AESCrypto');
export function generateKey(): Uint8Array { export function generateKey(): Uint8Array {
const keyBuffer = new Uint8Array(KEY_SIZE); const keyBuffer = new Uint8Array(KEY_SIZE);
AESCryptoModule.generateKey(keyBuffer); AESCryptoModule.generateKey(keyBuffer);
return keyBuffer; return keyBuffer;
} }
export function encrypt(key: Uint8Array, data: Uint8Array): Uint8Array { export function generateIV(): Uint8Array {
const ivBuffer = new Uint8Array(IV_LENGTH);
AESCryptoModule.generateIV(ivBuffer);
return ivBuffer;
}
export function encrypt(
key: Uint8Array,
data: Uint8Array,
initializationVector?: ?Uint8Array,
): Uint8Array {
const sealedDataBuffer = new Uint8Array(data.length + IV_LENGTH + TAG_LENGTH); const sealedDataBuffer = new Uint8Array(data.length + IV_LENGTH + TAG_LENGTH);
AESCryptoModule.encrypt(key, data, sealedDataBuffer); const iv = initializationVector ?? new Uint8Array(0);
AESCryptoModule.encrypt(key, data, sealedDataBuffer, iv);
return sealedDataBuffer; return sealedDataBuffer;
} }
export function decrypt(key: Uint8Array, data: Uint8Array): Uint8Array { export function decrypt(key: Uint8Array, data: Uint8Array): Uint8Array {
invariant(data.length >= IV_LENGTH + TAG_LENGTH, 'Invalid data length'); invariant(data.length >= IV_LENGTH + TAG_LENGTH, 'Invalid data length');
const plaintextBuffer = new Uint8Array(data.length - IV_LENGTH - TAG_LENGTH); const plaintextBuffer = new Uint8Array(data.length - IV_LENGTH - TAG_LENGTH);
AESCryptoModule.decrypt(key, data, plaintextBuffer); AESCryptoModule.decrypt(key, data, plaintextBuffer);
return plaintextBuffer; return plaintextBuffer;
} }
View Options

lib/media/aes-crypto-utils-common.js

// @flow // @flow
import { requireNativeModule } from 'expo-modules-core'; import { requireNativeModule } from 'expo-modules-core';
import invariant from 'invariant'; import invariant from 'invariant';
const KEY_SIZE = 32; // bytes const KEY_SIZE = 32; // bytes
const IV_LENGTH = 12; // bytes, IV - unique Initialization Vector (nonce) const IV_LENGTH = 12; // bytes, IV - unique Initialization Vector (nonce)
const TAG_LENGTH = 16; // bytes - GCM auth tag const TAG_LENGTH = 16; // bytes - GCM auth tag
const AESCryptoModule: { const AESCryptoModule: {
+generateKey: (destination: Uint8Array) => void, +generateKey: (destination: Uint8Array) => void,
+generateIV: (destination: Uint8Array) => void,
+encrypt: ( +encrypt: (
key: Uint8Array, key: Uint8Array,
data: Uint8Array, data: Uint8Array,
destination: Uint8Array, destination: Uint8Array,
initializationVector: Uint8Array,
) => void, ) => void,
+decrypt: ( +decrypt: (
key: Uint8Array, key: Uint8Array,
data: Uint8Array, data: Uint8Array,
destination: Uint8Array, destination: Uint8Array,
) => void, ) => void,
} = requireNativeModule('AESCrypto'); } = requireNativeModule('AESCrypto');
export function generateKey(): Uint8Array { export function generateKey(): Uint8Array {
const keyBuffer = new Uint8Array(KEY_SIZE); const keyBuffer = new Uint8Array(KEY_SIZE);
AESCryptoModule.generateKey(keyBuffer); AESCryptoModule.generateKey(keyBuffer);
return keyBuffer; return keyBuffer;
} }
export function encrypt(key: Uint8Array, data: Uint8Array): Uint8Array { export function generateIV(): Uint8Array {
const ivBuffer = new Uint8Array(IV_LENGTH);
AESCryptoModule.generateIV(ivBuffer);
return ivBuffer;
}
export function encrypt(
key: Uint8Array,
data: Uint8Array,
initializationVector?: ?Uint8Array,
): Uint8Array {
const sealedDataBuffer = new Uint8Array(data.length + IV_LENGTH + TAG_LENGTH); const sealedDataBuffer = new Uint8Array(data.length + IV_LENGTH + TAG_LENGTH);
AESCryptoModule.encrypt(key, data, sealedDataBuffer); const iv = initializationVector ?? new Uint8Array(0);
AESCryptoModule.encrypt(key, data, sealedDataBuffer, iv);
return sealedDataBuffer; return sealedDataBuffer;
} }
export function decrypt(key: Uint8Array, data: Uint8Array): Uint8Array { export function decrypt(key: Uint8Array, data: Uint8Array): Uint8Array {
invariant(data.length >= IV_LENGTH + TAG_LENGTH, 'Invalid data length'); invariant(data.length >= IV_LENGTH + TAG_LENGTH, 'Invalid data length');
const plaintextBuffer = new Uint8Array(data.length - IV_LENGTH - TAG_LENGTH); const plaintextBuffer = new Uint8Array(data.length - IV_LENGTH - TAG_LENGTH);
AESCryptoModule.decrypt(key, data, plaintextBuffer); AESCryptoModule.decrypt(key, data, plaintextBuffer);
return plaintextBuffer; return plaintextBuffer;
} }