Page MenuHomePhabricator
Differential D12844

[SQLite] implement query for searching messages
ClosedPublic
Actions

Authored by kamil on Jul 22 2024, 10:15 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 20, 6:47 AM
Unknown Object (File)
Wed, Mar 19, 9:08 AM
Unknown Object (File)
Feb 21 2025, 6:32 AM
Unknown Object (File)
Feb 21 2025, 6:32 AM
Unknown Object (File)
Feb 21 2025, 6:32 AM
Unknown Object (File)
Feb 21 2025, 6:32 AM
Unknown Object (File)
Jan 22 2025, 12:19 AM
Unknown Object (File)
Jan 10 2025, 7:47 PM
View All 70 Files
Subscribers
ashoat

Details

Reviewers
tomek
inka
Commits
rCOMM3b9546b1e346: [SQLite] implement query for searching messages
Summary

Query similar to keyserver version.

Depends on D12843

Test Plan

Tested in D12851

Diff Detail

Repository
rCOMM Comm
Branch
cpp-search-2
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Jul 22 2024, 10:15 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptJul 22 2024, 10:15 AM
Harbormaster failed remote builds in B30573: Diff 42637!Jul 22 2024, 10:35 AM
kamil updated this revision to Diff 42666.Jul 23 2024, 2:53 AM

rebase

kamil added a child revision: D12850: [SQLite] add Emscripten bindings for message search.Jul 23 2024, 2:53 AM
kamil edited the test plan for this revision. (Show Details)Jul 23 2024, 2:55 AM
Harbormaster completed remote builds in B30592: Diff 42666.Jul 23 2024, 3:12 AM
kamil published this revision for review.Jul 23 2024, 5:03 AM
kamil mentioned this in D12843: [SQLite] add method for message search to SQLiteQueryExecutor for both web and native.
kamil added inline comments.
native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp
2574

there is no ; on purpose

2589

we can't use this becuase this will require adding folly dependency to .wasm

tomek accepted this revision.Jul 23 2024, 6:15 AM
inka accepted this revision.Jul 23 2024, 6:22 AM
This revision is now accepted and ready to land.Jul 23 2024, 6:22 AM
Closed by commit rCOMM3b9546b1e346: [SQLite] implement query for searching messages (authored by kamil). · Explain WhyJul 23 2024, 8:18 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM3b9546b1e346: [SQLite] implement query for searching messages.
ashoat added inline comments.Jul 31 2024, 6:52 PM
native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp
2589

Maybe I shouldn't have abandoned D12761

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
DatabaseManagers/
45 lines
web/
shared-worker/
_generated/

Diff 42666

View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp

Show All 11 Linesimport type {
OLMPrekey, OLMPrekey,
} from '../types/crypto-types'; } from '../types/crypto-types';
import type { OlmSessionInitializationInfo } from '../types/request-types'; import type { OlmSessionInitializationInfo } from '../types/request-types';
import { useLegacyAshoatKeyserverCall } from '../utils/action-utils.js'; import { useLegacyAshoatKeyserverCall } from '../utils/action-utils.js';
import type { import type {
CallSingleKeyserverEndpointOptions, CallSingleKeyserverEndpointOptions,
CallSingleKeyserverEndpoint, CallSingleKeyserverEndpoint,
} from '../utils/call-single-keyserver-endpoint.js'; } from '../utils/call-single-keyserver-endpoint.js';
import { values, entries } from '../utils/objects.js'; import { values } from '../utils/objects.js';
import { useDispatchActionPromise } from '../utils/redux-promise-utils.js'; import { useDispatchActionPromise } from '../utils/redux-promise-utils.js';
export type InitialNotifMessageOptions = { export type InitialNotifMessageOptions = {
+callSingleKeyserverEndpoint?: ?CallSingleKeyserverEndpoint, +callSingleKeyserverEndpoint?: ?CallSingleKeyserverEndpoint,
+callSingleKeyserverEndpointOptions?: ?CallSingleKeyserverEndpointOptions, +callSingleKeyserverEndpointOptions?: ?CallSingleKeyserverEndpointOptions,
}; };
const initialEncryptedMessageContent = { const initialEncryptedMessageContent = {
▲ Show 20 Lines • Show All 70 Lines • ▼ Show 20 Linesfunction getOneTimeKeyValuesFromBlob(keyBlob: string): $ReadOnlyArray<string> {
return getOneTimeKeyValues(oneTimeKeys); return getOneTimeKeyValues(oneTimeKeys);
} }
function getPrekeyValueFromBlob(prekeyBlob: string): string { function getPrekeyValueFromBlob(prekeyBlob: string): string {
const prekey: OLMPrekey = JSON.parse(prekeyBlob); const prekey: OLMPrekey = JSON.parse(prekeyBlob);
return getPrekeyValue(prekey); return getPrekeyValue(prekey);
} }
function getOneTimeKeyArray(
oneTimeKeys: OLMOneTimeKeys,
): $ReadOnlyArray<string> {
return entries(oneTimeKeys.curve25519).map(([key, value]: [string, string]) =>
JSON.stringify({ curve25519: { [key]: value } }),
);
}
export { export {
getOneTimeKeyValues, getOneTimeKeyValues,
getPrekeyValue, getPrekeyValue,
getOneTimeKeyValuesFromBlob, getOneTimeKeyValuesFromBlob,
getPrekeyValueFromBlob, getPrekeyValueFromBlob,
initialEncryptedMessageContent, initialEncryptedMessageContent,
useInitialNotificationsEncryptedMessage, useInitialNotificationsEncryptedMessage,
getOneTimeKeyArray,
}; };
View Options

web/shared-worker/_generated/comm_query_executor.wasm

Show All 11 Linesimport type {
OLMPrekey, OLMPrekey,
} from '../types/crypto-types'; } from '../types/crypto-types';
import type { OlmSessionInitializationInfo } from '../types/request-types'; import type { OlmSessionInitializationInfo } from '../types/request-types';
import { useLegacyAshoatKeyserverCall } from '../utils/action-utils.js'; import { useLegacyAshoatKeyserverCall } from '../utils/action-utils.js';
import type { import type {
CallSingleKeyserverEndpointOptions, CallSingleKeyserverEndpointOptions,
CallSingleKeyserverEndpoint, CallSingleKeyserverEndpoint,
} from '../utils/call-single-keyserver-endpoint.js'; } from '../utils/call-single-keyserver-endpoint.js';
import { values, entries } from '../utils/objects.js'; import { values } from '../utils/objects.js';
import { useDispatchActionPromise } from '../utils/redux-promise-utils.js'; import { useDispatchActionPromise } from '../utils/redux-promise-utils.js';
export type InitialNotifMessageOptions = { export type InitialNotifMessageOptions = {
+callSingleKeyserverEndpoint?: ?CallSingleKeyserverEndpoint, +callSingleKeyserverEndpoint?: ?CallSingleKeyserverEndpoint,
+callSingleKeyserverEndpointOptions?: ?CallSingleKeyserverEndpointOptions, +callSingleKeyserverEndpointOptions?: ?CallSingleKeyserverEndpointOptions,
}; };
const initialEncryptedMessageContent = { const initialEncryptedMessageContent = {
▲ Show 20 Lines • Show All 70 Lines • ▼ Show 20 Linesfunction getOneTimeKeyValuesFromBlob(keyBlob: string): $ReadOnlyArray<string> {
return getOneTimeKeyValues(oneTimeKeys); return getOneTimeKeyValues(oneTimeKeys);
} }
function getPrekeyValueFromBlob(prekeyBlob: string): string { function getPrekeyValueFromBlob(prekeyBlob: string): string {
const prekey: OLMPrekey = JSON.parse(prekeyBlob); const prekey: OLMPrekey = JSON.parse(prekeyBlob);
return getPrekeyValue(prekey); return getPrekeyValue(prekey);
} }
function getOneTimeKeyArray(
oneTimeKeys: OLMOneTimeKeys,
): $ReadOnlyArray<string> {
return entries(oneTimeKeys.curve25519).map(([key, value]: [string, string]) =>
JSON.stringify({ curve25519: { [key]: value } }),
);
}
export { export {
getOneTimeKeyValues, getOneTimeKeyValues,
getPrekeyValue, getPrekeyValue,
getOneTimeKeyValuesFromBlob, getOneTimeKeyValuesFromBlob,
getPrekeyValueFromBlob, getPrekeyValueFromBlob,
initialEncryptedMessageContent, initialEncryptedMessageContent,
useInitialNotificationsEncryptedMessage, useInitialNotificationsEncryptedMessage,
getOneTimeKeyArray,
}; };