Page MenuHomePhabricator
Differential D12761

[SQLite][native] Extract MessageType to DatabaseManagers
AbandonedPublicDraft
Actions

Authored by ashoat on Jul 15 2024, 2:17 PM.
Tags
None
Referenced Files
F3524672: D12761.id42304.diff
Mon, Dec 23, 1:52 PM
F3524665: D12761.id.diff
Mon, Dec 23, 1:52 PM
F3524664: D12761.diff
Mon, Dec 23, 1:52 PM
Unknown Object (File)
Tue, Dec 3, 9:28 AM
Unknown Object (File)
Nov 9 2024, 3:48 PM
Unknown Object (File)
Nov 1 2024, 12:02 PM
Unknown Object (File)
Oct 14 2024, 4:42 PM
Unknown Object (File)
Oct 14 2024, 4:42 PM
View All 40 Files
Subscribers
None

Details

Reviewers
kamil
tomek
marcin
Summary

I want to reuse this from the DatabaseManagers codebase, which is isolated from NativeModules so that it can be compiled to WASM for web.

As such, I'm moving it into that folder, where it can be accessed from the whole codebase.

Depends on D12760

Test Plan

Make sure it compiles

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.Jul 15 2024, 2:17 PM
ashoat added a child revision: D12762: [SQLite] Query for latest edit in getLatestMessageEdit.
ashoat retitled this revision from [native] Extract MessageType to DatabaseManagers to [SQLite][native] Extract MessageType to DatabaseManagers.Jul 15 2024, 2:24 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Jul 15 2024, 2:37 PM
Harbormaster failed remote builds in B30342: Diff 42304!
ashoat abandoned this revision.Jul 15 2024, 7:04 PM

We don't actually need this, now that I'm doing the business logic in JS (see here)

ashoat removed a parent revision: D12760: [SQLite] Factor out SQLiteQueryExecutor::processMessagesResults.Jul 15 2024, 7:05 PM
ashoat mentioned this in D12844: [SQLite] implement query for searching messages.Jul 31 2024, 6:52 PM
ashoat mentioned this in D12869: [native][web] Fill target_message column for sidebar source.Jul 31 2024, 7:18 PM

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
DatabaseManagers/
entities/
31 lines
NativeModules/
PersistentStorageUtilities/
MessageOperationsUtilities/
27 lines

Diff 42304

View Options

native/cpp/CommonCpp/DatabaseManagers/entities/MessageType.h

Loading...
View Options

native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/MessageOperationsUtilities/MessageSpecs.h

Loading...