Page MenuHomePhabricator

[SQLite] add method for message search to SQLiteQueryExecutor for both web and native
ClosedPublic

Authored by kamil on Jul 22 2024, 10:13 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 1, 7:41 PM
Unknown Object (File)
Sun, Oct 20, 12:57 PM
Unknown Object (File)
Tue, Oct 15, 7:49 PM
Unknown Object (File)
Mon, Oct 14, 3:16 PM
Unknown Object (File)
Mon, Oct 14, 3:16 PM
Unknown Object (File)
Mon, Oct 14, 3:16 PM
Unknown Object (File)
Mon, Oct 14, 3:16 PM
Unknown Object (File)
Fri, Oct 11, 12:18 AM
Subscribers

Details

Summary

Defining API, logic will be implemented in searchMessages in the next diff.

Depends on D12833

Test Plan

N/A, just defining method arguments and returned type

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil held this revision as a draft.
kamil published this revision for review.Jul 23 2024, 5:03 AM
kamil added inline comments.
native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp
2559 ↗(On Diff #42665)

implemented in D12844

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.h
206 ↗(On Diff #42665)

for the web we need MessageWithMedias, and for native MessageEntity - this can be avoided after ENG-5719

tomek added inline comments.
native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp
2625 ↗(On Diff #42665)
2628 ↗(On Diff #42665)

Why do we move only the first item?

This revision is now accepted and ready to land.Jul 23 2024, 6:10 AM
marcin added inline comments.
native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp
2628 ↗(On Diff #42665)

The type of messageWithMedia.first is Message. The Message type has unique_ptr fields. Therefore it doesn't have copy constructor so it must be moved when passing to function.

rename

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp
2628 ↗(On Diff #42665)

Thanks!