Page MenuHomePhabricator
Differential D12852

[web] introduce message searching to shared worker
ClosedPublic
Actions

Authored by kamil on Jul 23 2024, 3:05 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 18, 1:42 AM
Unknown Object (File)
Mon, Mar 10, 8:45 AM
Unknown Object (File)
Fri, Mar 7, 1:37 AM
Unknown Object (File)
Wed, Mar 5, 6:48 AM
Unknown Object (File)
Mar 3 2025, 1:04 PM
Unknown Object (File)
Feb 25 2025, 3:27 AM
Unknown Object (File)
Feb 21 2025, 3:33 AM
Unknown Object (File)
Feb 21 2025, 3:33 AM
View All Files
Subscribers
ashoat
inka

Details

Reviewers
tomek
inka
Commits
rCOMM81fc7466f203: [web] introduce message searching to shared worker
Summary

The code on the web to interface with the search API exposed via WASM.

Depends on D12851

Test Plan

Tested later in the stack by @inka.

Diff Detail

Repository
rCOMM Comm
Branch
land-cpp-search
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Jul 23 2024, 3:05 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptJul 23 2024, 3:05 AM
kamil added a child revision: D12853: [native] introduce message searching to `CommCoreModule`.Jul 23 2024, 3:09 AM
kamil edited the summary of this revision. (Show Details)Jul 23 2024, 3:27 AM
Harbormaster completed remote builds in B30597: Diff 42671.Jul 23 2024, 3:37 AM
kamil published this revision for review.Jul 23 2024, 5:03 AM
kamil added inline comments.
web/types/worker-types.js
298–306 ↗(On Diff #42671)

we can merge those two and name something like MessagesResponse but not sure if worth

tomek accepted this revision.Jul 23 2024, 6:28 AM
tomek added inline comments.
web/types/worker-types.js
298–306 ↗(On Diff #42671)

Sounds quite cheap, we can have e.g. GetMessagesResponse.

This revision is now accepted and ready to land.Jul 23 2024, 6:28 AM
kamil updated this revision to Diff 42703.Jul 23 2024, 7:58 AM

merge types

Harbormaster completed remote builds in B30616: Diff 42703.Jul 23 2024, 8:14 AM
Closed by commit rCOMM81fc7466f203: [web] introduce message searching to shared worker (authored by kamil). · Explain WhyJul 23 2024, 8:18 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM81fc7466f203: [web] introduce message searching to shared worker.

Revision Contents
Changeset List

PathSize
web/
shared-worker/
worker/
13 lines
types/
18 lines

Diff 42703

View Options

web/shared-worker/worker/shared-worker.js

Show All 20 Lines
import { useNewThread } from 'lib/actions/thread-actions.js'; import { useNewThread } from 'lib/actions/thread-actions.js';
import { import {
uploadMultimedia, uploadMultimedia,
updateMultimediaMessageMediaActionType, updateMultimediaMessageMediaActionType,
useBlobServiceUpload, useBlobServiceUpload,
type MultimediaUploadCallbacks, type MultimediaUploadCallbacks,
type MultimediaUploadExtras, type MultimediaUploadExtras,
type BlobServiceUploadAction, type BlobServiceUploadAction,
type BlobServiceUploadResult,
} from 'lib/actions/upload-actions.js'; } from 'lib/actions/upload-actions.js';
import commStaffCommunity from 'lib/facts/comm-staff-community.js'; import commStaffCommunity from 'lib/facts/comm-staff-community.js';
import { pathFromURI, replaceExtension } from 'lib/media/file-utils.js'; import { pathFromURI, replaceExtension } from 'lib/media/file-utils.js';
import { import {
isLocalUploadID, isLocalUploadID,
getNextLocalUploadID, getNextLocalUploadID,
} from 'lib/media/media-utils.js'; } from 'lib/media/media-utils.js';
import { videoDurationLimit } from 'lib/media/video-utils.js'; import { videoDurationLimit } from 'lib/media/video-utils.js';
▲ Show 20 Lines • Show All 797 Lines • ▼ Show 20 Lines ): Promise<?string> {
const { hasWiFi } = this.props; const { hasWiFi } = this.props;
const uploadStart = Date.now(); const uploadStart = Date.now();
let uploadExceptionMessage, let uploadExceptionMessage,
uploadResult, uploadResult,
uploadThumbnailResult, uploadThumbnailResult,
mediaMissionResult; mediaMissionResult;
try { try {
const uploadPromises = [];
if ( if (
this.useBlobServiceUploads && this.useBlobServiceUploads &&
(processedMedia.mediaType === 'encrypted_photo' || (processedMedia.mediaType === 'encrypted_photo' ||
processedMedia.mediaType === 'encrypted_video') processedMedia.mediaType === 'encrypted_video')
) { ) {
uploadPromises.push( const uploadPromise = this.props.blobServiceUpload({
this.props.blobServiceUpload({
uploadInput: { uploadInput: {
blobInput: { blobInput: {
type: 'uri', type: 'uri',
uri: uploadURI, uri: uploadURI,
filename: filename, filename: filename,
mimeType: mime, mimeType: mime,
}, },
blobHash: processedMedia.blobHash, blobHash: processedMedia.blobHash,
encryptionKey: processedMedia.encryptionKey, encryptionKey: processedMedia.encryptionKey,
dimensions: processedMedia.dimensions, dimensions: processedMedia.dimensions,
thumbHash: thumbHash:
processedMedia.mediaType === 'encrypted_photo' processedMedia.mediaType === 'encrypted_photo'
? processedMedia.thumbHash ? processedMedia.thumbHash
: null, : null,
}, },
keyserverOrThreadID: threadInfo.id, keyserverOrThreadID: threadInfo.id,
callbacks: { callbacks: {
blobServiceUploadHandler, blobServiceUploadHandler,
onProgress: (percent: number) => { onProgress: (percent: number) => {
this.setProgress( this.setProgress(
localMessageID, localMessageID,
localMediaID, localMediaID,
'uploading', 'uploading',
percent, percent,
); );
}, },
}, },
}), });
);
if (processedMedia.mediaType === 'encrypted_video') { const uploadThumbnailPromise: Promise<?BlobServiceUploadResult> =
uploadPromises.push( (async () => {
this.props.blobServiceUpload({ if (processedMedia.mediaType !== 'encrypted_video') {
return undefined;
}
return await this.props.blobServiceUpload({
uploadInput: { uploadInput: {
blobInput: { blobInput: {
type: 'uri', type: 'uri',
uri: processedMedia.uploadThumbnailURI, uri: processedMedia.uploadThumbnailURI,
filename: replaceExtension(`thumb${filename}`, 'jpg'), filename: replaceExtension(`thumb${filename}`, 'jpg'),
mimeType: 'image/jpeg', mimeType: 'image/jpeg',
}, },
blobHash: processedMedia.thumbnailBlobHash, blobHash: processedMedia.thumbnailBlobHash,
encryptionKey: processedMedia.thumbnailEncryptionKey, encryptionKey: processedMedia.thumbnailEncryptionKey,
loop: false, loop: false,
dimensions: processedMedia.dimensions, dimensions: processedMedia.dimensions,
thumbHash: processedMedia.thumbHash, thumbHash: processedMedia.thumbHash,
}, },
keyserverOrThreadID: threadInfo.id, keyserverOrThreadID: threadInfo.id,
callbacks: { callbacks: {
blobServiceUploadHandler, blobServiceUploadHandler,
}, },
}), });
); })();
}
[uploadResult, uploadThumbnailResult] = await Promise.all( [uploadResult, uploadThumbnailResult] = await Promise.all([
uploadPromises, uploadPromise,
); uploadThumbnailPromise,
]);
} else { } else {
uploadPromises.push( const uploadPromise = this.props.uploadMultimedia(
this.props.uploadMultimedia(
{ uri: uploadURI, name: filename, type: mime }, { uri: uploadURI, name: filename, type: mime },
{ {
...processedMedia.dimensions, ...processedMedia.dimensions,
loop: loop:
processedMedia.mediaType === 'video' || processedMedia.mediaType === 'video' ||
processedMedia.mediaType === 'encrypted_video' processedMedia.mediaType === 'encrypted_video'
? processedMedia.loop ? processedMedia.loop
: undefined, : undefined,
encryptionKey: processedMedia.encryptionKey, encryptionKey: processedMedia.encryptionKey,
thumbHash: thumbHash:
processedMedia.mediaType === 'photo' || processedMedia.mediaType === 'photo' ||
processedMedia.mediaType === 'encrypted_photo' processedMedia.mediaType === 'encrypted_photo'
? processedMedia.thumbHash ? processedMedia.thumbHash
: null, : null,
}, },
{ {
onProgress: (percent: number) => onProgress: (percent: number) =>
this.setProgress( this.setProgress(
localMessageID, localMessageID,
localMediaID, localMediaID,
'uploading', 'uploading',
percent, percent,
), ),
uploadBlob: this.uploadBlob, uploadBlob: this.uploadBlob,
}, },
),
); );
const uploadThumbnailPromise: Promise<?UploadMultimediaResult> =
(async () => {
if ( if (
processedMedia.mediaType === 'video' || processedMedia.mediaType !== 'video' &&
processedMedia.mediaType === 'encrypted_video' processedMedia.mediaType !== 'encrypted_video'
) { ) {
uploadPromises.push( return undefined;
this.props.uploadMultimedia( }
return await this.props.uploadMultimedia(
{ {
uri: processedMedia.uploadThumbnailURI, uri: processedMedia.uploadThumbnailURI,
name: replaceExtension(`thumb${filename}`, 'jpg'), name: replaceExtension(`thumb${filename}`, 'jpg'),
type: 'image/jpeg', type: 'image/jpeg',
}, },
{ {
...processedMedia.dimensions, ...processedMedia.dimensions,
loop: false, loop: false,
encryptionKey: processedMedia.thumbnailEncryptionKey, encryptionKey: processedMedia.thumbnailEncryptionKey,
thumbHash: processedMedia.thumbHash, thumbHash: processedMedia.thumbHash,
}, },
{ {
uploadBlob: this.uploadBlob, uploadBlob: this.uploadBlob,
}, },
),
);
}
[uploadResult, uploadThumbnailResult] = await Promise.all(
uploadPromises,
); );
})();
[uploadResult, uploadThumbnailResult] = await Promise.all([
uploadPromise,
uploadThumbnailPromise,
]);
} }
mediaMissionResult = { success: true }; mediaMissionResult = { success: true };
} catch (e) { } catch (e) {
uploadExceptionMessage = getMessageForException(e); uploadExceptionMessage = getMessageForException(e);
onUploadFailed(localMediaID, 'upload failed'); onUploadFailed(localMediaID, 'upload failed');
mediaMissionResult = { mediaMissionResult = {
success: false, success: false,
reason: 'http_upload_failed', reason: 'http_upload_failed',
▲ Show 20 Lines • Show All 787 Lines • Show Last 20 Lines
View Options

web/types/worker-types.js

Show All 20 Lines
import { useNewThread } from 'lib/actions/thread-actions.js'; import { useNewThread } from 'lib/actions/thread-actions.js';
import { import {
uploadMultimedia, uploadMultimedia,
updateMultimediaMessageMediaActionType, updateMultimediaMessageMediaActionType,
useBlobServiceUpload, useBlobServiceUpload,
type MultimediaUploadCallbacks, type MultimediaUploadCallbacks,
type MultimediaUploadExtras, type MultimediaUploadExtras,
type BlobServiceUploadAction, type BlobServiceUploadAction,
type BlobServiceUploadResult,
} from 'lib/actions/upload-actions.js'; } from 'lib/actions/upload-actions.js';
import commStaffCommunity from 'lib/facts/comm-staff-community.js'; import commStaffCommunity from 'lib/facts/comm-staff-community.js';
import { pathFromURI, replaceExtension } from 'lib/media/file-utils.js'; import { pathFromURI, replaceExtension } from 'lib/media/file-utils.js';
import { import {
isLocalUploadID, isLocalUploadID,
getNextLocalUploadID, getNextLocalUploadID,
} from 'lib/media/media-utils.js'; } from 'lib/media/media-utils.js';
import { videoDurationLimit } from 'lib/media/video-utils.js'; import { videoDurationLimit } from 'lib/media/video-utils.js';
▲ Show 20 Lines • Show All 797 Lines • ▼ Show 20 Lines ): Promise<?string> {
const { hasWiFi } = this.props; const { hasWiFi } = this.props;
const uploadStart = Date.now(); const uploadStart = Date.now();
let uploadExceptionMessage, let uploadExceptionMessage,
uploadResult, uploadResult,
uploadThumbnailResult, uploadThumbnailResult,
mediaMissionResult; mediaMissionResult;
try { try {
const uploadPromises = [];
if ( if (
this.useBlobServiceUploads && this.useBlobServiceUploads &&
(processedMedia.mediaType === 'encrypted_photo' || (processedMedia.mediaType === 'encrypted_photo' ||
processedMedia.mediaType === 'encrypted_video') processedMedia.mediaType === 'encrypted_video')
) { ) {
uploadPromises.push( const uploadPromise = this.props.blobServiceUpload({
this.props.blobServiceUpload({
uploadInput: { uploadInput: {
blobInput: { blobInput: {
type: 'uri', type: 'uri',
uri: uploadURI, uri: uploadURI,
filename: filename, filename: filename,
mimeType: mime, mimeType: mime,
}, },
blobHash: processedMedia.blobHash, blobHash: processedMedia.blobHash,
encryptionKey: processedMedia.encryptionKey, encryptionKey: processedMedia.encryptionKey,
dimensions: processedMedia.dimensions, dimensions: processedMedia.dimensions,
thumbHash: thumbHash:
processedMedia.mediaType === 'encrypted_photo' processedMedia.mediaType === 'encrypted_photo'
? processedMedia.thumbHash ? processedMedia.thumbHash
: null, : null,
}, },
keyserverOrThreadID: threadInfo.id, keyserverOrThreadID: threadInfo.id,
callbacks: { callbacks: {
blobServiceUploadHandler, blobServiceUploadHandler,
onProgress: (percent: number) => { onProgress: (percent: number) => {
this.setProgress( this.setProgress(
localMessageID, localMessageID,
localMediaID, localMediaID,
'uploading', 'uploading',
percent, percent,
); );
}, },
}, },
}), });
);
if (processedMedia.mediaType === 'encrypted_video') { const uploadThumbnailPromise: Promise<?BlobServiceUploadResult> =
uploadPromises.push( (async () => {
this.props.blobServiceUpload({ if (processedMedia.mediaType !== 'encrypted_video') {
return undefined;
}
return await this.props.blobServiceUpload({
uploadInput: { uploadInput: {
blobInput: { blobInput: {
type: 'uri', type: 'uri',
uri: processedMedia.uploadThumbnailURI, uri: processedMedia.uploadThumbnailURI,
filename: replaceExtension(`thumb${filename}`, 'jpg'), filename: replaceExtension(`thumb${filename}`, 'jpg'),
mimeType: 'image/jpeg', mimeType: 'image/jpeg',
}, },
blobHash: processedMedia.thumbnailBlobHash, blobHash: processedMedia.thumbnailBlobHash,
encryptionKey: processedMedia.thumbnailEncryptionKey, encryptionKey: processedMedia.thumbnailEncryptionKey,
loop: false, loop: false,
dimensions: processedMedia.dimensions, dimensions: processedMedia.dimensions,
thumbHash: processedMedia.thumbHash, thumbHash: processedMedia.thumbHash,
}, },
keyserverOrThreadID: threadInfo.id, keyserverOrThreadID: threadInfo.id,
callbacks: { callbacks: {
blobServiceUploadHandler, blobServiceUploadHandler,
}, },
}), });
); })();
}
[uploadResult, uploadThumbnailResult] = await Promise.all( [uploadResult, uploadThumbnailResult] = await Promise.all([
uploadPromises, uploadPromise,
); uploadThumbnailPromise,
]);
} else { } else {
uploadPromises.push( const uploadPromise = this.props.uploadMultimedia(
this.props.uploadMultimedia(
{ uri: uploadURI, name: filename, type: mime }, { uri: uploadURI, name: filename, type: mime },
{ {
...processedMedia.dimensions, ...processedMedia.dimensions,
loop: loop:
processedMedia.mediaType === 'video' || processedMedia.mediaType === 'video' ||
processedMedia.mediaType === 'encrypted_video' processedMedia.mediaType === 'encrypted_video'
? processedMedia.loop ? processedMedia.loop
: undefined, : undefined,
encryptionKey: processedMedia.encryptionKey, encryptionKey: processedMedia.encryptionKey,
thumbHash: thumbHash:
processedMedia.mediaType === 'photo' || processedMedia.mediaType === 'photo' ||
processedMedia.mediaType === 'encrypted_photo' processedMedia.mediaType === 'encrypted_photo'
? processedMedia.thumbHash ? processedMedia.thumbHash
: null, : null,
}, },
{ {
onProgress: (percent: number) => onProgress: (percent: number) =>
this.setProgress( this.setProgress(
localMessageID, localMessageID,
localMediaID, localMediaID,
'uploading', 'uploading',
percent, percent,
), ),
uploadBlob: this.uploadBlob, uploadBlob: this.uploadBlob,
}, },
),
); );
const uploadThumbnailPromise: Promise<?UploadMultimediaResult> =
(async () => {
if ( if (
processedMedia.mediaType === 'video' || processedMedia.mediaType !== 'video' &&
processedMedia.mediaType === 'encrypted_video' processedMedia.mediaType !== 'encrypted_video'
) { ) {
uploadPromises.push( return undefined;
this.props.uploadMultimedia( }
return await this.props.uploadMultimedia(
{ {
uri: processedMedia.uploadThumbnailURI, uri: processedMedia.uploadThumbnailURI,
name: replaceExtension(`thumb${filename}`, 'jpg'), name: replaceExtension(`thumb${filename}`, 'jpg'),
type: 'image/jpeg', type: 'image/jpeg',
}, },
{ {
...processedMedia.dimensions, ...processedMedia.dimensions,
loop: false, loop: false,
encryptionKey: processedMedia.thumbnailEncryptionKey, encryptionKey: processedMedia.thumbnailEncryptionKey,
thumbHash: processedMedia.thumbHash, thumbHash: processedMedia.thumbHash,
}, },
{ {
uploadBlob: this.uploadBlob, uploadBlob: this.uploadBlob,
}, },
),
);
}
[uploadResult, uploadThumbnailResult] = await Promise.all(
uploadPromises,
); );
})();
[uploadResult, uploadThumbnailResult] = await Promise.all([
uploadPromise,
uploadThumbnailPromise,
]);
} }
mediaMissionResult = { success: true }; mediaMissionResult = { success: true };
} catch (e) { } catch (e) {
uploadExceptionMessage = getMessageForException(e); uploadExceptionMessage = getMessageForException(e);
onUploadFailed(localMediaID, 'upload failed'); onUploadFailed(localMediaID, 'upload failed');
mediaMissionResult = { mediaMissionResult = {
success: false, success: false,
reason: 'http_upload_failed', reason: 'http_upload_failed',
▲ Show 20 Lines • Show All 787 Lines • Show Last 20 Lines