Feed Advanced Search

Advanced Search
Use Results
Edit Query
Hide Query

Today

tomek accepted D10152: [web] catch error while processing store operations.

Mon, Dec 4, 8:04 AM

tomek retitled D10150: [keyserver] Introduce a function that allows fetching all the primary links from [keyserver] Fetch all the links when a viewer is a script viewer to [keyserver] Introduce a function that allows fetching all the primary links.

Mon, Dec 4, 6:47 AM

tomek updated the summary of D10150: [keyserver] Introduce a function that allows fetching all the primary links.

Mon, Dec 4, 6:47 AM

tomek updated the diff for D10150: [keyserver] Introduce a function that allows fetching all the primary links.

Split a function into two

Mon, Dec 4, 6:46 AM

tomek planned changes to D10150: [keyserver] Introduce a function that allows fetching all the primary links.

In D10150#295223, @ashoat wrote:

This feels pretty messy. I'm not sure what the callstack looks like, but is it possible to introduce a second function for this (with shared code factored out) instead of overloading fetchPrimaryInviteLinks to handle two different scenarios?

Mon, Dec 4, 6:33 AM

tomek requested review of D10150: [keyserver] Introduce a function that allows fetching all the primary links.

Mon, Dec 4, 4:56 AM

tomek accepted D10119: [web] Update existing checks on isDefault in role-actions-menu.reactjs.

Mon, Dec 4, 12:28 AM

tomek accepted D10118: [native] Update existing checks on isDefault in role-panel-entry.react.js.

Mon, Dec 4, 12:28 AM

tomek accepted D10117: [keyserver] Update existing checks on isDefault in invite-link-creator.js.

Mon, Dec 4, 12:27 AM

tomek accepted D10116: [lib] Update existing checks on isDefault in thread-utils.js.

Mon, Dec 4, 12:27 AM

tomek accepted D10109: [lib] Update thread-utils to include specialRole field.

Mon, Dec 4, 12:23 AM

Fri, Dec 1

tomek accepted D10108: [keyserver] Update role-creator to include specialRole field.

Fri, Dec 1, 7:55 AM

tomek accepted D10107: [keyserver] Update thread-fetchers to fetch special_role.

Fri, Dec 1, 7:54 AM

tomek accepted D10106: [keyserver] Update role-fetchers to fetch special_role.

Fri, Dec 1, 7:54 AM

tomek accepted D10105: [lib] Add optional speciaRole field to RoleInfo.

Fri, Dec 1, 7:52 AM

tomek accepted D10135: [blob] Add option to instantly delete a blob.

Fri, Dec 1, 7:35 AM

tomek requested review of D10134: [keyserver] Create a blob while adding / editing an invite link.

Fri, Dec 1, 7:22 AM

tomek requested review of D10131: [keyserver] Change blob upload functions to return more usable results.

Fri, Dec 1, 4:37 AM

Thu, Nov 30

tomek accepted D10097: [web] wrap store operations in transaction.

Thu, Nov 30, 8:09 AM

tomek requested review of D10099: [keyserver] Introduce a util function that generates invite link blob hash.

Thu, Nov 30, 8:02 AM

tomek requested review of D10098: [keyserver] Modify blob functions so that they take params object where both hash and holder are provided.

Thu, Nov 30, 7:28 AM

tomek updated the diff for D9972: [keyserver] Delete a holder after deleting a blob.

Rebase

Thu, Nov 30, 6:57 AM

tomek updated the diff for D9968: [keyserver] Fetch invite link blob holder.

Rebase

Thu, Nov 30, 6:54 AM

tomek updated the diff for D9966: [keyserver] Add a function that deletes a blob.

Use a param object instead of two args for hash and holder to avoid the confusion between them

Thu, Nov 30, 6:52 AM

tomek accepted D10095: [lib] `ThreadInfo` -> `LegacyThreadInfo`.

Accepting without review. What procedure did you use to rename all the types?

Thu, Nov 30, 1:23 AM

Wed, Nov 29

tomek accepted D10054: [native] Implement native backup.

Wed, Nov 29, 6:07 AM

tomek accepted D10091: [lib] Fix keyserver not present in keyserver store error.

Wed, Nov 29, 5:22 AM

tomek accepted D10069: [web] use default `updatesCurrentAsOf` in transform if value is missing.

on the first rehydration this value could be undefined

Is it also true for other values from the keyserverInfo? Should we also handle them somehow?

Wed, Nov 29, 12:43 AM

Mon, Nov 27

tomek accepted D9961: [keyserver/lib] Introduce a specialRoles enum and special_role column in MariaDB.

Mon, Nov 27, 8:25 AM

tomek accepted D10046: [Flow202][native] [62/x] Fill in types for all Platform.select invocations.

Mon, Nov 27, 7:27 AM

tomek accepted D10045: [Flow202][native][skip-ci] [61/x] Get rid of Platform.select in ratchetAlongWithKeyboardHeight.

Mon, Nov 27, 7:25 AM

tomek accepted D10042: [Flow202][native][skip-ci] [58/x] Destructure this.lastMessageSent before checking its value.

Mon, Nov 27, 7:24 AM

tomek accepted D10041: [Flow202][native][skip-ci] [57/x] Avoid looking up nullable type in non-nullable Set in ChatRouter.

Mon, Nov 27, 7:23 AM

tomek accepted D10040: [Flow202][native][skip-ci] [56/x] Use Flow's comment syntax in Reanimated worklets.

Mon, Nov 27, 7:22 AM

tomek accepted D10039: [Flow202][native][skip-ci] [55/x] Fix Flow issues by adding Promise types.

Mon, Nov 27, 7:21 AM

tomek accepted D10030: [Flow202][native][skip-ci] [46/x] Type itemToDummy using React.MixedElement.

Mon, Nov 27, 7:20 AM

tomek accepted D10022: [Flow202][native][skip-ci] [38/x] Fix exponential-spread issue in RootRouter.

Mon, Nov 27, 7:18 AM

tomek accepted D10021: [Flow202][native][skip-ci] [37/x] Allow removeEditMode to take a TabAction.

Mon, Nov 27, 7:13 AM

tomek accepted D10016: [Flow202][native][skip-ci] [32/x] Fix type errors in OverlayNavigator.

Mon, Nov 27, 7:12 AM

tomek accepted D10015: [Flow202][native][skip-ci] [31/x] Address missing-local-annot type errors.

Mon, Nov 27, 6:57 AM

tomek accepted D10007: [Flow202][native][skip-ci] [23/x] Import AnimatedInterpolation type from react-native.

Mon, Nov 27, 6:49 AM

tomek accepted D10004: [Flow202][native][skip-ci] [20/x] Update Reanimated libdef to match GestureHandler.

Mon, Nov 27, 6:47 AM

tomek accepted D10000: [Flow202][native][skip-ci] [16/x] Type React.forwardRef input functions.

Mon, Nov 27, 6:42 AM

tomek accepted D9954: [web] processing ThreadStore ops on worker.

Mon, Nov 27, 6:25 AM

tomek accepted D9956: [web] refactor validateState to operations.

Mon, Nov 27, 6:20 AM

tomek accepted D9999: [Flow202][native][skip-ci] [15/x] Move unboundStyles to the top.

Mon, Nov 27, 3:58 AM

tomek accepted D9997: [Flow202][native][skip-ci] [13/x] Enable NavigationHelpersContext to parameterize on invocation.

Mon, Nov 27, 3:55 AM

tomek accepted D9996: [Flow202][native][skip-ci] [12/x] Enable StackView to parameterize on invocation.

Mon, Nov 27, 3:52 AM

tomek accepted D9995: [Flow202][native][skip-ci] [11/x] Add type params to ReactNav createMaterialTopTabNavigator call.

Mon, Nov 27, 3:45 AM

tomek accepted D9994: [Flow202][native][skip-ci] [10/x] Add type params to ReactNav useNavigationBuilder calls.

Mon, Nov 27, 3:42 AM

tomek accepted D9993: [Flow202][native][skip-ci] [9/x] Type navigation prop on all ReactNav screens.

Mon, Nov 27, 3:41 AM

tomek accepted D9992: [Flow202][native][skip-ci] [8/x] Fix incorrect ReactNav types in navigators & screens.

Mon, Nov 27, 3:37 AM

tomek accepted D9990: [Flow202][native][skip-ci] [6/x] Remove Scene type from ReactNav libdefs.

Mon, Nov 27, 3:36 AM

tomek accepted D9989: [Flow202][native][skip-ci] [5/x] Fix parameterization of ReactNav getParent.

Mon, Nov 27, 3:35 AM

tomek accepted D9988: [Flow202][native][skip-ci] [4/x] Stop copy-pasting between ReactNav libdefs.

Mon, Nov 27, 3:33 AM

tomek accepted D9987: [Flow202][native][skip-ci] [3/x] Introduce @react-navigation/core libdef.

Mon, Nov 27, 3:29 AM

tomek accepted D9982: [keyserver] Drop the default_role column from threads.

Mon, Nov 27, 3:19 AM

tomek accepted D9981: [keyserver] Update usage of threads.default_role in thread-creator.js.

Is the default_role column nullable at this point?

Mon, Nov 27, 3:19 AM

tomek accepted D9980: [keyserver] Update usage of threads.default_role in thread-fetchers.js.

Mon, Nov 27, 3:12 AM

tomek accepted D9978: [keyserver] Update usage of threads.default_role in validate-role-permissions.js.

Mon, Nov 27, 3:12 AM

tomek accepted D9979: [keyserver] Update usage of threads.default_role in thread-permission-updaters.js.

Mon, Nov 27, 3:09 AM

tomek requested changes to D9978: [keyserver] Update usage of threads.default_role in validate-role-permissions.js.

Mon, Nov 27, 3:06 AM

tomek accepted D9977: [keyserver] Update usage of threads.default_role in thread-updaters.js.

Mon, Nov 27, 1:53 AM

tomek accepted D9975: [keyserver] Update usage of threads.default_role in role-deleters.js.

Mon, Nov 27, 12:56 AM

tomek accepted D9974: [keyserver/lib] Populate special_role field when initial roles are created.

Mon, Nov 27, 12:51 AM

tomek accepted D9961: [keyserver/lib] Introduce a specialRoles enum and special_role column in MariaDB.

Mon, Nov 27, 12:44 AM

tomek added inline comments to D9956: [web] refactor validateState to operations.

Mon, Nov 27, 12:10 AM

Fri, Nov 24

tomek requested review of D9972: [keyserver] Delete a holder after deleting a blob.

Fri, Nov 24, 9:35 AM

tomek requested review of D9968: [keyserver] Fetch invite link blob holder.

Fri, Nov 24, 8:43 AM

tomek requested review of D9966: [keyserver] Add a function that deletes a blob.

Fri, Nov 24, 7:08 AM

tomek closed D9960: [keyserver] Add a column to invite_links table with a blob holder.

Fri, Nov 24, 6:16 AM

tomek committed rCOMM8f30d381b83b: [keyserver] Add a column to invite_links table with a blob holder (authored by tomek).

[keyserver] Add a column to invite_links table with a blob holder

Fri, Nov 24, 6:16 AM

tomek updated the diff for D9944: [keyserver] Block creating invite links for which an entry in Blob service already exists.

Use better error code

Fri, Nov 24, 6:14 AM

tomek closed D9943: [keyserver] Check if a blob exists.

Fri, Nov 24, 4:51 AM

tomek closed D9942: [keyserver] Create a function that downloads blobs.

Fri, Nov 24, 4:51 AM

tomek committed rCOMM834594e5184c: [keyserver] Check if a blob exists (authored by tomek).

[keyserver] Check if a blob exists

Fri, Nov 24, 4:51 AM

tomek committed rCOMM174754d3184f: [keyserver] Create a function that downloads blobs (authored by tomek).

[keyserver] Create a function that downloads blobs

Fri, Nov 24, 4:51 AM

tomek closed D9941: [keyserver] Split uploading blob and assigning holders.

Fri, Nov 24, 4:51 AM

tomek closed D9940: [keyserver] Split blob encryption and upload into separate functions.

Fri, Nov 24, 4:51 AM

tomek committed rCOMM19bc53760b95: [keyserver] Split uploading blob and assigning holders (authored by tomek).

[keyserver] Split uploading blob and assigning holders

Fri, Nov 24, 4:51 AM

tomek committed rCOMM9213ad529af3: [keyserver] Split blob encryption and upload into separate functions (authored by tomek).

[keyserver] Split blob encryption and upload into separate functions

Fri, Nov 24, 4:51 AM

tomek closed D9937: [keyserver] Move blob upload code to a new place.

Fri, Nov 24, 4:51 AM

tomek committed rCOMMb8ffdb80b834: [keyserver] Move blob upload code to a new place (authored by tomek).

[keyserver] Move blob upload code to a new place

Fri, Nov 24, 4:51 AM

tomek updated the diff for D9960: [keyserver] Add a column to invite_links table with a blob holder.

Rebase

Fri, Nov 24, 4:09 AM

tomek updated the diff for D9940: [keyserver] Split blob encryption and upload into separate functions.

Rebase

Fri, Nov 24, 4:09 AM

tomek accepted D9965: [native] update baseNoDataAfterPolicyAcknowledgmentSelector check.

Fri, Nov 24, 3:59 AM

tomek accepted D9959: [web] start using threads from database.

Fri, Nov 24, 3:55 AM

tomek requested changes to D9956: [web] refactor validateState to operations.

Fri, Nov 24, 1:40 AM

tomek accepted D9955: [web] refactor processing store ops to separate function.

Fri, Nov 24, 1:18 AM

tomek accepted D9954: [web] processing ThreadStore ops on worker.

Fri, Nov 24, 1:17 AM

tomek accepted D9952: [SQLite] add ThreadStore Emscripten bindings and converters.

Fri, Nov 24, 1:10 AM

Thu, Nov 23

tomek requested review of D9960: [keyserver] Add a column to invite_links table with a blob holder.

Thu, Nov 23, 7:47 AM

tomek added inline comments to D9943: [keyserver] Check if a blob exists.

Thu, Nov 23, 3:55 AM

tomek updated the diff for D9940: [keyserver] Split blob encryption and upload into separate functions.

Move encrypting inside try-catch block

Thu, Nov 23, 3:23 AM

tomek added inline comments to D9940: [keyserver] Split blob encryption and upload into separate functions.

Thu, Nov 23, 3:18 AM

tomek added inline comments to D9952: [SQLite] add ThreadStore Emscripten bindings and converters.

Thu, Nov 23, 2:49 AM

tomek accepted D9951: [web/lib] move reading and populating data to state gate.

Thu, Nov 23, 2:21 AM

tomek accepted D9949: [web/keyserver] make InitialReduxStateResponder configurable.

Thu, Nov 23, 1:15 AM

tomek accepted D9948: [web] start persisting `updatesCurrentAsOf`.

Thu, Nov 23, 12:54 AM

Tue, Nov 21

tomek requested review of D9944: [keyserver] Block creating invite links for which an entry in Blob service already exists.

Tue, Nov 21, 8:45 AM