This implementation has a performance consequence - in the original implementation, we were only stringifying when an alert was shown. Now we're stringifying the object even for users who will never see an alert. We could consider keeping the JSON.stringify inside showAlertToStaff, but I'm not sure if it is really that important.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Today
Yesterday
Mon, Oct 28
Revert actions queue change
Finally
Readonly
Simplify the queueing code. This revision still has an issue where leaving a thread casues an exception while sending the notifs. Regardless, it is an improvement comparing to the master, because it fixes sending messages in quick succession. The notifs issue will be fixed in the next diff.
Thu, Oct 24
Wed, Oct 23
What is our thinking about this now?
Tue, Oct 22
Mon, Oct 21
In D13725#384293, @kamil wrote:According to this comment worth adding this to encryption related errors:
We'll discuss this async and add this to this diff or I can put up another one
Thu, Oct 17
Wed, Oct 16
Mon, Oct 14
Rebase
Delete unnecessary dependencies
Delete unnecessary dependencies
Avoid losing messages
Fri, Oct 11
MErge operation queues
Return mutable array
I wanted to pass the measure function itseft through conxtext, but that results in Cannot read property '_nativeTag' of undefined error.
My guess is that we need to bind these methods.
Thu, Oct 10
Why do we ignore all the promises? What is the downside of awaiting them?
Tue, Oct 8
Mon, Oct 7
Fri, Oct 4
Thu, Oct 3
To verify that this formatting is correct we could consider deleting ignore and worker directives, auto-formatting the code, and reintroducing the directives.