Split a function into two
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Today
Today
tomek retitled D10150: [keyserver] Introduce a function that allows fetching all the primary links from [keyserver] Fetch all the links when a viewer is a script viewer to [keyserver] Introduce a function that allows fetching all the primary links.
tomek updated the summary of D10150: [keyserver] Introduce a function that allows fetching all the primary links.
tomek updated the diff for D10150: [keyserver] Introduce a function that allows fetching all the primary links.
tomek planned changes to D10150: [keyserver] Introduce a function that allows fetching all the primary links.
In D10150#295223, @ashoat wrote:This feels pretty messy. I'm not sure what the callstack looks like, but is it possible to introduce a second function for this (with shared code factored out) instead of overloading fetchPrimaryInviteLinks to handle two different scenarios?
tomek requested review of D10150: [keyserver] Introduce a function that allows fetching all the primary links.
Fri, Dec 1
Fri, Dec 1
tomek requested review of D10131: [keyserver] Change blob upload functions to return more usable results.
Thu, Nov 30
Thu, Nov 30
tomek requested review of D10099: [keyserver] Introduce a util function that generates invite link blob hash.
Rebase
Rebase
Use a param object instead of two args for hash and holder to avoid the confusion between them
Accepting without review. What procedure did you use to rename all the types?
Wed, Nov 29
Wed, Nov 29
on the first rehydration this value could be undefined
Is it also true for other values from the keyserverInfo? Should we also handle them somehow?
Mon, Nov 27
Mon, Nov 27
Is the default_role column nullable at this point?
tomek requested changes to D9978: [keyserver] Update usage of threads.default_role in validate-role-permissions.js.
Fri, Nov 24
Fri, Nov 24
tomek committed rCOMM8f30d381b83b: [keyserver] Add a column to invite_links table with a blob holder (authored by tomek).
[keyserver] Add a column to invite_links table with a blob holder
tomek updated the diff for D9944: [keyserver] Block creating invite links for which an entry in Blob service already exists.
Use better error code
[keyserver] Check if a blob exists
tomek committed rCOMM174754d3184f: [keyserver] Create a function that downloads blobs (authored by tomek).
[keyserver] Create a function that downloads blobs
tomek committed rCOMM19bc53760b95: [keyserver] Split uploading blob and assigning holders (authored by tomek).
[keyserver] Split uploading blob and assigning holders
tomek committed rCOMM9213ad529af3: [keyserver] Split blob encryption and upload into separate functions (authored by tomek).
[keyserver] Split blob encryption and upload into separate functions
tomek committed rCOMMb8ffdb80b834: [keyserver] Move blob upload code to a new place (authored by tomek).
[keyserver] Move blob upload code to a new place
tomek updated the diff for D9960: [keyserver] Add a column to invite_links table with a blob holder.
Rebase
tomek updated the diff for D9940: [keyserver] Split blob encryption and upload into separate functions.
Rebase
Thu, Nov 23
Thu, Nov 23
tomek updated the diff for D9940: [keyserver] Split blob encryption and upload into separate functions.
Move encrypting inside try-catch block
tomek added inline comments to D9940: [keyserver] Split blob encryption and upload into separate functions.
Tue, Nov 21
Tue, Nov 21