Page MenuHomePhabricator

[native] Fix Timestamp position when focusing RobotextMessage with InlineEngagement
ClosedPublic

Authored by ashoat on Oct 9 2024, 8:28 PM.
Tags
None
Referenced Files
F5099286: D13681.diff
Mon, Mar 31, 6:22 AM
Unknown Object (File)
Sat, Mar 15, 3:17 AM
Unknown Object (File)
Feb 17 2025, 11:18 AM
Unknown Object (File)
Feb 17 2025, 11:18 AM
Unknown Object (File)
Feb 17 2025, 11:17 AM
Unknown Object (File)
Feb 17 2025, 11:17 AM
Unknown Object (File)
Jan 31 2025, 4:03 PM
Unknown Object (File)
Jan 31 2025, 4:03 PM
Subscribers
None

Details

Summary

We shouldn't include the InlineEngagement in the View that gets measured. By removing this, I fixed a visual glitch where the Timestamp for a robotext message would jump higher on the screen when the robotext was selected.

Depends on D13680

Test Plan
  1. I reacted to a robotext where the timestamp was already showing. Then I pressed it, and made sure there were no visual glitches or logs about incorrect height
  2. Same as above, except where the timestamp wasn't showing

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable