Page MenuHomePhabricator
Differential D13675

[lib][web] Narrow ChatMessageInfoItem to ComposableChatMessageInfoItem where appropriate
ClosedPublic
Actions

Authored by ashoat on Wed, Oct 9, 8:23 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Oct 28, 7:27 AM
Unknown Object (File)
Thu, Oct 24, 6:02 PM
Unknown Object (File)
Wed, Oct 23, 2:36 AM
Unknown Object (File)
Tue, Oct 22, 11:45 PM
Unknown Object (File)
Tue, Oct 22, 9:49 PM
Unknown Object (File)
Tue, Oct 22, 10:51 AM
Unknown Object (File)
Tue, Oct 22, 10:20 AM
Unknown Object (File)
Mon, Oct 21, 7:10 AM
View All 29 Files
Subscribers
None

Details

Reviewers
tomek
Commits
rCOMMcf32e540a169: [lib][web] Narrow ChatMessageInfoItem to ComposableChatMessageInfoItem where…
Summary

This will make a following diff a little easier.

Depends on D13674

Test Plan

Flow

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat created this revision.Wed, Oct 9, 8:23 PM
ashoat added a child revision: D13676: [native] Remove TooltipInlineEngagement from RobotextMessageTooltipButton.
Harbormaster completed remote builds in B32159: Diff 45034.Wed, Oct 9, 8:57 PM
ashoat requested review of this revision.Wed, Oct 9, 8:57 PM
tomek accepted this revision.Fri, Oct 11, 5:01 AM
tomek added inline comments.
lib/selectors/chat-selectors.js
286 ↗(On Diff #45034)

Is there a reason not to use composable as the name?

This revision is now accepted and ready to land.Fri, Oct 11, 5:01 AM
ashoat retitled this revision from [lib][web] Narrow ChatMessageInfoItem to ComposedChatMessageInfoItem where appropriate to [lib][web] Narrow ChatMessageInfoItem to ComposableChatMessageInfoItem where appropriate.Sun, Oct 13, 5:17 PM
ashoat updated this revision to Diff 45104.Sun, Oct 13, 5:20 PM

ComposedChatMessageInfoItem -> ComposableChatMessageInfoItem

Harbormaster completed remote builds in B32208: Diff 45104.Sun, Oct 13, 5:38 PM
Closed by commit rCOMMcf32e540a169: [lib][web] Narrow ChatMessageInfoItem to ComposableChatMessageInfoItem where… (authored by ashoat). · Explain WhySun, Oct 13, 6:43 PM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMMcf32e540a169: [lib][web] Narrow ChatMessageInfoItem to ComposableChatMessageInfoItem where….

Revision Contents
Changeset List

Diff 45116

View Options

lib/selectors/chat-selectors.js

Loading...
View Options

web/chat/composed-message.react.js

Loading...
View Options

web/chat/edit-message-provider.js

Loading...
View Options

web/chat/edit-text-message.react.js

Loading...
View Options

web/chat/failed-send.react.js

Loading...
View Options

web/chat/message.react.js

Loading...
View Options

web/chat/multimedia-message-send-failed.js

Loading...
View Options

web/chat/multimedia-message.react.js

Loading...
View Options

web/chat/text-message-send-failed.js

Loading...
View Options

web/chat/text-message.react.js

Loading...
View Options

web/tooltips/tooltip-action-utils.js

Loading...