[lib] Introduce MessageSpec.mergeIntoPrecedingRobotextMessageItem
ClosedPublic
Actions

Authored by ashoat on Oct 9 2024, 8:33 PM.

Details

Reviewers

tomek

Commits

rCOMMf0679dd4de0d: [lib] Introduce MessageSpec.mergeIntoPrecedingRobotextMessageItem

Summary

This function will allow us to merge RobotextMessageInfos into preceding (older) RobotextChatMessageInfoItems.

The merging is implemented on the spec of the newer RobotextChatMessageInfoItem.

Depends on D13686

Test Plan

Tested in combination with the following diffs, where I construct RobotextChatMessageInfoItem with an array of messageInfos to represent combined messages (ENG-9559

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Oct 9 2024, 8:33 PM

ashoat added a child revision: D13688: [lib] Explain auto-created Farcaster mutual friend threads better.

Harbormaster completed remote builds in B32171: Diff 45046.Oct 9 2024, 10:08 PM

ashoat requested review of this revision.Oct 9 2024, 10:08 PM

Don't merge messages that have reactions or a sidebar

lib/selectors/chat-selectors.js
521–522 ↗	(On Diff #45065)	These checks are superfluous, since only composable messages can be edited or pinned currently But I figured it wouldn't hurt to check