Page MenuHomePhabricator
Differential D13687

[lib] Introduce MessageSpec.mergeIntoPrecedingRobotextMessageItem
ClosedPublic
Actions

Authored by ashoat on Wed, Oct 9, 8:33 PM.
Tags
None
Referenced Files
F3102037: D13687.diff
Wed, Oct 30, 10:22 AM
F3100613: D13687.id45065.diff
Wed, Oct 30, 3:50 AM
F3100506: D13687.id45046.diff
Wed, Oct 30, 3:14 AM
Unknown Object (File)
Tue, Oct 29, 7:26 AM
Unknown Object (File)
Mon, Oct 28, 1:33 PM
Unknown Object (File)
Mon, Oct 28, 5:46 AM
Unknown Object (File)
Sun, Oct 27, 11:27 AM
Unknown Object (File)
Thu, Oct 24, 8:17 PM
View All 38 Files
Subscribers
None

Details

Reviewers
tomek
Commits
rCOMMf0679dd4de0d: [lib] Introduce MessageSpec.mergeIntoPrecedingRobotextMessageItem
Summary

This function will allow us to merge RobotextMessageInfos into preceding (older) RobotextChatMessageInfoItems.

The merging is implemented on the spec of the newer RobotextChatMessageInfoItem.

Depends on D13686

Test Plan

Tested in combination with the following diffs, where I construct RobotextChatMessageInfoItem with an array of messageInfos to represent combined messages (ENG-9559

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.Wed, Oct 9, 8:33 PM
ashoat added a child revision: D13688: [lib] Explain auto-created Farcaster mutual friend threads better.
Harbormaster completed remote builds in B32171: Diff 45046.Wed, Oct 9, 10:08 PM
ashoat requested review of this revision.Wed, Oct 9, 10:08 PM
ashoat updated this revision to Diff 45065.Thu, Oct 10, 11:01 AM

Don't merge messages that have reactions or a sidebar

lib/selectors/chat-selectors.js
521–522

These checks are superfluous, since only composable messages can be edited or pinned currently

But I figured it wouldn't hurt to check

Harbormaster completed remote builds in B32182: Diff 45065.Thu, Oct 10, 11:19 AM
tomek accepted this revision.Fri, Oct 11, 7:45 AM
This revision is now accepted and ready to land.Fri, Oct 11, 7:45 AM
ashoat mentioned this in D13686: [lib][native][web] Add support for rendering array of messages in RobotextChatMessageInfoItem.Sun, Oct 13, 5:07 PM
Closed by commit rCOMMf0679dd4de0d: [lib] Introduce MessageSpec.mergeIntoPrecedingRobotextMessageItem (authored by ashoat). · Explain WhySun, Oct 13, 6:44 PM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMMf0679dd4de0d: [lib] Introduce MessageSpec.mergeIntoPrecedingRobotextMessageItem.

Revision Contents
Changeset List

PathSize
lib/
selectors/
41 lines
shared/
messages/
10 lines

Diff 45065

View Options

lib/selectors/chat-selectors.js

Loading...
View Options

lib/shared/messages/message-spec.js

Loading...