Page MenuHomePhabricator

[lib] Introduce MessageSpec.mergeIntoPrecedingRobotextMessageItem
ClosedPublic

Authored by ashoat on Wed, Oct 9, 8:33 PM.
Tags
None
Referenced Files
F3102037: D13687.diff
Wed, Oct 30, 10:22 AM
F3100613: D13687.id45065.diff
Wed, Oct 30, 3:50 AM
F3100506: D13687.id45046.diff
Wed, Oct 30, 3:14 AM
Unknown Object (File)
Tue, Oct 29, 7:26 AM
Unknown Object (File)
Mon, Oct 28, 1:33 PM
Unknown Object (File)
Mon, Oct 28, 5:46 AM
Unknown Object (File)
Sun, Oct 27, 11:27 AM
Unknown Object (File)
Thu, Oct 24, 8:17 PM
Subscribers
None

Details

Summary

This function will allow us to merge RobotextMessageInfos into preceding (older) RobotextChatMessageInfoItems.

The merging is implemented on the spec of the newer RobotextChatMessageInfoItem.

Depends on D13686

Test Plan

Tested in combination with the following diffs, where I construct RobotextChatMessageInfoItem with an array of messageInfos to represent combined messages (ENG-9559

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

Don't merge messages that have reactions or a sidebar

lib/selectors/chat-selectors.js
521–522

These checks are superfluous, since only composable messages can be edited or pinned currently

But I figured it wouldn't hurt to check

This revision is now accepted and ready to land.Fri, Oct 11, 7:45 AM