Page MenuHomePhabricator
Differential D13687

[lib] Introduce MessageSpec.mergeIntoPrecedingRobotextMessageItem
ClosedPublic
Actions

Authored by ashoat on Oct 9 2024, 8:33 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 7, 6:37 AM
Unknown Object (File)
Sun, Apr 6, 8:31 AM
Unknown Object (File)
Sat, Mar 15, 3:17 AM
Unknown Object (File)
Feb 17 2025, 10:51 AM
Unknown Object (File)
Feb 17 2025, 10:50 AM
Unknown Object (File)
Feb 17 2025, 10:50 AM
Unknown Object (File)
Jan 29 2025, 1:31 PM
Unknown Object (File)
Jan 28 2025, 7:45 PM
View All 84 Files
Subscribers
None

Details

Reviewers
tomek
Commits
rCOMMf0679dd4de0d: [lib] Introduce MessageSpec.mergeIntoPrecedingRobotextMessageItem
Summary

This function will allow us to merge RobotextMessageInfos into preceding (older) RobotextChatMessageInfoItems.

The merging is implemented on the spec of the newer RobotextChatMessageInfoItem.

Depends on D13686

Test Plan

Tested in combination with the following diffs, where I construct RobotextChatMessageInfoItem with an array of messageInfos to represent combined messages (ENG-9559

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.Oct 9 2024, 8:33 PM
ashoat added a child revision: D13688: [lib] Explain auto-created Farcaster mutual friend threads better.
Harbormaster completed remote builds in B32171: Diff 45046.Oct 9 2024, 10:08 PM
ashoat requested review of this revision.Oct 9 2024, 10:08 PM
ashoat updated this revision to Diff 45065.Oct 10 2024, 11:01 AM

Don't merge messages that have reactions or a sidebar

lib/selectors/chat-selectors.js
521–522

These checks are superfluous, since only composable messages can be edited or pinned currently

But I figured it wouldn't hurt to check

Harbormaster completed remote builds in B32182: Diff 45065.Oct 10 2024, 11:19 AM
tomek accepted this revision.Oct 11 2024, 7:45 AM
This revision is now accepted and ready to land.Oct 11 2024, 7:45 AM
ashoat mentioned this in D13686: [lib][native][web] Add support for rendering array of messages in RobotextChatMessageInfoItem.Oct 13 2024, 5:07 PM
Closed by commit rCOMMf0679dd4de0d: [lib] Introduce MessageSpec.mergeIntoPrecedingRobotextMessageItem (authored by ashoat). · Explain WhyOct 13 2024, 6:44 PM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMMf0679dd4de0d: [lib] Introduce MessageSpec.mergeIntoPrecedingRobotextMessageItem.

Revision Contents
Changeset List

PathSize
lib/
selectors/
41 lines
shared/
messages/
10 lines

Diff 45065

View Options

lib/selectors/chat-selectors.js

Show All 34 Lines
import { AlchemyENSCacheProvider, wagmiConfig } from 'lib/utils/wagmi-utils.js'; import { AlchemyENSCacheProvider, wagmiConfig } from 'lib/utils/wagmi-utils.js';
import QrCodeLogin from './account/qr-code-login.react.js'; import QrCodeLogin from './account/qr-code-login.react.js';
import AppThemeWrapper from './app-theme-wrapper.react.js'; import AppThemeWrapper from './app-theme-wrapper.react.js';
import WebEditThreadAvatarProvider from './avatars/web-edit-thread-avatar-provider.react.js'; import WebEditThreadAvatarProvider from './avatars/web-edit-thread-avatar-provider.react.js';
import Calendar from './calendar/calendar.react.js'; import Calendar from './calendar/calendar.react.js';
import Chat from './chat/chat.react.js'; import Chat from './chat/chat.react.js';
import { EditModalProvider } from './chat/edit-message-provider.js'; import { EditModalProvider } from './chat/edit-message-provider.js';
import { TooltipProvider } from './chat/tooltip-provider.js';
import NavigationArrows from './components/navigation-arrows.react.js'; import NavigationArrows from './components/navigation-arrows.react.js';
import { initOpaque } from './crypto/opaque-utils.js'; import { initOpaque } from './crypto/opaque-utils.js';
import electron from './electron.js'; import electron from './electron.js';
import InputStateContainer from './input/input-state-container.react.js'; import InputStateContainer from './input/input-state-container.react.js';
import InviteLinkHandler from './invite-links/invite-link-handler.react.js'; import InviteLinkHandler from './invite-links/invite-link-handler.react.js';
import InviteLinksRefresher from './invite-links/invite-links-refresher.react.js'; import InviteLinksRefresher from './invite-links/invite-links-refresher.react.js';
import LoadingIndicator from './loading-indicator.react.js'; import LoadingIndicator from './loading-indicator.react.js';
import { MenuProvider } from './menu-provider.react.js'; import { MenuProvider } from './menu-provider.react.js';
Show All 15 Lines
import { createTunnelbrokerInitMessage } from './selectors/tunnelbroker-selectors.js'; import { createTunnelbrokerInitMessage } from './selectors/tunnelbroker-selectors.js';
import AccountSettings from './settings/account-settings.react.js'; import AccountSettings from './settings/account-settings.react.js';
import DangerZone from './settings/danger-zone.react.js'; import DangerZone from './settings/danger-zone.react.js';
import KeyserverSelectionList from './settings/keyserver-selection-list.react.js'; import KeyserverSelectionList from './settings/keyserver-selection-list.react.js';
import CommunityPicker from './sidebar/community-picker.react.js'; import CommunityPicker from './sidebar/community-picker.react.js';
import Splash from './splash/splash.react.js'; import Splash from './splash/splash.react.js';
import './typography.css'; import './typography.css';
import css from './style.css'; import css from './style.css';
import { TooltipProvider } from './tooltips/tooltip-provider.js';
import { type NavInfo } from './types/nav-types.js'; import { type NavInfo } from './types/nav-types.js';
import { canonicalURLFromReduxState, navInfoFromURL } from './url-utils.js'; import { canonicalURLFromReduxState, navInfoFromURL } from './url-utils.js';
void initOpaque(); void initOpaque();
// We want Webpack's css-loader and style-loader to handle the Fontawesome CSS, // We want Webpack's css-loader and style-loader to handle the Fontawesome CSS,
// so we disable the autoAddCss logic and import the CSS file. Otherwise every // so we disable the autoAddCss logic and import the CSS file. Otherwise every
// icon flashes huge for a second before the CSS is loaded. // icon flashes huge for a second before the CSS is loaded.
▲ Show 20 Lines • Show All 325 Lines • Show Last 20 Lines
View Options

lib/shared/messages/message-spec.js

Show All 34 Lines
import { AlchemyENSCacheProvider, wagmiConfig } from 'lib/utils/wagmi-utils.js'; import { AlchemyENSCacheProvider, wagmiConfig } from 'lib/utils/wagmi-utils.js';
import QrCodeLogin from './account/qr-code-login.react.js'; import QrCodeLogin from './account/qr-code-login.react.js';
import AppThemeWrapper from './app-theme-wrapper.react.js'; import AppThemeWrapper from './app-theme-wrapper.react.js';
import WebEditThreadAvatarProvider from './avatars/web-edit-thread-avatar-provider.react.js'; import WebEditThreadAvatarProvider from './avatars/web-edit-thread-avatar-provider.react.js';
import Calendar from './calendar/calendar.react.js'; import Calendar from './calendar/calendar.react.js';
import Chat from './chat/chat.react.js'; import Chat from './chat/chat.react.js';
import { EditModalProvider } from './chat/edit-message-provider.js'; import { EditModalProvider } from './chat/edit-message-provider.js';
import { TooltipProvider } from './chat/tooltip-provider.js';
import NavigationArrows from './components/navigation-arrows.react.js'; import NavigationArrows from './components/navigation-arrows.react.js';
import { initOpaque } from './crypto/opaque-utils.js'; import { initOpaque } from './crypto/opaque-utils.js';
import electron from './electron.js'; import electron from './electron.js';
import InputStateContainer from './input/input-state-container.react.js'; import InputStateContainer from './input/input-state-container.react.js';
import InviteLinkHandler from './invite-links/invite-link-handler.react.js'; import InviteLinkHandler from './invite-links/invite-link-handler.react.js';
import InviteLinksRefresher from './invite-links/invite-links-refresher.react.js'; import InviteLinksRefresher from './invite-links/invite-links-refresher.react.js';
import LoadingIndicator from './loading-indicator.react.js'; import LoadingIndicator from './loading-indicator.react.js';
import { MenuProvider } from './menu-provider.react.js'; import { MenuProvider } from './menu-provider.react.js';
Show All 15 Lines
import { createTunnelbrokerInitMessage } from './selectors/tunnelbroker-selectors.js'; import { createTunnelbrokerInitMessage } from './selectors/tunnelbroker-selectors.js';
import AccountSettings from './settings/account-settings.react.js'; import AccountSettings from './settings/account-settings.react.js';
import DangerZone from './settings/danger-zone.react.js'; import DangerZone from './settings/danger-zone.react.js';
import KeyserverSelectionList from './settings/keyserver-selection-list.react.js'; import KeyserverSelectionList from './settings/keyserver-selection-list.react.js';
import CommunityPicker from './sidebar/community-picker.react.js'; import CommunityPicker from './sidebar/community-picker.react.js';
import Splash from './splash/splash.react.js'; import Splash from './splash/splash.react.js';
import './typography.css'; import './typography.css';
import css from './style.css'; import css from './style.css';
import { TooltipProvider } from './tooltips/tooltip-provider.js';
import { type NavInfo } from './types/nav-types.js'; import { type NavInfo } from './types/nav-types.js';
import { canonicalURLFromReduxState, navInfoFromURL } from './url-utils.js'; import { canonicalURLFromReduxState, navInfoFromURL } from './url-utils.js';
void initOpaque(); void initOpaque();
// We want Webpack's css-loader and style-loader to handle the Fontawesome CSS, // We want Webpack's css-loader and style-loader to handle the Fontawesome CSS,
// so we disable the autoAddCss logic and import the CSS file. Otherwise every // so we disable the autoAddCss logic and import the CSS file. Otherwise every
// icon flashes huge for a second before the CSS is loaded. // icon flashes huge for a second before the CSS is loaded.
▲ Show 20 Lines • Show All 325 Lines • Show Last 20 Lines