HomePhabricator
Diffusion Comm 9dd69d49de44

[keyserver] Handle null browser detection result

Description

[keyserver] Handle null browser detection result

Summary:
When a browser can't be detected we need to make sure that we don't crash. Handling this case in the same way as if it was a web browser probably makes the most sense.

https://linear.app/comm/issue/ENG-9477/typeerror-cannot-read-properties-of-null-reading-os-on-landing

Depends on D13587

Test Plan: Replaced detectionResult with null and checked that we're handling it as if it was a web browser.

Reviewers: kamil, inka

Reviewed By: kamil

Subscribers: ashoat

Differential Revision: https://phab.comm.dev/D13588

Details

Provenance
tomekAuthored on Oct 3 2024, 4:07 AM
Reviewer
kamil
Differential Revision
D13588: [keyserver] Handle null browser detection result
Parents
rCOMMbbd8bdc414bf: [lib] Bump detect-browser version
Branches
Unknown
Tags
Unknown