Page MenuHomePhabricator

[lib] Bump detect-browser version
ClosedPublic

Authored by tomek on Oct 3 2024, 3:58 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 18, 9:06 AM
Unknown Object (File)
Wed, Dec 18, 9:06 AM
Unknown Object (File)
Wed, Dec 18, 9:06 AM
Unknown Object (File)
Wed, Dec 18, 9:06 AM
Unknown Object (File)
Fri, Nov 29, 11:22 AM
Unknown Object (File)
Fri, Nov 22, 11:18 AM
Unknown Object (File)
Nov 10 2024, 12:39 PM
Unknown Object (File)
Nov 10 2024, 1:07 AM
Subscribers

Details

Summary

We're using an old version that has more limited browsers support. According to the release notes https://github.com/DamonOehlman/detect-browser/releases/tag/v5.0.0 the major version was increased because of a breaking change that removed support for one browser.

https://linear.app/comm/issue/ENG-9477/typeerror-cannot-read-properties-of-null-reading-os-on-landing

Test Plan

Tested on iOS that the correct version is detected in the responder.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable