Page MenuHomePhabricator

[lib] Bump detect-browser version
ClosedPublic

Authored by tomek on Oct 3 2024, 3:58 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 10, 12:39 PM
Unknown Object (File)
Sun, Nov 10, 1:07 AM
Unknown Object (File)
Fri, Nov 8, 10:37 PM
Unknown Object (File)
Fri, Nov 8, 1:48 PM
Unknown Object (File)
Thu, Oct 24, 10:34 AM
Unknown Object (File)
Thu, Oct 24, 10:23 AM
Unknown Object (File)
Thu, Oct 24, 8:30 AM
Unknown Object (File)
Thu, Oct 24, 3:09 AM
Subscribers

Details

Summary

We're using an old version that has more limited browsers support. According to the release notes https://github.com/DamonOehlman/detect-browser/releases/tag/v5.0.0 the major version was increased because of a breaking change that removed support for one browser.

https://linear.app/comm/issue/ENG-9477/typeerror-cannot-read-properties-of-null-reading-os-on-landing

Test Plan

Tested on iOS that the correct version is detected in the responder.

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage