[keyserver] Handle null browser detection result
ClosedPublic
Actions

Authored by tomek on Thu, Oct 3, 4:08 AM.

Details

Reviewers

kamil
inka

Commits

rCOMM9dd69d49de44: [keyserver] Handle null browser detection result

Summary

When a browser can't be detected we need to make sure that we don't crash. Handling this case in the same way as if it was a web browser probably makes the most sense.

https://linear.app/comm/issue/ENG-9477/typeerror-cannot-read-properties-of-null-reading-os-on-landing

Depends on D13587

Test Plan

Replaced detectionResult with null and checked that we're handling it as if it was a web browser.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.Thu, Oct 3, 4:08 AM

Herald added a subscriber: ashoat. · View Herald TranscriptThu, Oct 3, 4:08 AM

Harbormaster completed remote builds in B32039: Diff 44863.Thu, Oct 3, 4:25 AM

tomek requested review of this revision.Thu, Oct 3, 4:25 AM

kamil accepted this revision.Thu, Oct 3, 6:10 AM

This revision is now accepted and ready to land.Thu, Oct 3, 6:10 AM

Closed by commit rCOMM9dd69d49de44: [keyserver] Handle null browser detection result (authored by tomek). · Explain WhyThu, Oct 3, 7:16 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMM9dd69d49de44: [keyserver] Handle null browser detection result.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

responders/

website-responders.js

4 lines

Diff 44866

View Options

keyserver/src/responders/website-responders.js

[keyserver] Handle null browser detection resultClosedPublicActions