Page MenuHomePhabricator
Differential D13588

[keyserver] Handle null browser detection result
ClosedPublic
Actions

Authored by tomek on Oct 3 2024, 4:08 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 19, 2:40 AM
Unknown Object (File)
Sun, Nov 17, 2:50 AM
Unknown Object (File)
Sun, Nov 10, 1:53 PM
Unknown Object (File)
Sun, Nov 10, 1:07 AM
Unknown Object (File)
Fri, Nov 8, 10:37 PM
Unknown Object (File)
Fri, Nov 8, 1:48 PM
Unknown Object (File)
Fri, Nov 1, 2:26 AM
Unknown Object (File)
Thu, Oct 31, 3:54 AM
View All 33 Files
Subscribers
ashoat

Details

Reviewers
kamil
inka
Commits
rCOMM9dd69d49de44: [keyserver] Handle null browser detection result
Summary

When a browser can't be detected we need to make sure that we don't crash. Handling this case in the same way as if it was a web browser probably makes the most sense.

https://linear.app/comm/issue/ENG-9477/typeerror-cannot-read-properties-of-null-reading-os-on-landing

Depends on D13587

Test Plan

Replaced detectionResult with null and checked that we're handling it as if it was a web browser.

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
keyserver/
src/
responders/
4 lines

Diff 44863

View Options

keyserver/src/responders/website-responders.js

Loading...