Page MenuHomePhabricator
Differential D13662

[lib] extract code responsible for confirming P2P message to a hook
ClosedPublic
Actions

Authored by kamil on Oct 9 2024, 7:33 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 31, 10:59 PM
Unknown Object (File)
Sun, Mar 30, 12:42 PM
Unknown Object (File)
Fri, Mar 28, 10:24 PM
Unknown Object (File)
Fri, Mar 28, 2:01 AM
Unknown Object (File)
Mon, Mar 10, 4:16 AM
Unknown Object (File)
Mar 3 2025, 6:18 AM
Unknown Object (File)
Feb 18 2025, 1:40 AM
Unknown Object (File)
Feb 18 2025, 1:39 AM
View All 73 Files
Subscribers
ashoat

Details

Reviewers
tomek
Commits
rCOMM0ea97c431b17: [lib] extract code responsible for confirming P2P message to a hook
Summary

Part of ENG-9456.

I need to reuse this code in next diff.

Test Plan

Tested in next diff

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Oct 9 2024, 7:33 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptOct 9 2024, 7:33 AM
kamil added a child revision: D13663: [lib] send confirmation for ignored DM ops.Oct 9 2024, 7:41 AM
kamil published this revision for review.Oct 9 2024, 7:51 AM
Harbormaster completed remote builds in B32144: Diff 45016.Oct 9 2024, 7:52 AM
tomek accepted this revision.Oct 10 2024, 5:28 AM
tomek added inline comments.
lib/handlers/db-ops-handler.react.js
46 ↗(On Diff #45016)

Shouldn't we await to keep it consistent with the previous implementation?

This revision is now accepted and ready to land.Oct 10 2024, 5:28 AM
kamil updated this revision to Diff 45139.Oct 14 2024, 3:28 AM

add await

Harbormaster completed remote builds in B32222: Diff 45139.Oct 14 2024, 3:46 AM
Closed by commit rCOMM0ea97c431b17: [lib] extract code responsible for confirming P2P message to a hook (authored by kamil). · Explain WhyOct 14 2024, 4:07 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM0ea97c431b17: [lib] extract code responsible for confirming P2P message to a hook.

Revision Contents
Changeset List

PathSize
lib/
handlers/
39 lines
tunnelbroker/
57 lines

Diff 45145

View Options

lib/handlers/db-ops-handler.react.js

Show First 20 Lines • Show All 72 Lines • ▼ Show 20 Linesimport type {
MessageStorePrunePayload, MessageStorePrunePayload,
LocallyComposedMessageInfo, LocallyComposedMessageInfo,
SimpleMessagesPayload, SimpleMessagesPayload,
FetchPinnedMessagesResult, FetchPinnedMessagesResult,
SearchMessagesResponse, SearchMessagesResponse,
} from './message-types.js'; } from './message-types.js';
import type { RawReactionMessageInfo } from './messages/reaction.js'; import type { RawReactionMessageInfo } from './messages/reaction.js';
import type { RawTextMessageInfo } from './messages/text.js'; import type { RawTextMessageInfo } from './messages/text.js';
import type { BaseNavInfo } from './nav-types.js'; import type { BaseNavInfo, WebNavInfo } from './nav-types.js';
import { import {
type ForcePolicyAcknowledgmentPayload, type ForcePolicyAcknowledgmentPayload,
type PolicyAcknowledgmentPayload, type PolicyAcknowledgmentPayload,
type UserPolicies, type UserPolicies,
} from './policy-types.js'; } from './policy-types.js';
import type { RelationshipErrors } from './relationship-types.js'; import type { RelationshipErrors } from './relationship-types.js';
import type { import type {
EnabledReports, EnabledReports,
Show All 24 Lines
import type { ThreadActivityStore } from './thread-activity-types.js'; import type { ThreadActivityStore } from './thread-activity-types.js';
import type { import type {
ThreadStore, ThreadStore,
ChangeThreadSettingsPayload, ChangeThreadSettingsPayload,
LeaveThreadPayload, LeaveThreadPayload,
NewThreadResult, NewThreadResult,
ThreadJoinPayload, ThreadJoinPayload,
ToggleMessagePinResult, ToggleMessagePinResult,
LegacyThreadStore,
RoleModificationPayload, RoleModificationPayload,
RoleDeletionPayload, RoleDeletionPayload,
} from './thread-types.js'; } from './thread-types.js';
import type { ClientUpdatesResultWithUserInfos } from './update-types.js'; import type { ClientUpdatesResultWithUserInfos } from './update-types.js';
import type { CurrentUserInfo, UserStore } from './user-types.js'; import type { CurrentUserInfo, UserInfos, UserStore } from './user-types.js';
import type { SetDeviceTokenActionPayload } from '../actions/device-actions.js'; import type { SetDeviceTokenActionPayload } from '../actions/device-actions.js';
import type { NotifPermissionAlertInfo } from '../utils/push-alerts.js'; import type { NotifPermissionAlertInfo } from '../utils/push-alerts.js';
export type BaseAppState<NavInfo: BaseNavInfo = BaseNavInfo> = { export type BaseAppState<NavInfo: BaseNavInfo = BaseNavInfo> = {
+navInfo: NavInfo, +navInfo: NavInfo,
+currentUserInfo: ?CurrentUserInfo, +currentUserInfo: ?CurrentUserInfo,
+draftStore: DraftStore, +draftStore: DraftStore,
+entryStore: EntryStore, +entryStore: EntryStore,
Show All 24 Lines
export type NativeAppState = BaseAppState<>; export type NativeAppState = BaseAppState<>;
export type WebAppState = BaseAppState<> & { export type WebAppState = BaseAppState<> & {
+cryptoStore: ?CryptoStore, +cryptoStore: ?CryptoStore,
+pushApiPublicKey: ?string, +pushApiPublicKey: ?string,
... ...
}; };
export type AppState = NativeAppState | WebAppState; export type AppState = NativeAppState | WebAppState;
export type WebInitialReduxStateResponse = {
+navInfo: WebNavInfo,
+currentUserInfo: CurrentUserInfo,
+entryStore: EntryStore,
+threadStore: LegacyThreadStore,
+userInfos: UserInfos,
+messageStore: MessageStore,
+pushApiPublicKey: ?string,
+commServicesAccessToken: null,
+inviteLinksStore: InviteLinksStore,
+keyserverInfo: WebInitialKeyserverInfo,
};
export type WebInitialKeyserverInfo = {
+sessionID: ?string,
+updatesCurrentAsOf: number,
};
export type BaseAction = export type BaseAction =
| { | {
+type: '@@redux/INIT', +type: '@@redux/INIT',
+payload?: void, +payload?: void,
} }
| { | {
+type: 'FETCH_ENTRIES_STARTED', +type: 'FETCH_ENTRIES_STARTED',
+payload?: void, +payload?: void,
▲ Show 20 Lines • Show All 1,154 Lines • Show Last 20 Lines
View Options

lib/tunnelbroker/use-confirm-peer-to-peer-message.js

Show First 20 Lines • Show All 72 Lines • ▼ Show 20 Linesimport type {
MessageStorePrunePayload, MessageStorePrunePayload,
LocallyComposedMessageInfo, LocallyComposedMessageInfo,
SimpleMessagesPayload, SimpleMessagesPayload,
FetchPinnedMessagesResult, FetchPinnedMessagesResult,
SearchMessagesResponse, SearchMessagesResponse,
} from './message-types.js'; } from './message-types.js';
import type { RawReactionMessageInfo } from './messages/reaction.js'; import type { RawReactionMessageInfo } from './messages/reaction.js';
import type { RawTextMessageInfo } from './messages/text.js'; import type { RawTextMessageInfo } from './messages/text.js';
import type { BaseNavInfo } from './nav-types.js'; import type { BaseNavInfo, WebNavInfo } from './nav-types.js';
import { import {
type ForcePolicyAcknowledgmentPayload, type ForcePolicyAcknowledgmentPayload,
type PolicyAcknowledgmentPayload, type PolicyAcknowledgmentPayload,
type UserPolicies, type UserPolicies,
} from './policy-types.js'; } from './policy-types.js';
import type { RelationshipErrors } from './relationship-types.js'; import type { RelationshipErrors } from './relationship-types.js';
import type { import type {
EnabledReports, EnabledReports,
Show All 24 Lines
import type { ThreadActivityStore } from './thread-activity-types.js'; import type { ThreadActivityStore } from './thread-activity-types.js';
import type { import type {
ThreadStore, ThreadStore,
ChangeThreadSettingsPayload, ChangeThreadSettingsPayload,
LeaveThreadPayload, LeaveThreadPayload,
NewThreadResult, NewThreadResult,
ThreadJoinPayload, ThreadJoinPayload,
ToggleMessagePinResult, ToggleMessagePinResult,
LegacyThreadStore,
RoleModificationPayload, RoleModificationPayload,
RoleDeletionPayload, RoleDeletionPayload,
} from './thread-types.js'; } from './thread-types.js';
import type { ClientUpdatesResultWithUserInfos } from './update-types.js'; import type { ClientUpdatesResultWithUserInfos } from './update-types.js';
import type { CurrentUserInfo, UserStore } from './user-types.js'; import type { CurrentUserInfo, UserInfos, UserStore } from './user-types.js';
import type { SetDeviceTokenActionPayload } from '../actions/device-actions.js'; import type { SetDeviceTokenActionPayload } from '../actions/device-actions.js';
import type { NotifPermissionAlertInfo } from '../utils/push-alerts.js'; import type { NotifPermissionAlertInfo } from '../utils/push-alerts.js';
export type BaseAppState<NavInfo: BaseNavInfo = BaseNavInfo> = { export type BaseAppState<NavInfo: BaseNavInfo = BaseNavInfo> = {
+navInfo: NavInfo, +navInfo: NavInfo,
+currentUserInfo: ?CurrentUserInfo, +currentUserInfo: ?CurrentUserInfo,
+draftStore: DraftStore, +draftStore: DraftStore,
+entryStore: EntryStore, +entryStore: EntryStore,
Show All 24 Lines
export type NativeAppState = BaseAppState<>; export type NativeAppState = BaseAppState<>;
export type WebAppState = BaseAppState<> & { export type WebAppState = BaseAppState<> & {
+cryptoStore: ?CryptoStore, +cryptoStore: ?CryptoStore,
+pushApiPublicKey: ?string, +pushApiPublicKey: ?string,
... ...
}; };
export type AppState = NativeAppState | WebAppState; export type AppState = NativeAppState | WebAppState;
export type WebInitialReduxStateResponse = {
+navInfo: WebNavInfo,
+currentUserInfo: CurrentUserInfo,
+entryStore: EntryStore,
+threadStore: LegacyThreadStore,
+userInfos: UserInfos,
+messageStore: MessageStore,
+pushApiPublicKey: ?string,
+commServicesAccessToken: null,
+inviteLinksStore: InviteLinksStore,
+keyserverInfo: WebInitialKeyserverInfo,
};
export type WebInitialKeyserverInfo = {
+sessionID: ?string,
+updatesCurrentAsOf: number,
};
export type BaseAction = export type BaseAction =
| { | {
+type: '@@redux/INIT', +type: '@@redux/INIT',
+payload?: void, +payload?: void,
} }
| { | {
+type: 'FETCH_ENTRIES_STARTED', +type: 'FETCH_ENTRIES_STARTED',
+payload?: void, +payload?: void,
▲ Show 20 Lines • Show All 1,154 Lines • Show Last 20 Lines