Page MenuHomePhabricator
Differential D13662

[lib] extract code responsible for confirming P2P message to a hook
ClosedPublic
Actions

Authored by kamil on Oct 9 2024, 7:33 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 20, 5:52 AM
Unknown Object (File)
Mon, Mar 31, 10:59 PM
Unknown Object (File)
Sun, Mar 30, 12:42 PM
Unknown Object (File)
Fri, Mar 28, 10:24 PM
Unknown Object (File)
Fri, Mar 28, 2:01 AM
Unknown Object (File)
Mar 10 2025, 4:16 AM
Unknown Object (File)
Mar 3 2025, 6:18 AM
Unknown Object (File)
Feb 18 2025, 1:40 AM
View All 74 Files
Subscribers
ashoat

Details

Reviewers
tomek
Commits
rCOMM0ea97c431b17: [lib] extract code responsible for confirming P2P message to a hook
Summary

Part of ENG-9456.

I need to reuse this code in next diff.

Test Plan

Tested in next diff

Diff Detail

Repository
rCOMM Comm
Branch
fix-count
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Oct 9 2024, 7:33 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptOct 9 2024, 7:33 AM
kamil added a child revision: D13663: [lib] send confirmation for ignored DM ops.Oct 9 2024, 7:41 AM
kamil published this revision for review.Oct 9 2024, 7:51 AM
Harbormaster completed remote builds in B32144: Diff 45016.Oct 9 2024, 7:52 AM
tomek accepted this revision.Oct 10 2024, 5:28 AM
tomek added inline comments.
lib/handlers/db-ops-handler.react.js
46

Shouldn't we await to keep it consistent with the previous implementation?

This revision is now accepted and ready to land.Oct 10 2024, 5:28 AM
kamil updated this revision to Diff 45139.Oct 14 2024, 3:28 AM

add await

Harbormaster completed remote builds in B32222: Diff 45139.Oct 14 2024, 3:46 AM
Closed by commit rCOMM0ea97c431b17: [lib] extract code responsible for confirming P2P message to a hook (authored by kamil). · Explain WhyOct 14 2024, 4:07 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM0ea97c431b17: [lib] extract code responsible for confirming P2P message to a hook.

Revision Contents
Changeset List

PathSize
lib/
handlers/
39 lines
tunnelbroker/
57 lines

Diff 45016

View Options

lib/handlers/db-ops-handler.react.js

  • This file was deleted.
This file was completely deleted. Show File Contents
View Options

lib/tunnelbroker/use-confirm-peer-to-peer-message.js

  • This file was deleted.
This file was completely deleted. Show File Contents