Paths

Table of Contentst

Differential D13731

[keyserver] Also delete from ids table when deleting invite links
ClosedPublic
Actions

Authored by ashoat on Wed, Oct 16, 12:42 PM.

Tags

None

Referenced Files

	F2994972: D13731.id45231.diff
	Thu, Oct 17, 8:31 AM

	F2994482: D13731.id45231.diff
	Thu, Oct 17, 8:11 AM

	F2994199: D13731.id.diff
	Thu, Oct 17, 7:18 AM

	F2992966: D13731.id.diff
	Thu, Oct 17, 5:53 AM

	F2992846: D13731.id45233.diff
	Thu, Oct 17, 5:34 AM

	F2992840: D13731.id45235.diff
	Thu, Oct 17, 5:30 AM

	F2992520: D13731.id45235.diff
	Thu, Oct 17, 3:54 AM

	F2992218: D13731.id45233.diff
	Thu, Oct 17, 3:14 AM

View All 9 Files

Subscribers

None

Details

Reviewers

Commits

rCOMM434d919a439c: [keyserver] Also delete from ids table when deleting invite links

Summary

Noticed this query wasn't deleting from the ids table. Turns out that the RETURNING keyword isn't allowed for multi-table deletes, so I had to rework the logic.

Test Plan

I deleted an invite link from the UI and confirmed it was removed from MariaDB and DynamoDB
I tested in combination with the next diff, where I introduce a cronjob for deleting orphaned invite links

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Wed, Oct 16, 12:42 PM

ashoat added a child revision: D13732: [keyserver] Add cron to delete orphaned invite links.Wed, Oct 16, 12:44 PM

Harbormaster completed remote builds in B32274: Diff 45231.Wed, Oct 16, 1:00 PM

ashoat requested review of this revision.Wed, Oct 16, 1:00 PM

Format

Harbormaster failed remote builds in B32276: Diff 45233!Wed, Oct 16, 1:56 PM

Harbormaster completed remote builds in B32276: Diff 45233.Wed, Oct 16, 2:44 PM

Don't do anything if links array is empty

Harbormaster completed remote builds in B32278: Diff 45235.Wed, Oct 16, 9:01 PM

tomek accepted this revision.Thu, Oct 17, 1:48 AM

This revision is now accepted and ready to land.Thu, Oct 17, 1:48 AM

Closed by commit rCOMM434d919a439c: [keyserver] Also delete from ids table when deleting invite links (authored by ashoat). · Explain WhyThu, Oct 17, 6:57 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM434d919a439c: [keyserver] Also delete from ids table when deleting invite links.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

deleters/

link-deleters.js

55 lines

Diff 45258

keyserver/src/deleters/link-deleters.js

Loading...