Page MenuHomePhabricator
Differential D12153

[native] Persist only lastUserInteractionCalendar from the entry store
AcceptedPublic
Actions

Authored by tomek on Tue, May 21, 8:27 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jun 13, 12:36 PM
Unknown Object (File)
Tue, Jun 11, 2:45 PM
Unknown Object (File)
Sat, Jun 8, 11:43 AM
Unknown Object (File)
Fri, Jun 7, 6:46 PM
Unknown Object (File)
Fri, Jun 7, 5:24 AM
Unknown Object (File)
Fri, Jun 7, 5:23 AM
Unknown Object (File)
Thu, Jun 6, 10:57 PM
Unknown Object (File)
Wed, Jun 5, 11:43 PM
View All 21 Files
Subscribers
ashoat

Details

Reviewers
kamil
marcin
Summary

We keep this field in redux-persist. EntryInfos are stored in SQLite, and daysToEntries are computed based on the entries.

Depends on D12169

https://linear.app/comm/issue/ENG-3486/move-entrystore-to-sqlite

Note: this diff should be landed when we are sure that the migration to SQLite was successful

Test Plan

TODO

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

tomek created this revision.Tue, May 21, 8:27 AM
Herald added a subscriber: ashoat. · View Herald TranscriptTue, May 21, 8:27 AM
tomek added a child revision: D12156: [lib] Update delete keyserver, delete thread, leave thread and set new session actions with the ops approach.Tue, May 21, 8:49 AM
tomek removed a child revision: D12156: [lib] Update delete keyserver, delete thread, leave thread and set new session actions with the ops approach.Tue, May 21, 8:56 AM
tomek edited parent revisions, added: D12157: [native] Add a migration that moves entries to SQLite; removed: D12152: [lib] Schedule entry store ops processing.
tomek added a child revision: D12156: [lib] Update delete keyserver, delete thread, leave thread and set new session actions with the ops approach.Tue, May 21, 8:59 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Tue, May 21, 9:11 AM
Harbormaster failed remote builds in B29116: Diff 40483!
tomek edited the summary of this revision. (Show Details)Tue, May 21, 12:42 PM
tomek updated this revision to Diff 40509.Tue, May 21, 12:43 PM

Rebase

Harbormaster completed remote builds in B29141: Diff 40509.Tue, May 21, 1:02 PM
tomek requested review of this revision.Tue, May 21, 1:02 PM
marcin mentioned this in D12147: [lib] Handle setClientDBStoreActionType for entries.Wed, May 22, 2:48 AM
marcin accepted this revision.Wed, May 22, 3:01 AM

Accepting but for now we have to hold this diff.

This revision is now accepted and ready to land.Wed, May 22, 3:01 AM
tomek removed a child revision: D12156: [lib] Update delete keyserver, delete thread, leave thread and set new session actions with the ops approach.Wed, May 22, 3:48 AM
tomek edited parent revisions, added: D12164: [lib] Migrate remaining actions; removed: D12157: [native] Add a migration that moves entries to SQLite.
tomek edited the summary of this revision. (Show Details)
tomek edited the summary of this revision. (Show Details)Wed, May 22, 4:34 AM
tomek added a parent revision: D12169: [web] Replace persisted entries with the ones from initial redux state.
tomek removed a parent revision: D12164: [lib] Migrate remaining actions.
tomek edited the summary of this revision. (Show Details)
tomek added a child revision: D12170: [web][keyserver] Use entries from the initial state only if they are missing from the store.Wed, May 22, 4:41 AM

Revision Contents
Changeset List

PathSize
native/
redux/
15 lines

Diff 40509

View Options

native/redux/persist.js

Loading...