Page MenuHomePhabricator
Differential D12169

[web] Replace persisted entries with the ones from initial redux state
ClosedPublic
Actions

Authored by tomek on Wed, May 22, 4:34 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jun 14, 11:19 PM
Unknown Object (File)
Thu, Jun 13, 11:18 PM
Unknown Object (File)
Thu, Jun 13, 6:46 PM
Unknown Object (File)
Tue, Jun 11, 8:58 PM
Unknown Object (File)
Mon, Jun 10, 7:14 AM
Unknown Object (File)
Sun, Jun 9, 10:45 PM
Unknown Object (File)
Thu, Jun 6, 2:03 PM
Unknown Object (File)
Thu, Jun 6, 12:49 PM
View All 26 Files
Subscribers
ashoat
inka

Details

Reviewers
kamil
marcin
Commits
rCOMM70681d12e108: [web] Replace persisted entries with the ones from initial redux state
Summary

After we conclude that the migration was successful, we will replace this code with the one that replaces the entries only when they are missing from the store.

Depends on D12164

https://linear.app/comm/issue/ENG-3486/move-entrystore-to-sqlite

Test Plan

Run console.log(entryStoreOperations) from tis code.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tomek created this revision.Wed, May 22, 4:34 AM
Herald added a subscriber: ashoat. · View Herald TranscriptWed, May 22, 4:34 AM
tomek added a child revision: D12153: [native] Persist only lastUserInteractionCalendar from the entry store.Wed, May 22, 4:34 AM
Harbormaster completed remote builds in B29154: Diff 40525.Wed, May 22, 4:50 AM
tomek requested review of this revision.Wed, May 22, 4:50 AM
marcin accepted this revision.Wed, May 22, 7:14 AM
This revision is now accepted and ready to land.Wed, May 22, 7:14 AM
inka added a subscriber: inka.Fri, May 24, 9:01 AM
inka added inline comments.
web/redux/initial-state-gate.js
160–162 ↗(On Diff #40525)

We should probably also check if entryStoreOperations.length > 0

marcin edited the test plan for this revision. (Show Details)Fri, May 24, 9:14 AM
ashoat added inline comments.Sat, May 25, 7:21 AM
web/redux/initial-state-gate.js
160–162 ↗(On Diff #40525)

Good catch – we definitely need to check that here

tomek updated this revision to Diff 40657.Mon, May 27, 4:28 AM
tomek marked 2 inline comments as done.

Check if there are some entry store ops

Harbormaster completed remote builds in B29251: Diff 40657.Mon, May 27, 4:44 AM
Closed by commit rCOMM70681d12e108: [web] Replace persisted entries with the ones from initial redux state (authored by tomek). · Explain WhyMon, May 27, 5:51 AM
This revision was automatically updated to reflect the committed changes.
tomek added a commit: rCOMM70681d12e108: [web] Replace persisted entries with the ones from initial redux state.

Revision Contents
Changeset List

PathSize
web/
redux/
13 lines

Diff 40669

View Options

web/redux/initial-state-gate.js

Loading...