Page MenuHomePhabricator
Differential D12170

[web][keyserver] Use entries from the initial state only if they are missing from the store
AcceptedPublic
Actions

Authored by tomek on Wed, May 22, 4:41 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jun 12, 5:49 AM
Unknown Object (File)
Fri, Jun 7, 5:23 AM
Unknown Object (File)
Fri, Jun 7, 5:23 AM
Unknown Object (File)
Thu, Jun 6, 5:57 PM
Unknown Object (File)
Thu, Jun 6, 2:13 PM
Unknown Object (File)
Thu, Jun 6, 2:02 PM
Unknown Object (File)
Wed, Jun 5, 12:31 AM
Unknown Object (File)
Tue, Jun 4, 12:02 AM
View All 18 Files
Subscribers
ashoat

Details

Reviewers
kamil
marcin
Summary

This is the last step of the migration - we should no longer use the values returned from the initial Redux state.

Depends on D12153

https://linear.app/comm/issue/ENG-3486/move-entrystore-to-sqlite

Test Plan

Closed and opened the app (both native and web) - the entries aren't sent from the keyserver so doing this verified if they are correctly persisted and rehydrated.

Diff Detail

Repository
rCOMM Comm
Branch
entries
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

tomek created this revision.Wed, May 22, 4:41 AM
Herald added a subscriber: ashoat. · View Herald TranscriptWed, May 22, 4:41 AM
Harbormaster completed remote builds in B29155: Diff 40526.Wed, May 22, 4:58 AM
tomek requested review of this revision.Wed, May 22, 4:58 AM
tomek updated this revision to Diff 40527.Wed, May 22, 4:58 AM

Use entries from the DB

tomek edited the test plan for this revision. (Show Details)Wed, May 22, 5:01 AM
Harbormaster completed remote builds in B29156: Diff 40527.Wed, May 22, 5:13 AM
tomek added a child revision: D12177: [lib] Stop checking for entry store inconsistencies.Wed, May 22, 5:55 AM
marcin accepted this revision.Wed, May 22, 7:17 AM
This revision is now accepted and ready to land.Wed, May 22, 7:17 AM
marcin edited the test plan for this revision. (Show Details)Wed, May 22, 7:17 AM
tomek added inline comments.Mon, May 27, 5:15 AM
keyserver/src/responders/redux-state-responders.js
223

We still should return this because we don't persist it on web

ashoat added inline comments.Tue, May 28, 12:04 PM
keyserver/src/responders/redux-state-responders.js
223

If it's always 0, is it something we can just insert automatically on the web side?

tomek added inline comments.Wed, May 29, 1:49 AM
keyserver/src/responders/redux-state-responders.js
223

Yes, that makes sense!

Revision Contents
Changeset List

PathSize
keyserver/
src/
responders/
13 lines
lib/
reducers/
2 lines
web/
redux/
20 lines
types/
2 lines

Diff 40527

View Options

keyserver/src/responders/redux-state-responders.js

Loading...
View Options

lib/reducers/entry-reducer.js

Loading...
View Options

web/redux/initial-state-gate.js

Loading...
View Options

web/types/redux-types.js

Loading...