[lib] Migrate creating local entries, concurrent modification and delete entries actions to ops
ClosedPublic
Actions

Authored by tomek on May 21 2024, 12:51 PM.

Details

Reviewers

kamil
marcin

Commits

Summary

Migrate the actions

Depends on D12162

Test Plan

To test createLocalEntryActionType: create entry and ensuring that it appears in the DB immediately and has local id.
To test createEntryActionTypes.success: create entry and wait after it transitions from local id to id in the db.
To test concurrentModificationResetActionType: Hack. override save function of native/entry.react to dispatch this actions with hardcoded string. Ensure that no matter what you type the result after saving is always hardcoded string.
To test deleteEntryActionTypes: delete entry and check in SQLite that deleted property is marked as true and entry is not visible across app restarts.

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

tomek requested review of this revision.May 21 2024, 1:17 PM

marcin requested changes to this revision.May 22 2024, 3:14 AM

marcin added inline comments.

lib/reducers/entry-reducer.js
339 ↗	(On Diff #40512)	Creating local entry tested - works correctly.
360 ↗	(On Diff #40512)	This one is buggy - you don't delete local entry first and what we see is two entries after a couple of seconds.
460 ↗	(On Diff #40512)	Deleting tested - works correctly.

This revision now requires changes to proceed.May 22 2024, 3:14 AM

Delete local entry after successful creation

lib/reducers/entry-reducer.js
339 ↗	(On Diff #40523)	Tested works. Creating entry results in immediate row in the db.
360 ↗	(On Diff #40523)	Tested works. Tested by creating entry and waiting after it transitions from local id to id in the db.

lib/reducers/entry-reducer.js
438 ↗	(On Diff #40523)	Tested works. I had to hack my way around this by overriding `save` function of `native/entry.react` to dispatch this actions with hardcoded string. No matter what I was typing the result after saving was always hardcoded string.