Returning an array isn't convenient anymore because we're introducing a new return value - the operations.
Depends on D12148
https://linear.app/comm/issue/ENG-3486/move-entrystore-to-sqlite
Details
Details
Summary
Test Plan
Tried creating, editing and deleting an entry. Flow.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Herald added a subscriber: ashoat. · View Herald TranscriptMay 21 2024, 6:47 AM2024-05-21 06:47:31 (UTC-7)
Harbormaster completed remote builds in B29096: Diff 40460.May 21 2024, 7:03 AM2024-05-21 07:03:18 (UTC-7)
tomek edited parent revisions, added: D12148: Connect pipes between C++ and JS for entry store; removed: D12141: [lib] Create entry store handler.May 21 2024, 7:52 AM2024-05-21 07:52:04 (UTC-7)
tomek removed a parent revision: D12141: [lib] Create entry store handler.May 21 2024, 12:38 PM2024-05-21 12:38:16 (UTC-7)
Harbormaster completed remote builds in B29132: Diff 40500.May 21 2024, 12:52 PM2024-05-21 12:52:09 (UTC-7)
This revision is now accepted and ready to land.May 22 2024, 2:41 AM2024-05-22 02:41:56 (UTC-7)
tomek edited the test plan for this revision. (Show Details)May 22 2024, 3:54 AM2024-05-22 03:54:01 (UTC-7)
Closed by commit rCOMMa22ddae034ab: [lib] Refactor the entries reducer to return an object (authored by tomek). · Explain WhyMon, May 27, 5:50 AM2024-05-27 05:50:48 (UTC-7)
This revision was automatically updated to reflect the committed changes.