Differential D12137

[lib] Create entry store operations
ClosedPublic
Actions

Authored by tomek on May 21 2024, 1:54 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Jun 20, 5:29 PM

	Unknown Object (File)
	Thu, Jun 20, 5:29 PM

	Unknown Object (File)
	Thu, Jun 20, 5:29 PM

	Unknown Object (File)
	Thu, Jun 20, 5:29 PM

	Unknown Object (File)
	Thu, Jun 20, 5:26 PM

	Unknown Object (File)
	Thu, Jun 20, 4:56 PM

	Unknown Object (File)
	Thu, Jun 20, 8:51 AM

	Unknown Object (File)
	Wed, Jun 12, 10:44 PM

View All 37 Files

Subscribers

Details

Reviewers

kamil
marcin

Commits

rCOMM1db8124d0443: [lib] Create entry store operations

Summary

Create all the operation types - similar to the other stores.

https://linear.app/comm/issue/ENG-3486/move-entrystore-to-sqlite

Test Plan

Flow

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.May 21 2024, 1:54 AM

Herald added a subscriber: ashoat. · View Herald TranscriptMay 21 2024, 1:54 AM

Fix the type

Harbormaster completed remote builds in B29083: Diff 40445.May 21 2024, 2:09 AM

Fix types

Harbormaster completed remote builds in B29084: Diff 40447.May 21 2024, 2:22 AM

Harbormaster completed remote builds in B29085: Diff 40448.May 21 2024, 2:26 AM

tomek requested review of this revision.May 21 2024, 2:26 AM

It would be convenient if you could create a function that converts EntryInfo (of RawEntryInfo) into ClientDBEntryInfo - it will help me write tests for first C++ diff.

This revision is now accepted and ready to land.May 21 2024, 2:36 AM

marcin added a child revision: D12138: Implement SQLite API to handle entry store.May 21 2024, 3:25 AM

tomek added a child revision: D12141: [lib] Create entry store handler.May 21 2024, 6:13 AM

Closed by commit rCOMM1db8124d0443: [lib] Create entry store operations (authored by tomek). · Explain WhyMay 21 2024, 6:55 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMM1db8124d0443: [lib] Create entry store operations.

tomek removed a child revision: D12138: Implement SQLite API to handle entry store.May 21 2024, 7:53 AM

Revision Contents
Changeset List

Path

Size

lib/

ops/

entries-store-ops.js

40 lines

Diff 40465

lib/ops/entries-store-ops.js

Loading...