[lib] Create entry store operations
ClosedPublic
Actions

Authored by tomek on May 21 2024, 1:54 AM.

Details

Reviewers

kamil
marcin

Commits

rCOMM1db8124d0443: [lib] Create entry store operations

Summary

Create all the operation types - similar to the other stores.

https://linear.app/comm/issue/ENG-3486/move-entrystore-to-sqlite

Test Plan

Flow

Diff Detail

Repository

rCOMM Comm

Branch

entries

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

tomek created this revision.May 21 2024, 1:54 AM

Herald added a subscriber: ashoat. · View Herald TranscriptMay 21 2024, 1:54 AM

Fix the type

Harbormaster completed remote builds in B29083: Diff 40445.May 21 2024, 2:09 AM

Fix types

Harbormaster completed remote builds in B29084: Diff 40447.May 21 2024, 2:22 AM

Harbormaster completed remote builds in B29085: Diff 40448.May 21 2024, 2:26 AM

tomek requested review of this revision.May 21 2024, 2:26 AM

It would be convenient if you could create a function that converts EntryInfo (of RawEntryInfo) into ClientDBEntryInfo - it will help me write tests for first C++ diff.

This revision is now accepted and ready to land.May 21 2024, 2:36 AM

marcin added a child revision: D12138: Implement SQLite API to handle entry store.May 21 2024, 3:25 AM

tomek added a child revision: D12141: [lib] Create entry store handler.May 21 2024, 6:13 AM

Closed by commit rCOMM1db8124d0443: [lib] Create entry store operations (authored by tomek). · Explain WhyMay 21 2024, 6:55 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMM1db8124d0443: [lib] Create entry store operations.

tomek removed a child revision: D12138: Implement SQLite API to handle entry store.May 21 2024, 7:53 AM

Revision Contents
Changeset List

Path

Size

lib/

ops/

entries-store-ops.js

40 lines

Diff 40448

View Options

lib/ops/entries-store-ops.js

Show All 19 Lines	import {
View,		View,
} from 'react-native';		} from 'react-native';

import type { UpdateCalendarQueryInput } from 'lib/actions/entry-actions.js';		import type { UpdateCalendarQueryInput } from 'lib/actions/entry-actions.js';
import {		import {
updateCalendarQueryActionTypes,		updateCalendarQueryActionTypes,
useUpdateCalendarQuery,		useUpdateCalendarQuery,
} from 'lib/actions/entry-actions.js';		} from 'lib/actions/entry-actions.js';
import { connectionSelector } from 'lib/selectors/keyserver-selectors.js';
import { createLoadingStatusSelector } from 'lib/selectors/loading-selectors.js';		import { createLoadingStatusSelector } from 'lib/selectors/loading-selectors.js';
import { entryKey } from 'lib/shared/entry-utils.js';		import { entryKey } from 'lib/shared/entry-utils.js';
import type {		import type {
CalendarQuery,		CalendarQuery,
CalendarQueryUpdateResult,		CalendarQueryUpdateResult,
EntryInfo,		EntryInfo,
} from 'lib/types/entry-types.js';		} from 'lib/types/entry-types.js';
import type { CalendarFilter } from 'lib/types/filter-types.js';		import type { CalendarFilter } from 'lib/types/filter-types.js';
import type { LoadingStatus } from 'lib/types/loading-types.js';		import type { LoadingStatus } from 'lib/types/loading-types.js';
import type { ThreadInfo } from 'lib/types/minimally-encoded-thread-permissions-types.js';		import type { ThreadInfo } from 'lib/types/minimally-encoded-thread-permissions-types.js';
import type { ConnectionStatus } from 'lib/types/socket-types.js';
import {		import {
dateFromString,		dateFromString,
dateString,		dateString,
prettyDate,		prettyDate,
} from 'lib/utils/date-utils.js';		} from 'lib/utils/date-utils.js';
import {		import {
type DispatchActionPromise,		type DispatchActionPromise,
useDispatchActionPromise,		useDispatchActionPromise,
} from 'lib/utils/redux-promise-utils.js';		} from 'lib/utils/redux-promise-utils.js';
import sleep from 'lib/utils/sleep.js';		import sleep from 'lib/utils/sleep.js';

import CalendarInputBar from './calendar-input-bar.react.js';		import CalendarInputBar from './calendar-input-bar.react.js';
import {		import {
dummyNodeForEntryHeightMeasurement,		dummyNodeForEntryHeightMeasurement,
Entry,		Entry,
InternalEntry,		InternalEntry,
} from './entry.react.js';		} from './entry.react.js';
import SectionFooter from './section-footer.react.js';		import SectionFooter from './section-footer.react.js';
import { authoritativeKeyserverID } from '../authoritative-keyserver.js';
import ContentLoading from '../components/content-loading.react.js';		import ContentLoading from '../components/content-loading.react.js';
import KeyboardAvoidingView from '../components/keyboard-avoiding-view.react.js';		import KeyboardAvoidingView from '../components/keyboard-avoiding-view.react.js';
import ListLoadingIndicator from '../components/list-loading-indicator.react.js';		import ListLoadingIndicator from '../components/list-loading-indicator.react.js';
import NodeHeightMeasurer from '../components/node-height-measurer.react.js';		import NodeHeightMeasurer from '../components/node-height-measurer.react.js';
import {		import {
addKeyboardDismissListener,		addKeyboardDismissListener,
addKeyboardShowListener,		addKeyboardShowListener,
removeKeyboardListener,		removeKeyboardListener,
▲ Show 20 Lines • Show All 100 Lines • ▼ Show 20 Lines	type Props = {
+calendarActive: boolean,		+calendarActive: boolean,
// Redux state		// Redux state
+listData: ?$ReadOnlyArray<CalendarItem>,		+listData: ?$ReadOnlyArray<CalendarItem>,
+startDate: string,		+startDate: string,
+endDate: string,		+endDate: string,
+calendarFilters: $ReadOnlyArray<CalendarFilter>,		+calendarFilters: $ReadOnlyArray<CalendarFilter>,
+dimensions: DerivedDimensionsInfo,		+dimensions: DerivedDimensionsInfo,
+loadingStatus: LoadingStatus,		+loadingStatus: LoadingStatus,
+connectionStatus: ConnectionStatus,		+connected: boolean,
+colors: Colors,		+colors: Colors,
+styles: $ReadOnly<typeof unboundStyles>,		+styles: $ReadOnly<typeof unboundStyles>,
+indicatorStyle: IndicatorStyle,		+indicatorStyle: IndicatorStyle,
// Redux dispatch functions		// Redux dispatch functions
+dispatchActionPromise: DispatchActionPromise,		+dispatchActionPromise: DispatchActionPromise,
// async functions that hit server APIs		// async functions that hit server APIs
+updateCalendarQuery: (		+updateCalendarQuery: (
input: UpdateCalendarQueryInput,		input: UpdateCalendarQueryInput,
▲ Show 20 Lines • Show All 115 Lines • ▼ Show 20 Lines	if (!this.props.listData && this.props.listData !== prevProps.listData) {
readyToShowList: false,		readyToShowList: false,
extraData: this.latestExtraData,		extraData: this.latestExtraData,
});		});
this.firstScrollComplete = false;		this.firstScrollComplete = false;
this.topLoaderWaitingToLeaveView = true;		this.topLoaderWaitingToLeaveView = true;
this.bottomLoaderWaitingToLeaveView = true;		this.bottomLoaderWaitingToLeaveView = true;
}		}

const { loadingStatus, connectionStatus } = this.props;		const { loadingStatus, connected } = this.props;
const {		const { loadingStatus: prevLoadingStatus, connected: prevConnected } =
loadingStatus: prevLoadingStatus,		prevProps;
connectionStatus: prevConnectionStatus,
} = prevProps;
if (		if (
(loadingStatus === 'error' && prevLoadingStatus === 'loading') \|\|		(loadingStatus === 'error' && prevLoadingStatus === 'loading') \|\|
(connectionStatus === 'connected' && prevConnectionStatus !== 'connected')		(connected && !prevConnected)
) {		) {
this.loadMoreAbove();		this.loadMoreAbove();
this.loadMoreBelow();		this.loadMoreBelow();
}		}

const lastLDWH = prevState.listDataWithHeights;		const lastLDWH = prevState.listDataWithHeights;
const newLDWH = this.state.listDataWithHeights;		const newLDWH = this.state.listDataWithHeights;
if (!newLDWH) {		if (!newLDWH) {
▲ Show 20 Lines • Show All 682 Lines • ▼ Show 20 Lines	void this.props.dispatchActionPromise(
this.props.updateCalendarQuery({ calendarQuery }),		this.props.updateCalendarQuery({ calendarQuery }),
);		);
}		}

loadMoreAbove: () => void = _throttle(() => {		loadMoreAbove: () => void = _throttle(() => {
if (		if (
this.topLoadingFromScroll &&		this.topLoadingFromScroll &&
this.topLoaderWaitingToLeaveView &&		this.topLoaderWaitingToLeaveView &&
this.props.connectionStatus === 'connected'		this.props.connected
) {		) {
this.dispatchCalendarQueryUpdate(this.topLoadingFromScroll);		this.dispatchCalendarQueryUpdate(this.topLoadingFromScroll);
}		}
}, 1000);		}, 1000);

loadMoreBelow: () => void = _throttle(() => {		loadMoreBelow: () => void = _throttle(() => {
if (		if (
this.bottomLoadingFromScroll &&		this.bottomLoadingFromScroll &&
this.bottomLoaderWaitingToLeaveView &&		this.bottomLoaderWaitingToLeaveView &&
this.props.connectionStatus === 'connected'		this.props.connected
) {		) {
this.dispatchCalendarQueryUpdate(this.bottomLoadingFromScroll);		this.dispatchCalendarQueryUpdate(this.bottomLoadingFromScroll);
}		}
}, 1000);		}, 1000);

onScroll = (event: ScrollEvent) => {		onScroll = (event: ScrollEvent) => {
this.currentScrollPosition = event.nativeEvent.contentOffset.y;		this.currentScrollPosition = event.nativeEvent.contentOffset.y;
};		};
▲ Show 20 Lines • Show All 44 Lines • ▼ Show 20 Lines	const calendarActive =
activeTabSelector(navContext) \|\| activeThreadPickerSelector(navContext);		activeTabSelector(navContext) \|\| activeThreadPickerSelector(navContext);

const listData = useSelector(calendarListData);		const listData = useSelector(calendarListData);
const startDate = useSelector(state => state.navInfo.startDate);		const startDate = useSelector(state => state.navInfo.startDate);
const endDate = useSelector(state => state.navInfo.endDate);		const endDate = useSelector(state => state.navInfo.endDate);
const calendarFilters = useSelector(state => state.calendarFilters);		const calendarFilters = useSelector(state => state.calendarFilters);
const dimensions = useSelector(derivedDimensionsInfoSelector);		const dimensions = useSelector(derivedDimensionsInfoSelector);
const loadingStatus = useSelector(loadingStatusSelector);		const loadingStatus = useSelector(loadingStatusSelector);
const connection = useSelector(		const connected = useSelector(state => state.connectivity.connected);
connectionSelector(authoritativeKeyserverID),
);
invariant(connection, 'keyserver missing from keyserverStore');
const connectionStatus = connection.status;
const colors = useColors();		const colors = useColors();
const styles = useStyles(unboundStyles);		const styles = useStyles(unboundStyles);
const indicatorStyle = useIndicatorStyle();		const indicatorStyle = useIndicatorStyle();

const dispatchActionPromise = useDispatchActionPromise();		const dispatchActionPromise = useDispatchActionPromise();
const callUpdateCalendarQuery = useUpdateCalendarQuery();		const callUpdateCalendarQuery = useUpdateCalendarQuery();

return (		return (
<Calendar		<Calendar
{...props}		{...props}
calendarActive={calendarActive}		calendarActive={calendarActive}
listData={listData}		listData={listData}
startDate={startDate}		startDate={startDate}
endDate={endDate}		endDate={endDate}
calendarFilters={calendarFilters}		calendarFilters={calendarFilters}
dimensions={dimensions}		dimensions={dimensions}
loadingStatus={loadingStatus}		loadingStatus={loadingStatus}
connectionStatus={connectionStatus}		connected={connected}
colors={colors}		colors={colors}
styles={styles}		styles={styles}
indicatorStyle={indicatorStyle}		indicatorStyle={indicatorStyle}
dispatchActionPromise={dispatchActionPromise}		dispatchActionPromise={dispatchActionPromise}
updateCalendarQuery={callUpdateCalendarQuery}		updateCalendarQuery={callUpdateCalendarQuery}
/>		/>
);		);
},		},
);		);

export default ConnectedCalendar;		export default ConnectedCalendar;

[lib] Create entry store operationsClosedPublicActions