Page MenuHomePhabricator
Differential D12148

Connect pipes between C++ and JS for entry store
ClosedPublic
Actions

Authored by marcin on May 21 2024, 7:42 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 1, 5:47 PM
Unknown Object (File)
Sun, Mar 30, 1:35 AM
Unknown Object (File)
Sat, Mar 29, 5:05 AM
Unknown Object (File)
Tue, Mar 18, 6:25 AM
Unknown Object (File)
Thu, Mar 13, 5:44 PM
Unknown Object (File)
Fri, Mar 7, 5:04 AM
Unknown Object (File)
Mar 5 2025, 11:55 PM
Unknown Object (File)
Mar 5 2025, 8:18 AM
View All Files
Subscribers
ashoat

Details

Reviewers
tomek
kamil
Commits
rCOMMb51b09fb1359: Connect pipes between C++ and JS for entry store
Summary

This differential enables fetching data from SQLite to redux and reducers to create ops for entry store

Test Plan

flow

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

marcin created this revision.May 21 2024, 7:42 AM
Herald added a subscriber: ashoat. · View Herald TranscriptMay 21 2024, 7:42 AM
marcin added a parent revision: D12142: Implement JSI for EntryStore.May 21 2024, 7:43 AM
tomek added a child revision: D12143: [lib] Refactor the entries reducer to return an object.May 21 2024, 7:52 AM
Harbormaster returned this revision to the author for changes because remote builds failed.May 21 2024, 8:15 AM
Harbormaster failed remote builds in B29106: Diff 40472!
marcin updated this revision to Diff 40498.May 21 2024, 12:09 PM

Fix CI

Harbormaster completed remote builds in B29130: Diff 40498.May 21 2024, 12:26 PM
marcin requested review of this revision.May 21 2024, 12:26 PM
tomek accepted this revision.May 22 2024, 2:42 AM
tomek added inline comments.
web/shared-worker/worker/process-operations.js
554 ↗(On Diff #40498)
This revision is now accepted and ready to land.May 22 2024, 2:42 AM
marcin updated this revision to Diff 40570.May 22 2024, 8:41 AM

Change & -> $

Harbormaster completed remote builds in B29199: Diff 40570.May 22 2024, 9:51 AM
Closed by commit rCOMMb51b09fb1359: Connect pipes between C++ and JS for entry store (authored by marcin). · Explain WhyMay 27 2024, 5:45 AM
This revision was automatically updated to reflect the committed changes.
marcin added a commit: rCOMMb51b09fb1359: Connect pipes between C++ and JS for entry store.

Revision Contents
Changeset List

PathSize
lib/
reducers/
1 line
types/
10 lines
native/
data/
5 lines
redux/
5 lines
web/
shared-worker/
utils/
16 lines
worker/
41 lines

Diff 40659

View Options

lib/reducers/message-reducer.test.js

Show All 22 Lines declare type StyleObj =
| '' | ''
| $ReadOnlyArray<StyleObj> | $ReadOnlyArray<StyleObj>
| { [name: string]: any, ... }; | { [name: string]: any, ... };
declare type ViewStyleProp = StyleObj; declare type ViewStyleProp = StyleObj;
declare type TextStyleProp = StyleObj; declare type TextStyleProp = StyleObj;
declare type StyleProps = $ReadOnly<{| declare type StyleProps = $ReadOnly<{|
...ViewStyleProp,
...TextStyleProp,
+originX?: number, +originX?: number,
+originY?: number, +originY?: number,
+[key: string]: any, +[key: string]: any,
|}>; |}>;
declare class NodeImpl { } declare class NodeImpl { }
declare class ValueImpl extends NodeImpl { declare class ValueImpl extends NodeImpl {
▲ Show 20 Lines • Show All 684 Lines • Show Last 20 Lines
View Options

lib/types/store-ops-types.js

Show All 22 Lines declare type StyleObj =
| '' | ''
| $ReadOnlyArray<StyleObj> | $ReadOnlyArray<StyleObj>
| { [name: string]: any, ... }; | { [name: string]: any, ... };
declare type ViewStyleProp = StyleObj; declare type ViewStyleProp = StyleObj;
declare type TextStyleProp = StyleObj; declare type TextStyleProp = StyleObj;
declare type StyleProps = $ReadOnly<{| declare type StyleProps = $ReadOnly<{|
...ViewStyleProp,
...TextStyleProp,
+originX?: number, +originX?: number,
+originY?: number, +originY?: number,
+[key: string]: any, +[key: string]: any,
|}>; |}>;
declare class NodeImpl { } declare class NodeImpl { }
declare class ValueImpl extends NodeImpl { declare class ValueImpl extends NodeImpl {
▲ Show 20 Lines • Show All 684 Lines • Show Last 20 Lines
View Options

native/data/sqlite-data-handler.js

Show All 22 Lines declare type StyleObj =
| '' | ''
| $ReadOnlyArray<StyleObj> | $ReadOnlyArray<StyleObj>
| { [name: string]: any, ... }; | { [name: string]: any, ... };
declare type ViewStyleProp = StyleObj; declare type ViewStyleProp = StyleObj;
declare type TextStyleProp = StyleObj; declare type TextStyleProp = StyleObj;
declare type StyleProps = $ReadOnly<{| declare type StyleProps = $ReadOnly<{|
...ViewStyleProp,
...TextStyleProp,
+originX?: number, +originX?: number,
+originY?: number, +originY?: number,
+[key: string]: any, +[key: string]: any,
|}>; |}>;
declare class NodeImpl { } declare class NodeImpl { }
declare class ValueImpl extends NodeImpl { declare class ValueImpl extends NodeImpl {
▲ Show 20 Lines • Show All 684 Lines • Show Last 20 Lines
View Options

native/redux/redux-utils.js

Show All 22 Lines declare type StyleObj =
| '' | ''
| $ReadOnlyArray<StyleObj> | $ReadOnlyArray<StyleObj>
| { [name: string]: any, ... }; | { [name: string]: any, ... };
declare type ViewStyleProp = StyleObj; declare type ViewStyleProp = StyleObj;
declare type TextStyleProp = StyleObj; declare type TextStyleProp = StyleObj;
declare type StyleProps = $ReadOnly<{| declare type StyleProps = $ReadOnly<{|
...ViewStyleProp,
...TextStyleProp,
+originX?: number, +originX?: number,
+originY?: number, +originY?: number,
+[key: string]: any, +[key: string]: any,
|}>; |}>;
declare class NodeImpl { } declare class NodeImpl { }
declare class ValueImpl extends NodeImpl { declare class ValueImpl extends NodeImpl {
▲ Show 20 Lines • Show All 684 Lines • Show Last 20 Lines
View Options

web/shared-worker/utils/store.js

Loading...
View Options

web/shared-worker/worker/process-operations.js

Loading...