Page MenuHomePhabricator
Differential D12164

[lib] Migrate remaining actions
ClosedPublic
Actions

Authored by tomek on May 21 2024, 1:00 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 20, 9:34 AM
Unknown Object (File)
Thu, Dec 5, 10:50 PM
Unknown Object (File)
Thu, Dec 5, 2:58 PM
Unknown Object (File)
Fri, Nov 29, 8:54 PM
Unknown Object (File)
Fri, Nov 29, 7:17 PM
Unknown Object (File)
Nov 10 2024, 8:58 AM
Unknown Object (File)
Nov 10 2024, 2:28 AM
Unknown Object (File)
Nov 10 2024, 1:38 AM
View All 70 Files
Subscribers
ashoat

Details

Reviewers
kamil
marcin
Commits
rCOMMc71b931f667c: [lib] Migrate remaining actions
Summary

Migrate the actions

Depends on D12163

https://linear.app/comm/issue/ENG-3486/move-entrystore-to-sqlite

Test Plan
  1. To test changeThreadSettingsActionTypes.success, removeUsersFromThreadActionTypes.success, changeThreadMemberRolesActionTypes.success: Create community as user A, add user B, create entry and delete user B. Check that entry disappears from B database.
  2. To test fetchRevisionsActionType: Click history on a calendar entry on Web.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tomek created this revision.May 21 2024, 1:00 PM
Herald added a subscriber: ashoat. · View Herald TranscriptMay 21 2024, 1:00 PM
Harbormaster completed remote builds in B29145: Diff 40513.May 21 2024, 1:21 PM
tomek requested review of this revision.May 21 2024, 1:21 PM
tomek added a child revision: D12153: [native] Persist only lastUserInteractionCalendar from the entry store.May 22 2024, 3:48 AM
tomek added a child revision: D12169: [web] Replace persisted entries with the ones from initial redux state.May 22 2024, 4:34 AM
tomek removed a child revision: D12153: [native] Persist only lastUserInteractionCalendar from the entry store.May 22 2024, 4:34 AM
marcin added inline comments.May 22 2024, 7:29 AM
lib/reducers/entry-reducer.js
527 ↗(On Diff #40513)

Tested works. Tested by restoring on web and seeing that it remains across renders and restarts,

542 ↗(On Diff #40513)

Tested works. Tested by seeing that after log in entries populate database and there are no local id entries.

marcin accepted this revision.May 23 2024, 5:27 AM
This revision is now accepted and ready to land.May 23 2024, 5:27 AM
marcin edited the test plan for this revision. (Show Details)May 24 2024, 7:39 AM
marcin edited the test plan for this revision. (Show Details)May 24 2024, 7:52 AM
marcin edited the test plan for this revision. (Show Details)May 24 2024, 8:03 AM
marcin edited the test plan for this revision. (Show Details)May 24 2024, 8:17 AM
Closed by commit rCOMMc71b931f667c: [lib] Migrate remaining actions (authored by tomek). · Explain WhyMay 27 2024, 5:51 AM
This revision was automatically updated to reflect the committed changes.
tomek added a commit: rCOMMc71b931f667c: [lib] Migrate remaining actions.

Revision Contents
Changeset List

PathSize
lib/
reducers/
61 lines

Diff 40668

View Options

lib/reducers/entry-reducer.js

Loading...