Details

Reviewers

tomek
kamil

Commits

rCOMM3c0246a0af6b: Implement JSI for EntryStore

Summary

This differential implements EntryStoreOperations and EntryStore

Test Plan

Compile

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

marcin created this revision.May 21 2024, 1:14 PM

Herald added a subscriber: ashoat. · View Herald TranscriptMay 21 2024, 1:14 PM

marcin added a parent revision: D12138: Implement SQLite API to handle entry store.May 21 2024, 1:15 PM

Harbormaster completed remote builds in B29092: Diff 40456.May 21 2024, 1:35 PM

marcin requested review of this revision.May 21 2024, 1:35 PM

entry_info -> entry

Harbormaster failed remote builds in B29100: Diff 40464!May 21 2024, 2:32 PM

tomek accepted this revision.May 21 2024, 2:33 PM

tomek added inline comments.

native/cpp/CommonCpp/NativeModules/EntryStoreOperations.h
43 ↗	(On Diff #40464)	newline
native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/DataStores/EntryStore.h
31 ↗	(On Diff #40464)	newline

This revision is now accepted and ready to land.May 21 2024, 2:33 PM

marcin added a child revision: D12148: Connect pipes between C++ and JS for entry store.May 21 2024, 2:43 PM

Rebase

Fix build failure

Harbormaster failed remote builds in B29108: Diff 40475!May 21 2024, 3:22 PM

Harbormaster completed remote builds in B29112: Diff 40479.May 21 2024, 3:46 PM

Add newlines

marcin edited the test plan for this revision. (Show Details)May 22 2024, 3:43 PM

Harbormaster completed remote builds in B29198: Diff 40569.May 22 2024, 4:45 PM

Closed by commit rCOMM3c0246a0af6b: Implement JSI for EntryStore. · Explain WhyMay 27 2024, 12:45 PM

This revision was automatically updated to reflect the committed changes.

marcin added a commit: rCOMM3c0246a0af6b: Implement JSI for EntryStore.

Implement JSI for EntryStore
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 40660

native/cpp/CommonCpp/NativeModules/CMakeLists.txt

native/cpp/CommonCpp/NativeModules/CommCoreModule.h

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

native/cpp/CommonCpp/NativeModules/EntryStoreOperations.h

native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/DataStores/EntryStore.h

native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/DataStores/EntryStore.cpp

native/ios/Comm.xcodeproj/project.pbxproj

Implement JSI for EntryStoreClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 40660

native/cpp/CommonCpp/NativeModules/CMakeLists.txt

native/cpp/CommonCpp/NativeModules/CommCoreModule.h

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

native/cpp/CommonCpp/NativeModules/EntryStoreOperations.h

native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/DataStores/EntryStore.h

native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/DataStores/EntryStore.cpp

native/ios/Comm.xcodeproj/project.pbxproj

Implement JSI for EntryStore
ClosedPublic
Actions

Revision Contents
Changeset List