Paths

Table of Contentst

Differential D13896

Upgrade to Rust 1.81
ClosedPublic
Actions

Authored by varun on Nov 7 2024, 2:12 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Dec 13, 11:17 PM

	Unknown Object (File)
	Fri, Dec 13, 11:17 PM

	Unknown Object (File)
	Fri, Dec 13, 11:17 PM

	Unknown Object (File)
	Fri, Dec 13, 11:16 PM

	Unknown Object (File)
	Fri, Dec 13, 11:16 PM

	Unknown Object (File)
	Fri, Dec 13, 11:15 PM

	Unknown Object (File)
	Fri, Dec 13, 11:09 PM

	Unknown Object (File)
	Wed, Dec 11, 4:59 PM

View All 64 Files

Subscribers

Details

Reviewers

will
bartek

Commits

rCOMM6e248249ec7b: Upgrade to Rust 1.81

Summary

Rust 1.81 introduced new lifetime rules, which opaque-ke, a crate we depend on, violated. The maintainers of that crate have introduced a new version that satisifies these new rules, and we have upgraded to this version in D13895. Now that we've upgraded the dependency, we should bump Rust to the latest stable version.

EDIT: we can't upgrade to 1.82, the latest stable version, because of an issue with wasm-bindgen: https://linear.app/comm/issue/ENG-9892/cant-upgrade-to-rust-182

Depends on D13895

Test Plan

All crates build locally and in Docker (CI)

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

varun created this revision.Nov 7 2024, 2:12 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptNov 7 2024, 2:12 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 7 2024, 2:25 PM

Harbormaster failed remote builds in B32580: Diff 45699!

Upgrade to 1.81 instead. https://github.com/rustwasm/wasm-bindgen/issues/4211 wasm-bindgen doesn't seem to work with 1.82 at the moment

varun retitled this revision from Upgrade to Rust 1.82 to Upgrade to Rust 1.81.Nov 7 2024, 3:12 PM

varun edited the summary of this revision. (Show Details)

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 7 2024, 3:21 PM

Harbormaster failed remote builds in B32581: Diff 45700!

ended up having to upgrade a lot of dependencies in the search-index-lambda. tested on staging that the lambda still works

Harbormaster completed remote builds in B32582: Diff 45701.Nov 7 2024, 4:13 PM

varun requested review of this revision.Nov 7 2024, 4:13 PM

will accepted this revision.Nov 7 2024, 4:18 PM

This revision is now accepted and ready to land.Nov 7 2024, 4:18 PM

minimal Cargo.lock update

Harbormaster completed remote builds in B32583: Diff 45702.Nov 7 2024, 5:48 PM

bartek accepted this revision.Nov 8 2024, 6:21 AM

Closed by commit rCOMM6e248249ec7b: Upgrade to Rust 1.81 (authored by varun). · Explain WhyNov 12 2024, 1:03 PM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMM6e248249ec7b: Upgrade to Rust 1.81.

Revision Contents
Changeset List

Path

Size

keyserver/

2 lines

rust-toolchain.toml

2 lines

services/

backup/

2 lines

blob/

2 lines

commtest/

2 lines

feature-flags/

2 lines

identity/

2 lines

reports/

2 lines

search-index-lambda/

tunnelbroker/

2 lines

Diff 45774

keyserver/Dockerfile

Loading...

rust-toolchain.toml

Loading...

services/backup/Dockerfile

Loading...

services/blob/Dockerfile

Loading...

services/commtest/Dockerfile

Loading...

services/feature-flags/Dockerfile

Loading...

services/identity/Dockerfile

Loading...

services/reports/Dockerfile

Loading...

services/search-index-lambda/Cargo.lock

Loading...

services/tunnelbroker/Dockerfile

Loading...