Page MenuHomePhabricator
Differential D13896

Upgrade to Rust 1.81
ClosedPublic
Actions

Authored by varun on Thu, Nov 7, 2:12 PM.
Tags
None
Referenced Files
F3366810: D13896.id45701.diff
Mon, Nov 25, 12:35 PM
F3361134: D13896.id.diff
Sun, Nov 24, 3:27 PM
Unknown Object (File)
Thu, Nov 21, 7:49 PM
Unknown Object (File)
Thu, Nov 21, 12:51 PM
Unknown Object (File)
Wed, Nov 20, 11:41 PM
Unknown Object (File)
Wed, Nov 20, 1:09 AM
Unknown Object (File)
Mon, Nov 18, 1:59 AM
Unknown Object (File)
Sun, Nov 17, 7:37 AM
View All 38 Files
Subscribers
ashoat
tomek

Details

Reviewers
will
bartek
Commits
rCOMM6e248249ec7b: Upgrade to Rust 1.81
Summary

Rust 1.81 introduced new lifetime rules, which opaque-ke, a crate we depend on, violated. The maintainers of that crate have introduced a new version that satisifies these new rules, and we have upgraded to this version in D13895. Now that we've upgraded the dependency, we should bump Rust to the latest stable version.

EDIT: we can't upgrade to 1.82, the latest stable version, because of an issue with wasm-bindgen: https://linear.app/comm/issue/ENG-9892/cant-upgrade-to-rust-182

Depends on D13895

Test Plan

All crates build locally and in Docker (CI)

Diff Detail

Repository
rCOMM Comm
Branch
opauqe (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

varun created this revision.Thu, Nov 7, 2:12 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptThu, Nov 7, 2:12 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Thu, Nov 7, 2:25 PM
Harbormaster failed remote builds in B32580: Diff 45699!
varun updated this revision to Diff 45700.Thu, Nov 7, 3:07 PM

Upgrade to 1.81 instead. https://github.com/rustwasm/wasm-bindgen/issues/4211 wasm-bindgen doesn't seem to work with 1.82 at the moment

varun retitled this revision from Upgrade to Rust 1.82 to Upgrade to Rust 1.81.Thu, Nov 7, 3:12 PM
varun edited the summary of this revision. (Show Details)
Harbormaster returned this revision to the author for changes because remote builds failed.Thu, Nov 7, 3:21 PM
Harbormaster failed remote builds in B32581: Diff 45700!
varun updated this revision to Diff 45701.Thu, Nov 7, 3:55 PM

ended up having to upgrade a lot of dependencies in the search-index-lambda. tested on staging that the lambda still works

Harbormaster completed remote builds in B32582: Diff 45701.Thu, Nov 7, 4:13 PM
varun requested review of this revision.Thu, Nov 7, 4:13 PM
will accepted this revision.Thu, Nov 7, 4:18 PM
This revision is now accepted and ready to land.Thu, Nov 7, 4:18 PM
varun updated this revision to Diff 45702.Thu, Nov 7, 5:29 PM

minimal Cargo.lock update

Harbormaster completed remote builds in B32583: Diff 45702.Thu, Nov 7, 5:48 PM
bartek accepted this revision.Fri, Nov 8, 6:21 AM
Closed by commit rCOMM6e248249ec7b: Upgrade to Rust 1.81 (authored by varun). · Explain WhyTue, Nov 12, 1:03 PM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMM6e248249ec7b: Upgrade to Rust 1.81.

Revision Contents
Changeset List

PathSize
keyserver/
2 lines
2 lines
services/
backup/
2 lines
blob/
2 lines
commtest/
2 lines
feature-flags/
2 lines
identity/
2 lines
reports/
2 lines
search-index-lambda/
tunnelbroker/
2 lines

Diff 45701

View Options

keyserver/Dockerfile

Loading...
View Options

rust-toolchain.toml

Loading...
View Options

services/backup/Dockerfile

Loading...
View Options

services/blob/Dockerfile

Loading...
View Options

services/commtest/Dockerfile

Loading...
View Options

services/feature-flags/Dockerfile

Loading...
View Options

services/identity/Dockerfile

Loading...
View Options

services/reports/Dockerfile

Loading...
View Options

services/search-index-lambda/Cargo.lock

Loading...
View Options

services/tunnelbroker/Dockerfile

Loading...