Page MenuHomePhabricator
Differential D13890

[native][web] Stop limiting media encryption to staff community
ClosedPublic
Actions

Authored by bartek on Nov 7 2024, 3:41 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 17, 9:19 AM
Unknown Object (File)
Mon, Mar 17, 8:44 AM
Unknown Object (File)
Fri, Mar 14, 3:46 AM
Unknown Object (File)
Fri, Mar 14, 3:41 AM
Unknown Object (File)
Tue, Mar 11, 7:00 AM
Unknown Object (File)
Tue, Mar 11, 6:54 AM
Unknown Object (File)
Mon, Mar 3, 2:31 PM
Unknown Object (File)
Mon, Mar 3, 12:43 PM
View All 51 Files
Subscribers
tomek

Details

Reviewers
ashoat
Commits
rCOMMdc9c299698c2: [native][web] Stop limiting media encryption to staff community
Summary

We had a check that enabled encrypted media only for staff community. Hardcoded it to enable encryption for all communities.

Depends on D13889

Test Plan

Used my local community for testing. Verified that after this change, multimedia messages are now of type encrypted-{photo,video}.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bartek created this revision.Nov 7 2024, 3:41 AM
bartek held this revision as a draft.
Herald added a subscriber: tomek. · View Herald TranscriptNov 7 2024, 3:41 AM
bartek added a child revision: D13891: [native][web] Flip the switch for blob-hosted media/avatar uploads.Nov 7 2024, 3:43 AM
Harbormaster failed remote builds in B32570: Diff 45657!Nov 7 2024, 3:44 AM
bartek mentioned this in D13892: [native][web] Clean up dead conditions for media encryption.Nov 7 2024, 3:46 AM
Harbormaster completed remote builds in B32570: Diff 45657.Nov 7 2024, 4:21 AM
bartek published this revision for review.Nov 7 2024, 4:50 AM
bartek added inline comments.
native/input/input-state-container.react.js
633–636 ↗(On Diff #45657)

This function is removed in D13892

ashoat accepted this revision.Nov 7 2024, 5:32 AM
This revision is now accepted and ready to land.Nov 7 2024, 5:32 AM
Closed by commit rCOMMdc9c299698c2: [native][web] Stop limiting media encryption to staff community (authored by bartek). · Explain WhyNov 7 2024, 8:25 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMMdc9c299698c2: [native][web] Stop limiting media encryption to staff community.
bartek mentioned this in rCOMM95e169f5657f: [native][web] Clean up dead conditions for media encryption.Nov 8 2024, 10:23 AM

Revision Contents
Changeset List

PathSize
native/
input/
8 lines
web/
input/
8 lines

Diff 45695

View Options

native/input/input-state-container.react.js

Show First 20 Lines • Show All 102 Lines • ▼ Show 20 Lines
import type { import type {
ConnectionIssue, ConnectionIssue,
StateSyncFullActionPayload, StateSyncFullActionPayload,
StateSyncIncrementalActionPayload, StateSyncIncrementalActionPayload,
SetActiveSessionRecoveryPayload, SetActiveSessionRecoveryPayload,
} from './socket-types.js'; } from './socket-types.js';
import { type ClientStore } from './store-ops-types.js'; import { type ClientStore } from './store-ops-types.js';
import type { SubscriptionUpdateResult } from './subscription-types.js'; import type { SubscriptionUpdateResult } from './subscription-types.js';
import type {
AddSyncedMetadataEntryPayload,
RemoveSyncedMetadataEntryPayload,
} from './synced-metadata-types.js';
import type { GlobalThemeInfo } from './theme-types.js'; import type { GlobalThemeInfo } from './theme-types.js';
import type { ThreadActivityStore } from './thread-activity-types.js'; import type { ThreadActivityStore } from './thread-activity-types.js';
import type { import type {
ThreadStore, ThreadStore,
ChangeThreadSettingsPayload, ChangeThreadSettingsPayload,
LeaveThreadPayload, LeaveThreadPayload,
NewThreadResult, NewThreadResult,
ThreadJoinPayload, ThreadJoinPayload,
▲ Show 20 Lines • Show All 1,239 Lines • ▼ Show 20 Lines | {
+type: 'SET_CONNECTION_ISSUE', +type: 'SET_CONNECTION_ISSUE',
+payload: { +connectionIssue: ?ConnectionIssue, +keyserverID: string }, +payload: { +connectionIssue: ?ConnectionIssue, +keyserverID: string },
} }
| { | {
+type: 'ADD_COMMUNITY', +type: 'ADD_COMMUNITY',
+payload: AddCommunityPayload, +payload: AddCommunityPayload,
} }
| { | {
+type: 'ADD_SYNCED_METADATA_ENTRY',
+payload: AddSyncedMetadataEntryPayload,
}
| {
+type: 'REMOVE_SYNCED_METADATA_ENTRY',
+payload: RemoveSyncedMetadataEntryPayload,
}
| {
+type: 'SET_ACTIVE_SESSION_RECOVERY', +type: 'SET_ACTIVE_SESSION_RECOVERY',
+payload: SetActiveSessionRecoveryPayload, +payload: SetActiveSessionRecoveryPayload,
} }
| { | {
+type: 'OPS_PROCESSING_FINISHED_ACTION_TYPE', +type: 'OPS_PROCESSING_FINISHED_ACTION_TYPE',
+payload?: void, +payload?: void,
}, },
}>; }>;
Show All 21 Lines
View Options

web/input/input-state-container.react.js

Show First 20 Lines • Show All 102 Lines • ▼ Show 20 Lines
import type { import type {
ConnectionIssue, ConnectionIssue,
StateSyncFullActionPayload, StateSyncFullActionPayload,
StateSyncIncrementalActionPayload, StateSyncIncrementalActionPayload,
SetActiveSessionRecoveryPayload, SetActiveSessionRecoveryPayload,
} from './socket-types.js'; } from './socket-types.js';
import { type ClientStore } from './store-ops-types.js'; import { type ClientStore } from './store-ops-types.js';
import type { SubscriptionUpdateResult } from './subscription-types.js'; import type { SubscriptionUpdateResult } from './subscription-types.js';
import type {
AddSyncedMetadataEntryPayload,
RemoveSyncedMetadataEntryPayload,
} from './synced-metadata-types.js';
import type { GlobalThemeInfo } from './theme-types.js'; import type { GlobalThemeInfo } from './theme-types.js';
import type { ThreadActivityStore } from './thread-activity-types.js'; import type { ThreadActivityStore } from './thread-activity-types.js';
import type { import type {
ThreadStore, ThreadStore,
ChangeThreadSettingsPayload, ChangeThreadSettingsPayload,
LeaveThreadPayload, LeaveThreadPayload,
NewThreadResult, NewThreadResult,
ThreadJoinPayload, ThreadJoinPayload,
▲ Show 20 Lines • Show All 1,239 Lines • ▼ Show 20 Lines | {
+type: 'SET_CONNECTION_ISSUE', +type: 'SET_CONNECTION_ISSUE',
+payload: { +connectionIssue: ?ConnectionIssue, +keyserverID: string }, +payload: { +connectionIssue: ?ConnectionIssue, +keyserverID: string },
} }
| { | {
+type: 'ADD_COMMUNITY', +type: 'ADD_COMMUNITY',
+payload: AddCommunityPayload, +payload: AddCommunityPayload,
} }
| { | {
+type: 'ADD_SYNCED_METADATA_ENTRY',
+payload: AddSyncedMetadataEntryPayload,
}
| {
+type: 'REMOVE_SYNCED_METADATA_ENTRY',
+payload: RemoveSyncedMetadataEntryPayload,
}
| {
+type: 'SET_ACTIVE_SESSION_RECOVERY', +type: 'SET_ACTIVE_SESSION_RECOVERY',
+payload: SetActiveSessionRecoveryPayload, +payload: SetActiveSessionRecoveryPayload,
} }
| { | {
+type: 'OPS_PROCESSING_FINISHED_ACTION_TYPE', +type: 'OPS_PROCESSING_FINISHED_ACTION_TYPE',
+payload?: void, +payload?: void,
}, },
}>; }>;
Show All 21 Lines