Page MenuHomePhabricator
Differential D13891

[native][web] Flip the switch for blob-hosted media/avatar uploads
ClosedPublic
Actions

Authored by bartek on Nov 7 2024, 3:43 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 20, 5:23 AM
Unknown Object (File)
Thu, Mar 20, 5:23 AM
Unknown Object (File)
Feb 20 2025, 8:35 PM
Unknown Object (File)
Feb 16 2025, 7:27 PM
Unknown Object (File)
Jan 22 2025, 10:15 PM
Unknown Object (File)
Jan 22 2025, 10:15 PM
Unknown Object (File)
Jan 22 2025, 10:15 PM
Unknown Object (File)
Jan 22 2025, 10:15 PM
View All 46 Files
Subscribers
tomek

Details

Reviewers
ashoat
Commits
rCOMM39b8726256bc: [native][web] Flip the switch for blob-hosted media/avatar uploads
rCOMMb1a48f05876f: [native][web] Flip the switch for blob-hosted media/avatar uploads
Summary

Flip the switch for enabling blob-hosted multimedia.

Depends on D13890

Test Plan

Verified in MariaDB that new uploads have empty content column and instead have the (blob hash, holder) pair.
Checked native/web, both avatars and multimedia meessages.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bartek created this revision.Nov 7 2024, 3:43 AM
bartek held this revision as a draft.
Herald added a subscriber: tomek. · View Herald TranscriptNov 7 2024, 3:43 AM
bartek added a child revision: D13892: [native][web] Clean up dead conditions for media encryption.Nov 7 2024, 3:46 AM
Harbormaster completed remote builds in B32571: Diff 45658.Nov 7 2024, 4:10 AM
bartek published this revision for review.Nov 7 2024, 4:51 AM
bartek added inline comments.
native/avatars/avatar-hooks.js
47 ↗(On Diff #45658)

These hardcoded values are removed in D13892

ashoat accepted this revision.Nov 7 2024, 5:32 AM
This revision is now accepted and ready to land.Nov 7 2024, 5:32 AM
Closed by commit rCOMMb1a48f05876f: [native][web] Flip the switch for blob-hosted media/avatar uploads (authored by bartek). · Explain WhyNov 7 2024, 8:25 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMMb1a48f05876f: [native][web] Flip the switch for blob-hosted media/avatar uploads.
ashoat added a reverting change: rCOMMeea1df0f6502: Revert "[native][web] Flip the switch for blob-hosted media/avatar uploads".Nov 7 2024, 7:13 PM
ashoat reopened this revision.Nov 7 2024, 7:13 PM
This revision is now accepted and ready to land.Nov 7 2024, 7:13 PM
ashoat added a comment.Nov 7 2024, 7:19 PM

Reverted this diff because blob-hosted multimedia in thin threads will get shimmed by the keyserver to recent mobile clients.

Even ignoring the fact that the current latest builds (after unpublishing 437 and 438, see ENG-9890) will fail to unshim blob-hosted multimedia messages, it's still probably not a good idea to launch this when only the latest mobile version is able to unshim the messages. The UX experience of being unable to see somebody's photo is pretty negative.

This should probably be addressed in D13888 by updating the keyserver to stop shimming for not just the most recent codeVersion, but rather for any codeVersion that supports blob-hosted multimedia messages. Once that change is made, I think this would be safe to land again.

Closed by commit rCOMM39b8726256bc: [native][web] Flip the switch for blob-hosted media/avatar uploads (authored by bartek). · Explain WhyNov 8 2024, 10:23 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMM39b8726256bc: [native][web] Flip the switch for blob-hosted media/avatar uploads.

Revision Contents
Changeset List

PathSize
native/
avatars/
3 lines
input/
5 lines
web/
avatars/
3 lines
input/
5 lines

Diff 45729

View Options

native/avatars/avatar-hooks.js

Show First 20 Lines • Show All 70 Lines • ▼ Show 20 Lines
import { validNavState } from './navigation/navigation-utils.js'; import { validNavState } from './navigation/navigation-utils.js';
import OrientationHandler from './navigation/orientation-handler.react.js'; import OrientationHandler from './navigation/orientation-handler.react.js';
import { navStateAsyncStorageKey } from './navigation/persistance.js'; import { navStateAsyncStorageKey } from './navigation/persistance.js';
import RootNavigator from './navigation/root-navigator.react.js'; import RootNavigator from './navigation/root-navigator.react.js';
import ConnectivityUpdater from './redux/connectivity-updater.react.js'; import ConnectivityUpdater from './redux/connectivity-updater.react.js';
import { DimensionsUpdater } from './redux/dimensions-updater.react.js'; import { DimensionsUpdater } from './redux/dimensions-updater.react.js';
import { getPersistor } from './redux/persist.js'; import { getPersistor } from './redux/persist.js';
import { store } from './redux/redux-setup.js'; import { store } from './redux/redux-setup.js';
import { useSelector } from './redux/redux-utils.js'; import { processDBStoreOperations, useSelector } from './redux/redux-utils.js';
import { RootContext } from './root-context.js'; import { RootContext } from './root-context.js';
import { MessageSearchProvider } from './search/search-provider.react.js'; import { MessageSearchProvider } from './search/search-provider.react.js';
import Socket from './socket.react.js'; import Socket from './socket.react.js';
import { useLoadCommFonts } from './themes/fonts.js'; import { useLoadCommFonts } from './themes/fonts.js';
import { DarkTheme, LightTheme } from './themes/navigation.js'; import { DarkTheme, LightTheme } from './themes/navigation.js';
import ThemeHandler from './themes/theme-handler.react.js'; import ThemeHandler from './themes/theme-handler.react.js';
import { provider } from './utils/ethers-utils.js'; import { provider } from './utils/ethers-utils.js';
import { neynarKey } from './utils/neynar-utils.js'; import { neynarKey } from './utils/neynar-utils.js';
▲ Show 20 Lines • Show All 184 Lines • ▼ Show 20 Lines <>
<KeyserverReachabilityHandler /> <KeyserverReachabilityHandler />
<DimensionsUpdater /> <DimensionsUpdater />
<ConnectivityUpdater /> <ConnectivityUpdater />
<ThemeHandler /> <ThemeHandler />
<OrientationHandler /> <OrientationHandler />
<BackupHandler /> <BackupHandler />
<IntegrityHandler /> <IntegrityHandler />
<AccessTokenHandler /> <AccessTokenHandler />
<DBOpsHandler /> <DBOpsHandler processDBStoreOperations={processDBStoreOperations} />
</> </>
); );
let navigation; let navigation;
if (initialState) { if (initialState) {
navigation = ( navigation = (
<NavigationContainer <NavigationContainer
initialState={initialState} initialState={initialState}
onStateChange={onNavigationStateChange} onStateChange={onNavigationStateChange}
▲ Show 20 Lines • Show All 105 Lines • Show Last 20 Lines
View Options

native/input/input-state-container.react.js

Show First 20 Lines • Show All 70 Lines • ▼ Show 20 Lines
import { validNavState } from './navigation/navigation-utils.js'; import { validNavState } from './navigation/navigation-utils.js';
import OrientationHandler from './navigation/orientation-handler.react.js'; import OrientationHandler from './navigation/orientation-handler.react.js';
import { navStateAsyncStorageKey } from './navigation/persistance.js'; import { navStateAsyncStorageKey } from './navigation/persistance.js';
import RootNavigator from './navigation/root-navigator.react.js'; import RootNavigator from './navigation/root-navigator.react.js';
import ConnectivityUpdater from './redux/connectivity-updater.react.js'; import ConnectivityUpdater from './redux/connectivity-updater.react.js';
import { DimensionsUpdater } from './redux/dimensions-updater.react.js'; import { DimensionsUpdater } from './redux/dimensions-updater.react.js';
import { getPersistor } from './redux/persist.js'; import { getPersistor } from './redux/persist.js';
import { store } from './redux/redux-setup.js'; import { store } from './redux/redux-setup.js';
import { useSelector } from './redux/redux-utils.js'; import { processDBStoreOperations, useSelector } from './redux/redux-utils.js';
import { RootContext } from './root-context.js'; import { RootContext } from './root-context.js';
import { MessageSearchProvider } from './search/search-provider.react.js'; import { MessageSearchProvider } from './search/search-provider.react.js';
import Socket from './socket.react.js'; import Socket from './socket.react.js';
import { useLoadCommFonts } from './themes/fonts.js'; import { useLoadCommFonts } from './themes/fonts.js';
import { DarkTheme, LightTheme } from './themes/navigation.js'; import { DarkTheme, LightTheme } from './themes/navigation.js';
import ThemeHandler from './themes/theme-handler.react.js'; import ThemeHandler from './themes/theme-handler.react.js';
import { provider } from './utils/ethers-utils.js'; import { provider } from './utils/ethers-utils.js';
import { neynarKey } from './utils/neynar-utils.js'; import { neynarKey } from './utils/neynar-utils.js';
▲ Show 20 Lines • Show All 184 Lines • ▼ Show 20 Lines <>
<KeyserverReachabilityHandler /> <KeyserverReachabilityHandler />
<DimensionsUpdater /> <DimensionsUpdater />
<ConnectivityUpdater /> <ConnectivityUpdater />
<ThemeHandler /> <ThemeHandler />
<OrientationHandler /> <OrientationHandler />
<BackupHandler /> <BackupHandler />
<IntegrityHandler /> <IntegrityHandler />
<AccessTokenHandler /> <AccessTokenHandler />
<DBOpsHandler /> <DBOpsHandler processDBStoreOperations={processDBStoreOperations} />
</> </>
); );
let navigation; let navigation;
if (initialState) { if (initialState) {
navigation = ( navigation = (
<NavigationContainer <NavigationContainer
initialState={initialState} initialState={initialState}
onStateChange={onNavigationStateChange} onStateChange={onNavigationStateChange}
▲ Show 20 Lines • Show All 105 Lines • Show Last 20 Lines
View Options

web/avatars/avatar-hooks.react.js

Show First 20 Lines • Show All 70 Lines • ▼ Show 20 Lines
import { validNavState } from './navigation/navigation-utils.js'; import { validNavState } from './navigation/navigation-utils.js';
import OrientationHandler from './navigation/orientation-handler.react.js'; import OrientationHandler from './navigation/orientation-handler.react.js';
import { navStateAsyncStorageKey } from './navigation/persistance.js'; import { navStateAsyncStorageKey } from './navigation/persistance.js';
import RootNavigator from './navigation/root-navigator.react.js'; import RootNavigator from './navigation/root-navigator.react.js';
import ConnectivityUpdater from './redux/connectivity-updater.react.js'; import ConnectivityUpdater from './redux/connectivity-updater.react.js';
import { DimensionsUpdater } from './redux/dimensions-updater.react.js'; import { DimensionsUpdater } from './redux/dimensions-updater.react.js';
import { getPersistor } from './redux/persist.js'; import { getPersistor } from './redux/persist.js';
import { store } from './redux/redux-setup.js'; import { store } from './redux/redux-setup.js';
import { useSelector } from './redux/redux-utils.js'; import { processDBStoreOperations, useSelector } from './redux/redux-utils.js';
import { RootContext } from './root-context.js'; import { RootContext } from './root-context.js';
import { MessageSearchProvider } from './search/search-provider.react.js'; import { MessageSearchProvider } from './search/search-provider.react.js';
import Socket from './socket.react.js'; import Socket from './socket.react.js';
import { useLoadCommFonts } from './themes/fonts.js'; import { useLoadCommFonts } from './themes/fonts.js';
import { DarkTheme, LightTheme } from './themes/navigation.js'; import { DarkTheme, LightTheme } from './themes/navigation.js';
import ThemeHandler from './themes/theme-handler.react.js'; import ThemeHandler from './themes/theme-handler.react.js';
import { provider } from './utils/ethers-utils.js'; import { provider } from './utils/ethers-utils.js';
import { neynarKey } from './utils/neynar-utils.js'; import { neynarKey } from './utils/neynar-utils.js';
▲ Show 20 Lines • Show All 184 Lines • ▼ Show 20 Lines <>
<KeyserverReachabilityHandler /> <KeyserverReachabilityHandler />
<DimensionsUpdater /> <DimensionsUpdater />
<ConnectivityUpdater /> <ConnectivityUpdater />
<ThemeHandler /> <ThemeHandler />
<OrientationHandler /> <OrientationHandler />
<BackupHandler /> <BackupHandler />
<IntegrityHandler /> <IntegrityHandler />
<AccessTokenHandler /> <AccessTokenHandler />
<DBOpsHandler /> <DBOpsHandler processDBStoreOperations={processDBStoreOperations} />
</> </>
); );
let navigation; let navigation;
if (initialState) { if (initialState) {
navigation = ( navigation = (
<NavigationContainer <NavigationContainer
initialState={initialState} initialState={initialState}
onStateChange={onNavigationStateChange} onStateChange={onNavigationStateChange}
▲ Show 20 Lines • Show All 105 Lines • Show Last 20 Lines
View Options

web/input/input-state-container.react.js

Show First 20 Lines • Show All 70 Lines • ▼ Show 20 Lines
import { validNavState } from './navigation/navigation-utils.js'; import { validNavState } from './navigation/navigation-utils.js';
import OrientationHandler from './navigation/orientation-handler.react.js'; import OrientationHandler from './navigation/orientation-handler.react.js';
import { navStateAsyncStorageKey } from './navigation/persistance.js'; import { navStateAsyncStorageKey } from './navigation/persistance.js';
import RootNavigator from './navigation/root-navigator.react.js'; import RootNavigator from './navigation/root-navigator.react.js';
import ConnectivityUpdater from './redux/connectivity-updater.react.js'; import ConnectivityUpdater from './redux/connectivity-updater.react.js';
import { DimensionsUpdater } from './redux/dimensions-updater.react.js'; import { DimensionsUpdater } from './redux/dimensions-updater.react.js';
import { getPersistor } from './redux/persist.js'; import { getPersistor } from './redux/persist.js';
import { store } from './redux/redux-setup.js'; import { store } from './redux/redux-setup.js';
import { useSelector } from './redux/redux-utils.js'; import { processDBStoreOperations, useSelector } from './redux/redux-utils.js';
import { RootContext } from './root-context.js'; import { RootContext } from './root-context.js';
import { MessageSearchProvider } from './search/search-provider.react.js'; import { MessageSearchProvider } from './search/search-provider.react.js';
import Socket from './socket.react.js'; import Socket from './socket.react.js';
import { useLoadCommFonts } from './themes/fonts.js'; import { useLoadCommFonts } from './themes/fonts.js';
import { DarkTheme, LightTheme } from './themes/navigation.js'; import { DarkTheme, LightTheme } from './themes/navigation.js';
import ThemeHandler from './themes/theme-handler.react.js'; import ThemeHandler from './themes/theme-handler.react.js';
import { provider } from './utils/ethers-utils.js'; import { provider } from './utils/ethers-utils.js';
import { neynarKey } from './utils/neynar-utils.js'; import { neynarKey } from './utils/neynar-utils.js';
▲ Show 20 Lines • Show All 184 Lines • ▼ Show 20 Lines <>
<KeyserverReachabilityHandler /> <KeyserverReachabilityHandler />
<DimensionsUpdater /> <DimensionsUpdater />
<ConnectivityUpdater /> <ConnectivityUpdater />
<ThemeHandler /> <ThemeHandler />
<OrientationHandler /> <OrientationHandler />
<BackupHandler /> <BackupHandler />
<IntegrityHandler /> <IntegrityHandler />
<AccessTokenHandler /> <AccessTokenHandler />
<DBOpsHandler /> <DBOpsHandler processDBStoreOperations={processDBStoreOperations} />
</> </>
); );
let navigation; let navigation;
if (initialState) { if (initialState) {
navigation = ( navigation = (
<NavigationContainer <NavigationContainer
initialState={initialState} initialState={initialState}
onStateChange={onNavigationStateChange} onStateChange={onNavigationStateChange}
▲ Show 20 Lines • Show All 105 Lines • Show Last 20 Lines