Details
Details
- Before applying D13888 and this, I sent some encrypted multimedia messages. They appeared as robotext
- Applied both diffs and ran migration
- Multimedia messages appeared normally
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| web/redux/persist.js | ||
|---|---|---|
| 721–724 ↗ | (On Diff #45656) | As stated in https://phab.comm.dev/D13888#inline-78351, we weren't shimming this on web so I created a no-op migration to keep state version consistent across platforms |
| native/redux/persist.js | ||
|---|---|---|
| 1499 ↗ | (On Diff #45694) | It's hard to believe this migration was tested, as it appears to me that it throws an exception on every single run |
Comment Actions
- Split out legacyUnshimClientDB for existing usages
- Introduce new unshimClientDB
- Do the same for web
Comment Actions
Comment Actions
I talked with @tomek, and we concluded that I had previously done the test plan wrong, and the migration didn't actually run. In short, I was logging in with state version 85 from the beginning.
New test plan:
- Set stateVersion in redux/persist.js to 84
- Log out / log in again (clear app state) and log in with state 84.
- Close the app. Bump state version to 85
- Open the app. Now the migration runs
yarn dev logs:
LOG redux-persist: migrationKeys [85] LOG redux-persist: running migration for versionKey 85
I was inspired by migration [35] which looked like this. It confused me because we also had DEPRECATED_unshimMessageStore(). I thought the latter was for "legacy" migrations, and the former is up to date.