Page MenuHomePhabricator

[native] Don't call handleReduxMigrationFailure for legacy migrations
ClosedPublic

Authored by ashoat on May 7 2024, 8:00 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Oct 21, 8:01 AM
Unknown Object (File)
Fri, Oct 11, 12:21 AM
Unknown Object (File)
Fri, Oct 11, 12:21 AM
Unknown Object (File)
Fri, Oct 11, 12:21 AM
Unknown Object (File)
Fri, Oct 11, 12:21 AM
Unknown Object (File)
Oct 8 2024, 8:04 AM
Unknown Object (File)
Oct 8 2024, 7:24 AM
Unknown Object (File)
Oct 8 2024, 4:36 AM
Subscribers

Details

Summary

@kamil explains this well in D11887. Most calls to unshimClientDB (all except for the new one introduced in that diff) get passed an older version of the Redux state, where cookie is a top-level field instead of being inside the KeyserverStore.

This diff changes the default behavior of unshimClientDB so that it clears that top-level field, instead of calling handleReduxMigrationFailure, which assumes that the cookie field has been migrated to inside the KeyserverStore.

Passing this as a third param might not be the most ideal way of doing this, but it's consistent with how we do it elsewhere.

Test Plan
  1. Flow
  2. Careful review of the code
  3. Observation that the same approach is already used elsewhere in the codebase

I considered trying to run the actual migrations, but they are very old and this would be rather time-consuming and likely to have issues. The change here is simple enough that I think the above three things, plus code review should be sufficient

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable