HomePhabricator
Diffusion Comm 02f35b2f17fc

[native] Don't call handleReduxMigrationFailure for legacy migrations

Description

[native] Don't call handleReduxMigrationFailure for legacy migrations

Summary:
@kamil explains this well in D11887. Most calls to unshimClientDB (all except for the new one introduced in that diff) get passed an older version of the Redux state, where cookie is a top-level field instead of being inside the KeyserverStore.

This diff changes the default behavior of unshimClientDB so that it clears that top-level field, instead of calling handleReduxMigrationFailure, which assumes that the cookie field has been migrated to inside the KeyserverStore.

Passing this as a third param might not be the most ideal way of doing this, but it's consistent with how we do it elsewhere.

Test Plan:

  1. Flow
  2. Careful review of the code
  3. Observation that the same approach is already used elsewhere in the codebase

I considered trying to run the actual migrations, but they are very old and this would be rather time-consuming and likely to have issues. The change here is simple enough that I think the above three things, plus code review should be sufficient

Reviewers: kamil, tomek

Reviewed By: tomek

Subscribers: kamil

Differential Revision: https://phab.comm.dev/D11928

Details

Provenance
ashoatAuthored on May 7 2024, 7:54 PM
Reviewer
tomek
Differential Revision
D11928: [native] Don't call handleReduxMigrationFailure for legacy migrations
Parents
rCOMM6da8b3ab56ba: [lib] Don't compare identity/keyserver login when not using CSAT
Branches
Unknown
Tags
Unknown