HomePhabricator
Diffusion Comm 6da8b3ab56ba

[lib] Don't compare identity/keyserver login when not using CSAT

Description

[lib] Don't compare identity/keyserver login when not using CSAT

Summary:
In D11692, I moved some logic from being processed on keyserverAuthActionTypes to setNewSessionActionType. I failed to consider that the former action is only used with usingCommServicesAccessToken, but the latter is used regardless of usingCommServicesAccessToken.

This prevents SET_NEW_SESSION for updating the session for legacy keyserver-based login. The session still gets updated later by the auth action (either legacy login or legacy registration), but it would be better to leave the logic as it was before, to avoid potentially breaking anything.

Test Plan:

  • Make sure login and registration in legacy single-keyserver environment still works
  • Try both new and old registration flows
  • Make sure keyserver auth returned a different user info than identity login log does not appear

Reviewers: inka, tomek

Reviewed By: inka

Differential Revision: https://phab.comm.dev/D11927

Details

Provenance
ashoatAuthored on May 7 2024, 10:55 AM
Reviewer
inka
Differential Revision
D11927: [lib] Don't compare identity/keyserver login when not using CSAT
Parents
rCOMM881e53f94b96: [native] Fix new registration flow when not using CSAT
Branches
Unknown
Tags
Unknown