Page MenuHomePhabricator

[native][web] Add migration to unshim Blob-hosted multimedia
Needs ReviewPublic

Authored by bartek on Thu, Nov 7, 3:37 AM.
Tags
None
Referenced Files
F3177484: D13889.diff
Thu, Nov 7, 11:31 PM
F3168809: D13889.id45656.diff
Thu, Nov 7, 8:34 AM
F3168135: D13889.id.diff
Thu, Nov 7, 5:39 AM
F3168046: D13889.id.diff
Thu, Nov 7, 5:21 AM
F3168003: D13889.diff
Thu, Nov 7, 5:06 AM
F3167625: D13889.diff
Thu, Nov 7, 4:23 AM
F3167333: D13889.id45656.diff
Thu, Nov 7, 3:51 AM
F3167328: D13889.id.diff
Thu, Nov 7, 3:51 AM
Subscribers

Details

Summary

Point 3c from ENG-6459.

Depends on D13888

Test Plan
  1. Before applying D13888 and this, I sent some encrypted multimedia messages. They appeared as robotext
  2. Applied both diffs and ran migration
  3. Multimedia messages appeared normally

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek held this revision as a draft.
bartek published this revision for review.Thu, Nov 7, 4:50 AM
bartek added inline comments.
web/redux/persist.js
721–724

As stated in https://phab.comm.dev/D13888#inline-78351, we weren't shimming this on web so I created a no-op migration to keep state version consistent across platforms

This revision is now accepted and ready to land.Thu, Nov 7, 5:31 AM
ashoat added inline comments.
native/redux/persist.js
1499 ↗(On Diff #45694)

It's hard to believe this migration was tested, as it appears to me that it throws an exception on every single run

This revision is now accepted and ready to land.Thu, Nov 7, 7:20 PM
native/redux/persist.js
1499 ↗(On Diff #45694)

There was an additional error here in not passing in handleReduxMigrationFailure. See D11928

  1. Split out legacyUnshimClientDB for existing usages
  2. Introduce new unshimClientDB
  3. Do the same for web

I did not do any testing. @bartek will need to test this before landing, thoroughly this time.

Setting @tomek as a blocking reviewer as I made significant changes here and he is most familiar with the migrations code.

native/redux/persist.js
1315 ↗(On Diff #45703)

Context in D11928 for why this is the only place on native where we pass handleReduxMigrationFailure to legacyUnshimClientDB

This revision now requires review to proceed.Thu, Nov 7, 8:33 PM