[native][web] Add migration to unshim Blob-hosted multimedia
Needs ReviewPublic
Actions

Authored by bartek on Thu, Nov 7, 3:37 AM.

Details

Reviewers

ashoat
tomek

Commits

Summary

Point 3c from ENG-6459.

Depends on D13888

Test Plan

Before applying D13888 and this, I sent some encrypted multimedia messages. They appeared as robotext
Applied both diffs and ran migration
Multimedia messages appeared normally

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

bartek held this revision as a draft.

bartek edited the test plan for this revision. (Show Details)Thu, Nov 7, 3:54 AM

bartek published this revision for review.Thu, Nov 7, 4:50 AM

bartek added inline comments.

web/redux/persist.js
721–724 ↗	(On Diff #45656)	As stated in https://phab.comm.dev/D13888#inline-78351, we weren't shimming this on web so I created a no-op migration to keep state version consistent across platforms

This revision is now accepted and ready to land.Thu, Nov 7, 5:31 AM

This revision was automatically updated to reflect the committed changes.

ashoat added inline comments.

native/redux/persist.js
1499	It's hard to believe this migration was tested, as it appears to me that it throws an exception on every single run

This revision is now accepted and ready to land.Thu, Nov 7, 7:20 PM

native/redux/persist.js
1499	There was an additional error here in not passing in `handleReduxMigrationFailure`. See D11928

I did not do any testing. @bartek will need to test this before landing, thoroughly this time.

Setting @tomek as a blocking reviewer as I made significant changes here and he is most familiar with the migrations code.

native/redux/persist.js
1315 ↗	(On Diff #45703)	Context in D11928 for why this is the only place on `native` where we pass `handleReduxMigrationFailure` to `legacyUnshimClientDB`