[backup] add errorType to error logs in backup
ClosedPublic
Actions

Authored by will on Nov 15 2024, 4:45 AM.

Details

Reviewers

kamil
bartek

Commits

rCOMM3d2db7642854: [backup] add errorType to error logs in backup

Summary

Add errorTypes to errors logs in backup service.

This includes:

DDB Error
Auth Error
Blob Error
WS Error

Depends on D13941

Test Plan

Deployed to staging. Verified that JSON error logs on cloudwatch include errorType

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

will created this revision.Nov 15 2024, 4:45 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptNov 15 2024, 4:45 AM

will added a child revision: D13943: [terraform] break up alarms into separate terraform files.Nov 15 2024, 4:52 AM

will retitled this revision from [backup] add errorType logs to backup to [backup] add errorType to error logs in backup.Nov 15 2024, 4:53 AM

will mentioned this in D13944: [terraform] create backup cloudwatch alarms.Nov 15 2024, 4:57 AM

Harbormaster completed remote builds in B32674: Diff 45833.Nov 15 2024, 5:03 AM

will requested review of this revision.Nov 15 2024, 5:03 AM

bartek accepted this revision.Nov 15 2024, 10:16 AM

bartek added 1 blocking reviewer(s): kamil.

LGTM but @bartek should review this too

bartek accepted this revision.Nov 15 2024, 10:18 AM

This revision is now accepted and ready to land.Nov 15 2024, 10:18 AM

Closed by commit rCOMM3d2db7642854: [backup] add errorType to error logs in backup. · Explain WhyNov 15 2024, 5:53 PM

This revision was automatically updated to reflect the committed changes.

will added a commit: rCOMM3d2db7642854: [backup] add errorType to error logs in backup.

will mentioned this in rCOMM9fe6ac4e8124: [terraform] create backup cloudwatch alarms.Nov 18 2024, 12:54 PM

Revision Contents
Changeset List

Path

Size

services/

backup/

src/

constants.rs

9 lines

database/

mod.rs

34 lines

error.rs

17 lines

http/

handlers/

log.rs

7 lines

Diff 45838

View Options

services/backup/src/constants.rs

View Options

services/backup/src/database/mod.rs

View Options

services/backup/src/error.rs

View Options

services/backup/src/http/handlers/log.rs

[backup] add errorType to error logs in backupClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 45838

services/backup/src/constants.rs

services/backup/src/database/mod.rs

services/backup/src/error.rs

services/backup/src/http/handlers/log.rs

[backup] add errorType to error logs in backup
ClosedPublic
Actions

Revision Contents
Changeset List