Page MenuHomePhabricator
Differential D13942

[backup] add errorType to error logs in backup
ClosedPublic
Actions

Authored by will on Nov 14 2024, 8:45 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 29, 4:22 AM
Unknown Object (File)
Sat, Mar 29, 2:44 AM
Unknown Object (File)
Sat, Mar 29, 1:49 AM
Unknown Object (File)
Fri, Mar 28, 2:48 PM
Unknown Object (File)
Sat, Mar 22, 9:06 AM
Unknown Object (File)
Sat, Mar 15, 7:27 AM
Unknown Object (File)
Fri, Mar 14, 6:13 AM
Unknown Object (File)
Fri, Mar 14, 5:22 AM
View All 79 Files
Subscribers
ashoat
tomek

Details

Reviewers
kamil
bartek
Commits
rCOMM3d2db7642854: [backup] add errorType to error logs in backup
Summary

Add errorTypes to errors logs in backup service.

This includes:

  • DDB Error
  • Auth Error
  • Blob Error
  • WS Error

Depends on D13941

Test Plan

Deployed to staging. Verified that JSON error logs on cloudwatch include errorType

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

will created this revision.Nov 14 2024, 8:45 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptNov 14 2024, 8:45 PM
will added a child revision: D13943: [terraform] break up alarms into separate terraform files.Nov 14 2024, 8:52 PM
will retitled this revision from [backup] add errorType logs to backup to [backup] add errorType to error logs in backup.Nov 14 2024, 8:53 PM
will mentioned this in D13944: [terraform] create backup cloudwatch alarms.Nov 14 2024, 8:57 PM
Harbormaster completed remote builds in B32674: Diff 45833.Nov 14 2024, 9:03 PM
will requested review of this revision.Nov 14 2024, 9:03 PM
bartek accepted this revision.Nov 15 2024, 2:16 AM
bartek added 1 blocking reviewer(s): kamil.
kamil accepted this revision.Nov 15 2024, 2:17 AM
kamil added 1 blocking reviewer(s): bartek.

LGTM but @bartek should review this too

bartek accepted this revision.Nov 15 2024, 2:18 AM
This revision is now accepted and ready to land.Nov 15 2024, 2:18 AM
Closed by commit rCOMM3d2db7642854: [backup] add errorType to error logs in backup (authored by will). · Explain WhyNov 15 2024, 9:53 AM
This revision was automatically updated to reflect the committed changes.
will added a commit: rCOMM3d2db7642854: [backup] add errorType to error logs in backup.
will mentioned this in rCOMM9fe6ac4e8124: [terraform] create backup cloudwatch alarms.Nov 18 2024, 4:54 AM

Revision Contents
Changeset List

PathSize
services/
backup/
src/
9 lines
database/
34 lines
17 lines
http/
handlers/
7 lines

Diff 45833

View Options

services/backup/src/constants.rs

Show First 20 Lines • Show All 902 Lines • ▼ Show 20 Lines rawThreadInfo = {
pinnedCount: serverThreadInfo.pinnedCount, pinnedCount: serverThreadInfo.pinnedCount,
}; };
} }
return shouldMinimallyEncodePermissions return shouldMinimallyEncodePermissions
? minimallyEncodeRawThreadInfo(rawThreadInfo) ? minimallyEncodeRawThreadInfo(rawThreadInfo)
: rawThreadInfo; : rawThreadInfo;
} }
function threadUIName( function threadUIName(threadInfo: ThreadInfo): string | ThreadEntity {
threadInfo: LegacyThreadInfo | ThreadInfo,
): string | ThreadEntity {
if (threadInfo.name) { if (threadInfo.name) {
return firstLine(threadInfo.name); return firstLine(threadInfo.name);
} }
let threadMembers: $ReadOnlyArray<RelativeMemberInfo>; const threadMembers: $ReadOnlyArray<RelativeMemberInfo> =
let memberEntities: $ReadOnlyArray<UserEntity>; threadInfo.members.filter(memberInfo => memberInfo.role);
// Branching below is to appease flow const memberEntities: $ReadOnlyArray<UserEntity> = threadMembers.map(member =>
if (threadInfo.minimallyEncoded) { ET.user({ userInfo: member }),
threadMembers = threadInfo.members.filter(memberInfo => memberInfo.role); );
memberEntities = threadMembers.map(member => ET.user({ userInfo: member }));
} else {
threadMembers = threadInfo.members.filter(memberInfo => memberInfo.role);
memberEntities = threadMembers.map(member => ET.user({ userInfo: member }));
}
return { return {
type: 'thread', type: 'thread',
id: threadInfo.id, id: threadInfo.id,
name: threadInfo.name, name: threadInfo.name,
display: 'uiName', display: 'uiName',
uiName: memberEntities, uiName: memberEntities,
ifJustViewer: ifJustViewer:
▲ Show 20 Lines • Show All 1,024 Lines • Show Last 20 Lines
View Options

services/backup/src/database/mod.rs

Show First 20 Lines • Show All 902 Lines • ▼ Show 20 Lines rawThreadInfo = {
pinnedCount: serverThreadInfo.pinnedCount, pinnedCount: serverThreadInfo.pinnedCount,
}; };
} }
return shouldMinimallyEncodePermissions return shouldMinimallyEncodePermissions
? minimallyEncodeRawThreadInfo(rawThreadInfo) ? minimallyEncodeRawThreadInfo(rawThreadInfo)
: rawThreadInfo; : rawThreadInfo;
} }
function threadUIName( function threadUIName(threadInfo: ThreadInfo): string | ThreadEntity {
threadInfo: LegacyThreadInfo | ThreadInfo,
): string | ThreadEntity {
if (threadInfo.name) { if (threadInfo.name) {
return firstLine(threadInfo.name); return firstLine(threadInfo.name);
} }
let threadMembers: $ReadOnlyArray<RelativeMemberInfo>; const threadMembers: $ReadOnlyArray<RelativeMemberInfo> =
let memberEntities: $ReadOnlyArray<UserEntity>; threadInfo.members.filter(memberInfo => memberInfo.role);
// Branching below is to appease flow const memberEntities: $ReadOnlyArray<UserEntity> = threadMembers.map(member =>
if (threadInfo.minimallyEncoded) { ET.user({ userInfo: member }),
threadMembers = threadInfo.members.filter(memberInfo => memberInfo.role); );
memberEntities = threadMembers.map(member => ET.user({ userInfo: member }));
} else {
threadMembers = threadInfo.members.filter(memberInfo => memberInfo.role);
memberEntities = threadMembers.map(member => ET.user({ userInfo: member }));
}
return { return {
type: 'thread', type: 'thread',
id: threadInfo.id, id: threadInfo.id,
name: threadInfo.name, name: threadInfo.name,
display: 'uiName', display: 'uiName',
uiName: memberEntities, uiName: memberEntities,
ifJustViewer: ifJustViewer:
▲ Show 20 Lines • Show All 1,024 Lines • Show Last 20 Lines
View Options

services/backup/src/error.rs

Show First 20 Lines • Show All 902 Lines • ▼ Show 20 Lines rawThreadInfo = {
pinnedCount: serverThreadInfo.pinnedCount, pinnedCount: serverThreadInfo.pinnedCount,
}; };
} }
return shouldMinimallyEncodePermissions return shouldMinimallyEncodePermissions
? minimallyEncodeRawThreadInfo(rawThreadInfo) ? minimallyEncodeRawThreadInfo(rawThreadInfo)
: rawThreadInfo; : rawThreadInfo;
} }
function threadUIName( function threadUIName(threadInfo: ThreadInfo): string | ThreadEntity {
threadInfo: LegacyThreadInfo | ThreadInfo,
): string | ThreadEntity {
if (threadInfo.name) { if (threadInfo.name) {
return firstLine(threadInfo.name); return firstLine(threadInfo.name);
} }
let threadMembers: $ReadOnlyArray<RelativeMemberInfo>; const threadMembers: $ReadOnlyArray<RelativeMemberInfo> =
let memberEntities: $ReadOnlyArray<UserEntity>; threadInfo.members.filter(memberInfo => memberInfo.role);
// Branching below is to appease flow const memberEntities: $ReadOnlyArray<UserEntity> = threadMembers.map(member =>
if (threadInfo.minimallyEncoded) { ET.user({ userInfo: member }),
threadMembers = threadInfo.members.filter(memberInfo => memberInfo.role); );
memberEntities = threadMembers.map(member => ET.user({ userInfo: member }));
} else {
threadMembers = threadInfo.members.filter(memberInfo => memberInfo.role);
memberEntities = threadMembers.map(member => ET.user({ userInfo: member }));
}
return { return {
type: 'thread', type: 'thread',
id: threadInfo.id, id: threadInfo.id,
name: threadInfo.name, name: threadInfo.name,
display: 'uiName', display: 'uiName',
uiName: memberEntities, uiName: memberEntities,
ifJustViewer: ifJustViewer:
▲ Show 20 Lines • Show All 1,024 Lines • Show Last 20 Lines
View Options

services/backup/src/http/handlers/log.rs

Show First 20 Lines • Show All 902 Lines • ▼ Show 20 Lines rawThreadInfo = {
pinnedCount: serverThreadInfo.pinnedCount, pinnedCount: serverThreadInfo.pinnedCount,
}; };
} }
return shouldMinimallyEncodePermissions return shouldMinimallyEncodePermissions
? minimallyEncodeRawThreadInfo(rawThreadInfo) ? minimallyEncodeRawThreadInfo(rawThreadInfo)
: rawThreadInfo; : rawThreadInfo;
} }
function threadUIName( function threadUIName(threadInfo: ThreadInfo): string | ThreadEntity {
threadInfo: LegacyThreadInfo | ThreadInfo,
): string | ThreadEntity {
if (threadInfo.name) { if (threadInfo.name) {
return firstLine(threadInfo.name); return firstLine(threadInfo.name);
} }
let threadMembers: $ReadOnlyArray<RelativeMemberInfo>; const threadMembers: $ReadOnlyArray<RelativeMemberInfo> =
let memberEntities: $ReadOnlyArray<UserEntity>; threadInfo.members.filter(memberInfo => memberInfo.role);
// Branching below is to appease flow const memberEntities: $ReadOnlyArray<UserEntity> = threadMembers.map(member =>
if (threadInfo.minimallyEncoded) { ET.user({ userInfo: member }),
threadMembers = threadInfo.members.filter(memberInfo => memberInfo.role); );
memberEntities = threadMembers.map(member => ET.user({ userInfo: member }));
} else {
threadMembers = threadInfo.members.filter(memberInfo => memberInfo.role);
memberEntities = threadMembers.map(member => ET.user({ userInfo: member }));
}
return { return {
type: 'thread', type: 'thread',
id: threadInfo.id, id: threadInfo.id,
name: threadInfo.name, name: threadInfo.name,
display: 'uiName', display: 'uiName',
uiName: memberEntities, uiName: memberEntities,
ifJustViewer: ifJustViewer:
▲ Show 20 Lines • Show All 1,024 Lines • Show Last 20 Lines