[lib] Extract handling Olm P2P messages to a separate function
ClosedPublic
Actions

Authored by bartek on Tue, Jul 2, 5:03 AM.

Details

Reviewers

kamil

Commits

rCOMM7b122b94885a: [lib] Extract handling Olm P2P messages to a separate function

Summary

Code for handling ENCRYPTED_MESSAGE is expected to grow really large, so extracted this logic to a separate hook.
It can be split further into smaller functions when it grows too large (e.g. separate function for user actions).

Depends on D12636

Test Plan

Flow. Also checked secondary device logout - it still works as expected.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Tue, Jul 2, 5:03 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptTue, Jul 2, 5:03 AM

bartek added a child revision: D12638: [lib] Send primary device logout message to secondary devices.Tue, Jul 2, 5:08 AM

Harbormaster completed remote builds in B30049: Diff 41880.Tue, Jul 2, 5:19 AM

bartek published this revision for review.Tue, Jul 2, 5:52 AM

kamil accepted this revision.Wed, Jul 3, 2:18 AM

This revision is now accepted and ready to land.Wed, Jul 3, 2:18 AM

Closed by commit rCOMM7b122b94885a: [lib] Extract handling Olm P2P messages to a separate function (authored by bartek). · Explain WhyThu, Jul 4, 1:37 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM7b122b94885a: [lib] Extract handling Olm P2P messages to a separate function.

Revision Contents
Changeset List

Path

Size

lib/

tunnelbroker/

use-peer-to-peer-message-handler.js

96 lines

Diff 42005

View Options

lib/tunnelbroker/use-peer-to-peer-message-handler.js

[lib] Extract handling Olm P2P messages to a separate functionClosedPublicActions