Paths

Table of Contentst

Differential D12589

[identity] Make apply_devicelist_update more generic
Needs ReviewPublic
Actions

Authored by bartek on Thu, Jun 27, 7:32 AM.

Tags

None

Referenced Files

	F2141156: D12589.diff
	Sat, Jun 29, 10:13 AM

	Unknown Object (File)
	Thu, Jun 27, 9:47 AM

	Unknown Object (File)
	Thu, Jun 27, 9:47 AM

	Unknown Object (File)
	Thu, Jun 27, 9:47 AM

	Unknown Object (File)
	Thu, Jun 27, 9:45 AM

Subscribers

Details

Reviewers

kamil
varun
will

Summary

Currently, apply_devicelist_update requires a device list validator, and also has side effects (removes device data when it's removed from the list).
Usually we want this, but there are usecases when either of them is not needed - when these actions are performed externally.

Depends on D12588

Test Plan

Commtest. Confirmed that UpdateDeviceList RPC still works as expected - validates the device list and removes device data.

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Thu, Jun 27, 7:32 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptThu, Jun 27, 7:32 AM

bartek added a child revision: D12590: [identity] Implement LogOutPrimaryDevice RPC.Thu, Jun 27, 7:38 AM

Rebase

Harbormaster failed remote builds in B29954: Diff 41751!Thu, Jun 27, 8:10 AM

Harbormaster completed remote builds in B29960: Diff 41757.Thu, Jun 27, 8:39 AM

bartek published this revision for review.Fri, Jun 28, 1:05 AM

Revision Contents
Changeset List

Path

Size

services/

identity/

src/

database/

28 lines

grpc_services/

authenticated.rs

8 lines

Diff 41757

services/identity/src/database/device_list.rs

Loading...

services/identity/src/grpc_services/authenticated.rs

Loading...