Paths

Table of Contentst

Differential D12767

[Tunnelbroker] implement messages types to FCM service
ClosedPublic
Actions

Authored by kamil on Jul 16 2024, 8:23 AM.

Tags

None

Referenced Files

	F32508179: D12767.1767070481.diff
	Mon, Dec 29, 4:54 AM

Subscribers

Details

Reviewers

bartek
marcin

Commits

rCOMM211db5e62aaf: [Tunnelbroker] implement messages types to FCM service

Summary

Implementing (limited to our needs) interface described in Firebase Cloud Messaging Service.

Depends on D12766

Test Plan

cargo check

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Jul 16 2024, 8:23 AM

kamil held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 16 2024, 8:23 AM

kamil added a child revision: D12768: [Tunnelbroker] implement errors from FCM service.Jul 16 2024, 8:24 AM

Harbormaster completed remote builds in B30362: Diff 42324.Jul 16 2024, 8:42 AM

kamil published this revision for review.Jul 16 2024, 9:41 AM

kamil added inline comments.

services/tunnelbroker/src/notifs/fcm/firebase_message.rs
23 ↗	(On Diff #42324)	discussed this with @marcin and this is the only prop we need other than `data` in `FCMMessage`
41–47 ↗	(On Diff #42324)	I guess this could be done better using `serde`, but I failed to make it work

bartek accepted this revision.Jul 17 2024, 4:04 PM

bartek added inline comments.

services/tunnelbroker/src/notifs/fcm/firebase_message.rs
41–47 ↗	(On Diff #42324)	It is possible, but requires either an external crate or custom implementation of `Deserialize` trait. The latter would still be a bit less readable than this. So not worth doing, this is good enough

This revision is now accepted and ready to land.Jul 17 2024, 4:04 PM

bartek mentioned this in D12770: [Tunnelbroker][lib] add FCM notif message type.Jul 18 2024, 2:25 PM

kamil added inline comments.Jul 19 2024, 9:19 AM

services/tunnelbroker/src/notifs/fcm/firebase_message.rs
41–47 ↗	(On Diff #42324)	thanks!

Closed by commit rCOMM211db5e62aaf: [Tunnelbroker] implement messages types to FCM service. · Explain WhyJul 19 2024, 12:05 PM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM211db5e62aaf: [Tunnelbroker] implement messages types to FCM service.

Revision Contents
Changeset List

Path

Size

services/

tunnelbroker/

src/

notifs/

fcm/

firebase_message.rs

48 lines

1 line

Diff 42527

services/tunnelbroker/src/notifs/fcm/firebase_message.rs

Loading...

services/tunnelbroker/src/notifs/fcm/mod.rs

Loading...