Page MenuHomePhabricator

[Tunnelbroker] implement messages types to FCM service
ClosedPublic

Authored by kamil on Jul 16 2024, 1:23 AM.
Tags
None
Referenced Files
F3359575: D12767.diff
Sun, Nov 24, 9:43 AM
Unknown Object (File)
Sat, Nov 2, 2:19 AM
Unknown Object (File)
Fri, Nov 1, 10:18 AM
Unknown Object (File)
Fri, Nov 1, 10:18 AM
Unknown Object (File)
Fri, Nov 1, 10:18 AM
Unknown Object (File)
Fri, Nov 1, 10:18 AM
Unknown Object (File)
Oct 23 2024, 5:50 PM
Unknown Object (File)
Oct 22 2024, 1:23 PM
Subscribers

Details

Summary

Implementing (limited to our needs) interface described in Firebase Cloud Messaging Service.

Depends on D12766

Test Plan

cargo check

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil held this revision as a draft.
kamil published this revision for review.Jul 16 2024, 2:41 AM
kamil added inline comments.
services/tunnelbroker/src/notifs/fcm/firebase_message.rs
23

discussed this with @marcin and this is the only prop we need other than data in FCMMessage

41–47

I guess this could be done better using serde, but I failed to make it work

bartek added inline comments.
services/tunnelbroker/src/notifs/fcm/firebase_message.rs
41–47

It is possible, but requires either an external crate or custom implementation of Deserialize trait. The latter would still be a bit less readable than this.
So not worth doing, this is good enough

This revision is now accepted and ready to land.Jul 17 2024, 9:04 AM
services/tunnelbroker/src/notifs/fcm/firebase_message.rs
41–47

thanks!