Page MenuHomePhabricator
Differential D12830

[identity] check users table before reserved usernames table for user ID during wallet login
ClosedPublic
Actions

Authored by varun on Jul 21 2024, 12:04 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Aug 10, 7:50 PM
Unknown Object (File)
Thu, Aug 8, 8:53 PM
Unknown Object (File)
Aug 5 2024, 8:58 PM
Unknown Object (File)
Aug 4 2024, 3:48 PM
Unknown Object (File)
Aug 4 2024, 4:04 AM
Unknown Object (File)
Aug 3 2024, 9:39 PM
Unknown Object (File)
Aug 3 2024, 9:39 PM
Unknown Object (File)
Aug 3 2024, 9:39 PM
View All 18 Files
Subscribers
ashoat
tomek

Details

Reviewers
will
bartek
Commits
rCOMM63e8e9dea808: [identity] check users table before reserved usernames table for user ID during…
Summary

we should check the users table first in case the user ID happens to be in both tables for some reason (this should never happen, but unfortunately there was a bug that led to this rule being violated). by checking the users table first, we ensure that registered wallet users will be able to log in even if there is invalid data in the reserved usernames table.

Test Plan

add userID and wallet address to staging reserved usernames table. then successfully log in with wallet

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

varun created this revision.Jul 21 2024, 12:04 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 21 2024, 12:04 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Jul 21 2024, 12:15 PM
Harbormaster failed remote builds in B30550: Diff 42597!
varun requested review of this revision.Jul 21 2024, 1:38 PM
bartek accepted this revision.Jul 22 2024, 1:50 AM
bartek added inline comments.
services/identity/src/client_service.rs
521 ↗(On Diff #42597)

you can use login_time here too

This revision is now accepted and ready to land.Jul 22 2024, 1:50 AM
This revision was landed with ongoing or failed builds.Jul 22 2024, 10:03 AM
Closed by commit rCOMM63e8e9dea808: [identity] check users table before reserved usernames table for user ID during… (authored by varun). · Explain Why
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMM63e8e9dea808: [identity] check users table before reserved usernames table for user ID during….

Revision Contents
Changeset List

PathSize
services/
identity/
src/
52 lines

Diff 42631

View Options

services/identity/src/client_service.rs

Loading...