Page MenuHomePhabricator

[identity] modify get_all_user_details to return wallet addresses too
ClosedPublic

Authored by varun on Jul 21 2024, 8:46 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Sep 25, 5:44 PM
Unknown Object (File)
Sep 8 2024, 2:13 AM
Unknown Object (File)
Sep 8 2024, 2:13 AM
Unknown Object (File)
Sep 8 2024, 2:13 AM
Unknown Object (File)
Sep 8 2024, 2:13 AM
Unknown Object (File)
Sep 6 2024, 8:49 AM
Unknown Object (File)
Sep 6 2024, 2:46 AM
Unknown Object (File)
Sep 1 2024, 6:16 AM
Subscribers

Details

Summary

this bug was kind of hidden because we were re-writing claimed wallet addresses to the reserved usernames table, so the identity search index was still being populated with all the addresses -- just from the wrong source. after D12831, we're no longer re-writing claimed wallet addresses to the reserved usernames table, so the identity search index will not contain claimed/registered wallet addresses. by modifying get_all_user_details to return wallet addresses, we resolve this issue.

Depends on D12831

Test Plan

called get_all_user_details from main and confirmed that it now contains UserDetails with wallet addresses

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

varun published this revision for review.Jul 21 2024, 8:54 PM
varun added inline comments.
services/identity/src/database.rs
991 ↗(On Diff #42599)

I’ll change this line to avoid leaking sensitive data

This revision is now accepted and ready to land.Jul 22 2024, 1:58 AM