Page MenuHomePhabricator

[identity] Add function to batch-get device lists
ClosedPublic

Authored by bartek on Jul 26 2024, 2:55 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 13, 2:36 AM
Unknown Object (File)
Fri, Nov 8, 10:36 PM
Unknown Object (File)
Fri, Nov 8, 1:43 PM
Unknown Object (File)
Fri, Nov 8, 12:22 PM
Unknown Object (File)
Fri, Nov 8, 12:22 PM
Unknown Object (File)
Sep 25 2024, 5:15 PM
Unknown Object (File)
Sep 25 2024, 5:15 PM
Unknown Object (File)
Sep 25 2024, 5:15 PM
Subscribers

Details

Summary

Part of GetDeviceListsForUsers RPC rewrite. Details in ENG-8843.

Added a function that fetches latest device lists by using the timestamp attribute from users table. This way, we can get primary keys for device lists
without using Query, and thus can do BatchGet

Test Plan

Detailed test plan in ENG-8843.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bartek held this revision as a draft.
bartek published this revision for review.Jul 26 2024, 3:45 AM
This revision is now accepted and ready to land.Jul 26 2024, 12:29 PM
services/identity/src/database/device_list.rs
1064 ↗(On Diff #42803)

do we want a tracing instrument here?

services/identity/src/database/device_list.rs
1064 ↗(On Diff #42803)

Yeah good idea