review feedback and whitespace
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Yesterday
Mon, May 6
add sync pattern
review feedback
review feedback
fix misconfigured email endpoint
Sun, May 5
Fri, May 3
Thu, May 2
In D11852#339861, @varun wrote:I was imagining that all the prefixes (e.g. DB Error) would be defined in a module in constants.rs and then used like this:
pub const DB_ERROR_LOG_PREFIX: &str = "DB Error"; error!(DB_ERROR_LOG_PREFIX, "Encountered an unexpected error: {}", e);
Wed, May 1
review feedback
Tue, Apr 30
Sun, Apr 28
Fri, Apr 26
Looks good to me
Thu, Apr 25
rebase
rebase
Tue, Apr 23
Fri, Apr 19
fix tests
rebase before landing
rebase before landing
style. rebase before landing
Do not assert equality of threadActivity on web
Thu, Apr 18
rename clear to not include friends
Wed, Apr 17
Removing the language of friends. This action type will encompass wiping all aux user store data irregardless of whether or not the user is friends with them or not.
Updated linear project with new tasks: https://linear.app/comm/project/farcaster-sqlite-followups-a2415120f443.
In D11672#335437, @ashoat wrote:but I'm also thinking we might be able to run it when we disconnect our farcaster accounts?
What's the purpose of the aux user store? If it's for showing Farcaster IDs in user profiles, I guess we should be showing those regardless of whether the users are Farcaster friends, and regardless of whether the viewer even has associated a Farcaster account.
Separately, thinking about this a bit more... is the purpose of putting FIDs in the aux user store so that we can show Farcaster accounts on user profiles in Comm? If >> so, shouldn't we fetch FIDs for all users in the UserStore, and not just for Farcaster friends?
In D11672#335437, @ashoat wrote:but I'm also thinking we might be able to run it when we disconnect our farcaster accounts?
What's the purpose of the aux user store? If it's for showing Farcaster IDs in user profiles, I guess we should be showing those regardless of whether the users are Farcaster friends, and regardless of whether the viewer even has associated a Farcaster account.
Tue, Apr 16
rebase
review feedback