[identity] use identitySearchSocket instead of socket.current
ClosedPublic
Actions

Authored by will on Dec 7 2024, 11:14 AM.

Details

Reviewers

kamil
varun
ashoat

Commits

rCOMM379d8575a713: [identity] use identitySearchSocket instead of socket.current

Summary

This addresses https://linear.app/comm/issue/ENG-9971/[error-invalid-state-err]-in-identitysearchprovider

We should be using identitySearchSocket instead of socket.current could be null before we properly set it

Test Plan

cargo check

Didn't get to testing this properly. Putting up this diff for now to get it into review, but I'll ensure we're not getting spammed with:

ERROR  [Error: INVALID_STATE_ERR]

before landing

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

will created this revision.Dec 7 2024, 11:14 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 7 2024, 11:14 AM

will edited the test plan for this revision. (Show Details)Dec 7 2024, 11:14 AM

will edited the test plan for this revision. (Show Details)

Harbormaster completed remote builds in B32962: Diff 46257.Dec 7 2024, 11:32 AM

will requested review of this revision.Dec 7 2024, 11:32 AM

ashoat accepted this revision.Dec 7 2024, 12:36 PM

This revision is now accepted and ready to land.Dec 7 2024, 12:36 PM

Closed by commit rCOMM379d8575a713: [identity] use identitySearchSocket instead of socket.current (authored by will). · Explain WhyDec 7 2024, 12:55 PM

This revision was automatically updated to reflect the committed changes.

will added a commit: rCOMM379d8575a713: [identity] use identitySearchSocket instead of socket.current.

Revision Contents
Changeset List

Path

Size

lib/

identity-search/

identity-search-context.js

2 lines

Diff 46258

View Options

lib/identity-search/identity-search-context.js

[identity] use identitySearchSocket instead of socket.currentClosedPublicActions