Page MenuHomePhabricator
Differential D14094

[identity] use identitySearchSocket instead of socket.current
ClosedPublic
Actions

Authored by will on Dec 7 2024, 11:14 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 26, 11:09 PM
Unknown Object (File)
Wed, Mar 26, 8:34 AM
Unknown Object (File)
Wed, Mar 26, 7:01 AM
Unknown Object (File)
Tue, Mar 25, 11:05 AM
Unknown Object (File)
Sat, Mar 15, 2:16 PM
Unknown Object (File)
Tue, Mar 11, 3:41 PM
Unknown Object (File)
Tue, Mar 11, 3:37 PM
Unknown Object (File)
Feb 18 2025, 10:59 AM
View All 36 Files
Subscribers
ashoat
tomek

Details

Reviewers
kamil
varun
ashoat
Commits
rCOMM379d8575a713: [identity] use identitySearchSocket instead of socket.current
Summary

This addresses https://linear.app/comm/issue/ENG-9971/[error-invalid-state-err]-in-identitysearchprovider

We should be using identitySearchSocket instead of socket.current could be null before we properly set it

Test Plan

cargo check

Didn't get to testing this properly. Putting up this diff for now to get it into review, but I'll ensure we're not getting spammed with:

ERROR  [Error: INVALID_STATE_ERR]

before landing

Diff Detail

Repository
rCOMM Comm
Branch
fix_heartbeat_identity_search_provider
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
lib/
identity-search/
2 lines

Diff 46257

View Options

lib/identity-search/identity-search-context.js

Show All 35 Lines <div className={css.wrapper}>
<TeamProfile <TeamProfile
name="Ashoat Tevosyan" name="Ashoat Tevosyan"
role="Founder" role="Founder"
githubHandle="ashoat" githubHandle="ashoat"
twitterHandle="ashoat" twitterHandle="ashoat"
imageURL={`${assetsCacheURLPrefix}/ashoat.png`} imageURL={`${assetsCacheURLPrefix}/ashoat.png`}
/> />
<TeamProfile <TeamProfile
name="atul"
role="Software Engineer"
githubHandle="atulsmadhugiri"
twitterHandle="atuli0"
imageURL={`${assetsCacheURLPrefix}/atul.jpeg`}
/>
<TeamProfile
name="Varun Dhananjaya" name="Varun Dhananjaya"
role="Software Engineer" role="Software Engineer"
githubHandle="vdhanan" githubHandle="vdhanan"
twitterHandle="_va_run" twitterHandle="_va_run"
imageURL={`${assetsCacheURLPrefix}/varun.jpeg`} imageURL={`${assetsCacheURLPrefix}/varun.jpeg`}
/> />
<TeamProfile <TeamProfile
name="Mark Rafferty" name="William Wang"
role="Recruiter"
imageURL={`${assetsCacheURLPrefix}/mark.jpg`}
/>
<TeamProfile
name="Anunay Kulshrestha"
role="Research Scientist"
imageURL={`${assetsCacheURLPrefix}/anunay.jpg`}
/>
<TeamProfile
name="Ginsu Eddy"
role="Software Engineer" role="Software Engineer"
githubHandle="ginsueddy" imageURL={`${assetsCacheURLPrefix}/will.jpg`}
twitterHandle="ginsueddy" githubHandle="wyilio"
imageURL={`${assetsCacheURLPrefix}/ginsu.jpg`}
/> />
<TeamProfile <TeamProfile
name="Rohan Khanderia" name="Yiannis Tselekounis"
role="Software Engineer" role="Research Scientist"
imageURL={`${assetsCacheURLPrefix}/rohan.jpg`} imageURL={`${assetsCacheURLPrefix}/yiannis.jpeg`}
githubHandle="RohanK6"
/> />
<TeamProfile <TeamProfile
name="William Wang" name="Mark Rafferty"
role="Software Engineer" role="Recruiter"
imageURL={`${assetsCacheURLPrefix}/will.jpg`} imageURL={`${assetsCacheURLPrefix}/mark.jpg`}
githubHandle="wyilio"
/> />
</div> </div>
</section> </section>
<h2 className={headerClassName}>Team at Software Mansion</h2> <h2 className={headerClassName}>Team at Software Mansion</h2>
<section className={css.teamWrapper}> <section className={css.teamWrapper}>
<TeamProfile <TeamProfile
name="Tomasz Pałys" name="Tomasz Pałys"
role="Software Engineer" role="Software Engineer"
githubHandle="palys-swm" githubHandle="palys-swm"
imageURL={`${assetsCacheURLPrefix}/tomek.png`} imageURL={`${assetsCacheURLPrefix}/tomek.png`}
/> />
<TeamProfile <TeamProfile
name="Marcin Wasowicz"
role="Software Engineer"
githubHandle="marcinwasowicz"
imageURL={`${assetsCacheURLPrefix}/marcin.jpeg`}
/>
<TeamProfile
name="Inka Sokolowska"
role="Software Engineer"
githubHandle="InkaAlicja"
imageURL={`${assetsCacheURLPrefix}/inka.jpg`}
/>
<TeamProfile
name="Kamil Kurowski" name="Kamil Kurowski"
role="Software Engineer" role="Software Engineer"
githubHandle="xsanm" githubHandle="xsanm"
imageURL={`${assetsCacheURLPrefix}/kamil.jpg`} imageURL={`${assetsCacheURLPrefix}/kamil.jpg`}
/> />
<TeamProfile <TeamProfile
name="Michał Gniadek"
role="Software Engineer"
githubHandle="MichalGniadek"
imageURL={`${assetsCacheURLPrefix}/michał.jpg`}
/>
<TeamProfile
name="Bartłomiej Klocek" name="Bartłomiej Klocek"
role="Software Engineer" role="Software Engineer"
githubHandle="barthap" githubHandle="barthap"
twitterHandle="barthap10" twitterHandle="barthap10"
imageURL={`${assetsCacheURLPrefix}/bartłomiej.jpg`} imageURL={`${assetsCacheURLPrefix}/bartłomiej.jpg`}
/> />
<TeamProfile <TeamProfile
name="Aleksandra Grzęda" name="Angelika Serwa"
role="Project Manager" role="Software Engineer"
imageURL={`${assetsCacheURLPrefix}/aleksandra.jpg`} githubHandle="graszka22"
imageURL={`${assetsCacheURLPrefix}/angelika.png`}
/> />
<TeamProfile <TeamProfile
name="Monika Kulczyńska" name="Monika Kulczyńska"
role="Project Manager" role="Project Manager"
imageURL={`${assetsCacheURLPrefix}/monika.jpg`} imageURL={`${assetsCacheURLPrefix}/monika.jpg`}
/> />
</section> </section>
</div> </div>
); );
} }
export default Team; export default Team;